* [PATCH] ARM: pxa: activate pinctrl for device-tree machines
@ 2016-04-02 18:56 Robert Jarzmik
2016-04-03 19:13 ` Linus Walleij
0 siblings, 1 reply; 3+ messages in thread
From: Robert Jarzmik @ 2016-04-02 18:56 UTC (permalink / raw)
To: Daniel Mack, Haojian Zhuang, Robert Jarzmik
Cc: linux-arm-kernel, linux-kernel, Linus Walleij, Masahiro Yamada
Pincontrol is not yet ready for all PXA platforms.
For example, a legacy platform, if PINCTRL was activated, will fail its
calls to gpio_request() or gpio_direction_output(), as the pinctrl
driver might not be available, such as for pxa25x and pxa3xx.
As a step forward, activate pincontrol for all device-tree available
machines, ie. pxa27x device-tree based and pxa3xx device-tree based.
If it appears later that pincontrol is also required for legacy
platforms and if the mfp->pinctrl conversion can be achieved, then
PINCTRL will be activated for the whole PXA architecture.
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
---
arch/arm/mach-pxa/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-pxa/Kconfig b/arch/arm/mach-pxa/Kconfig
index 7ee4652b4c61..cd894d69e766 100644
--- a/arch/arm/mach-pxa/Kconfig
+++ b/arch/arm/mach-pxa/Kconfig
@@ -6,6 +6,7 @@ comment "Intel/Marvell Dev Platforms (sorted by hardware release time)"
config MACH_PXA27X_DT
bool "Support PXA27x platforms from device tree"
+ select PINCTRL
select POWER_SUPPLY
select PXA27x
select USE_OF
@@ -17,6 +18,7 @@ config MACH_PXA27X_DT
config MACH_PXA3XX_DT
bool "Support PXA3xx platforms from device tree"
select CPU_PXA300
+ select PINCTRL
select POWER_SUPPLY
select PXA3xx
select USE_OF
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: pxa: activate pinctrl for device-tree machines
2016-04-02 18:56 [PATCH] ARM: pxa: activate pinctrl for device-tree machines Robert Jarzmik
@ 2016-04-03 19:13 ` Linus Walleij
2016-04-11 19:51 ` Robert Jarzmik
0 siblings, 1 reply; 3+ messages in thread
From: Linus Walleij @ 2016-04-03 19:13 UTC (permalink / raw)
To: Robert Jarzmik
Cc: Daniel Mack, Haojian Zhuang, linux-arm-kernel, linux-kernel,
Masahiro Yamada
On Sat, Apr 2, 2016 at 8:56 PM, Robert Jarzmik <robert.jarzmik@free.fr> wrote:
> Pincontrol is not yet ready for all PXA platforms.
> For example, a legacy platform, if PINCTRL was activated, will fail its
> calls to gpio_request() or gpio_direction_output(), as the pinctrl
> driver might not be available, such as for pxa25x and pxa3xx.
>
> As a step forward, activate pincontrol for all device-tree available
> machines, ie. pxa27x device-tree based and pxa3xx device-tree based.
>
> If it appears later that pincontrol is also required for legacy
> platforms and if the mfp->pinctrl conversion can be achieved, then
> PINCTRL will be activated for the whole PXA architecture.
>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: pxa: activate pinctrl for device-tree machines
2016-04-03 19:13 ` Linus Walleij
@ 2016-04-11 19:51 ` Robert Jarzmik
0 siblings, 0 replies; 3+ messages in thread
From: Robert Jarzmik @ 2016-04-11 19:51 UTC (permalink / raw)
To: Linus Walleij
Cc: Daniel Mack, Haojian Zhuang, linux-arm-kernel, linux-kernel,
Masahiro Yamada
Linus Walleij <linus.walleij@linaro.org> writes:
> On Sat, Apr 2, 2016 at 8:56 PM, Robert Jarzmik <robert.jarzmik@free.fr> wrote:
>
>> Pincontrol is not yet ready for all PXA platforms.
>> For example, a legacy platform, if PINCTRL was activated, will fail its
>> calls to gpio_request() or gpio_direction_output(), as the pinctrl
>> driver might not be available, such as for pxa25x and pxa3xx.
>>
>> As a step forward, activate pincontrol for all device-tree available
>> machines, ie. pxa27x device-tree based and pxa3xx device-tree based.
>>
>> If it appears later that pincontrol is also required for legacy
>> platforms and if the mfp->pinctrl conversion can be achieved, then
>> PINCTRL will be activated for the whole PXA architecture.
>>
>> Cc: Linus Walleij <linus.walleij@linaro.org>
>> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
>> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
Thanks, queued to pxa/for-next.
Cheers.
--
Robert
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-04-11 19:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-02 18:56 [PATCH] ARM: pxa: activate pinctrl for device-tree machines Robert Jarzmik
2016-04-03 19:13 ` Linus Walleij
2016-04-11 19:51 ` Robert Jarzmik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).