* [PATCH -next v2] pinctrl: mcp23s08: Fix missing unlock on error in mcp23s08_irq()
@ 2021-06-08 6:34 Zou Wei
2021-06-09 11:13 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Zou Wei @ 2021-06-08 6:34 UTC (permalink / raw)
To: linus.walleij, radim.pavlik; +Cc: linux-gpio, linux-kernel, Zou Wei
Add the missing unlock before return from function mcp23s08_irq()
in the error handling case.
v1-->v2:
remove the "return IRQ_HANDLED" line
Fixes: 897120d41e7a ("pinctrl: mcp23s08: fix race condition in irq handler")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
drivers/pinctrl/pinctrl-mcp23s08.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-mcp23s08.c b/drivers/pinctrl/pinctrl-mcp23s08.c
index 799d596..d025957 100644
--- a/drivers/pinctrl/pinctrl-mcp23s08.c
+++ b/drivers/pinctrl/pinctrl-mcp23s08.c
@@ -353,7 +353,7 @@ static irqreturn_t mcp23s08_irq(int irq, void *data)
if (intf == 0) {
/* There is no interrupt pending */
- return IRQ_HANDLED;
+ goto unlock;
}
if (mcp_read(mcp, MCP_INTCAP, &intcap))
--
2.6.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next v2] pinctrl: mcp23s08: Fix missing unlock on error in mcp23s08_irq()
2021-06-08 6:34 [PATCH -next v2] pinctrl: mcp23s08: Fix missing unlock on error in mcp23s08_irq() Zou Wei
@ 2021-06-09 11:13 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2021-06-09 11:13 UTC (permalink / raw)
To: Zou Wei; +Cc: Radim Pavlik, open list:GPIO SUBSYSTEM, linux-kernel
On Tue, Jun 8, 2021 at 8:16 AM Zou Wei <zou_wei@huawei.com> wrote:
> Add the missing unlock before return from function mcp23s08_irq()
> in the error handling case.
>
> v1-->v2:
> remove the "return IRQ_HANDLED" line
>
> Fixes: 897120d41e7a ("pinctrl: mcp23s08: fix race condition in irq handler")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-09 11:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-08 6:34 [PATCH -next v2] pinctrl: mcp23s08: Fix missing unlock on error in mcp23s08_irq() Zou Wei
2021-06-09 11:13 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).