* [PATCH] gpio: mxs: remove __init annotation
@ 2016-12-16 9:08 Arnd Bergmann
2016-12-30 8:03 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2016-12-16 9:08 UTC (permalink / raw)
To: Linus Walleij, Alexandre Courbot
Cc: Arnd Bergmann, Marek Vasut, Sascha Hauer, Gregory Fong,
Arvind Yadav, linux-gpio, linux-kernel
Building with an old toolchain, I ran into this warning:
WARNING: vmlinux.o(.text+0x63eef0): Section mismatch in reference from the function mxs_gpio_probe() to the function .init.text:mxs_gpio_init_gc()
Clearly the annotation is wrong, since the function is called from the
non-init probe, so let's remove it.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpio/gpio-mxs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-mxs.c b/drivers/gpio/gpio-mxs.c
index 1e8fde8cb803..2292742eac8f 100644
--- a/drivers/gpio/gpio-mxs.c
+++ b/drivers/gpio/gpio-mxs.c
@@ -205,7 +205,7 @@ static int mxs_gpio_set_wake_irq(struct irq_data *d, unsigned int enable)
return 0;
}
-static int __init mxs_gpio_init_gc(struct mxs_gpio_port *port, int irq_base)
+static int mxs_gpio_init_gc(struct mxs_gpio_port *port, int irq_base)
{
struct irq_chip_generic *gc;
struct irq_chip_type *ct;
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio: mxs: remove __init annotation
2016-12-16 9:08 [PATCH] gpio: mxs: remove __init annotation Arnd Bergmann
@ 2016-12-30 8:03 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2016-12-30 8:03 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Alexandre Courbot, Marek Vasut, Sascha Hauer, Gregory Fong,
Arvind Yadav, linux-gpio, linux-kernel
On Fri, Dec 16, 2016 at 10:08 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> Building with an old toolchain, I ran into this warning:
>
> WARNING: vmlinux.o(.text+0x63eef0): Section mismatch in reference from the function mxs_gpio_probe() to the function .init.text:mxs_gpio_init_gc()
>
> Clearly the annotation is wrong, since the function is called from the
> non-init probe, so let's remove it.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Patch applied for fixes.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-30 8:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-16 9:08 [PATCH] gpio: mxs: remove __init annotation Arnd Bergmann
2016-12-30 8:03 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).