* [PATCH] PCI: v3-semi: Fix a memory leak in some error handling paths in 'v3_pci_probe()'
@ 2020-04-18 8:16 Christophe JAILLET
2020-04-19 9:51 ` Linus Walleij
2020-05-05 11:04 ` Lorenzo Pieralisi
0 siblings, 2 replies; 3+ messages in thread
From: Christophe JAILLET @ 2020-04-18 8:16 UTC (permalink / raw)
To: linus.walleij, lorenzo.pieralisi, amurray, bhelgaas
Cc: linux-pci, linux-kernel, kernel-janitors, Christophe JAILLET
IF we fails somewhere in 'v3_pci_probe()', we need to free 'host'.
Use the managed version of 'pci_alloc_host_bridge()' to do that easily.
The use of managed resources is already widely used in this driver.
Fixes: 68a15eb7bd0c ("PCI: v3-semi: Add V3 Semiconductor PCI host driver")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
Fixes could be older than this commit, but this is as far as git can go.
There is also a 'clk_prepare_enable()' which looks un-ballanced. I don't
know if it can be an issue.
Compile tested only.
---
drivers/pci/controller/pci-v3-semi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/controller/pci-v3-semi.c b/drivers/pci/controller/pci-v3-semi.c
index bd05221f5a22..ddcb4571a79b 100644
--- a/drivers/pci/controller/pci-v3-semi.c
+++ b/drivers/pci/controller/pci-v3-semi.c
@@ -720,7 +720,7 @@ static int v3_pci_probe(struct platform_device *pdev)
int irq;
int ret;
- host = pci_alloc_host_bridge(sizeof(*v3));
+ host = devm_pci_alloc_host_bridge(dev, sizeof(*v3));
if (!host)
return -ENOMEM;
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] PCI: v3-semi: Fix a memory leak in some error handling paths in 'v3_pci_probe()'
2020-04-18 8:16 [PATCH] PCI: v3-semi: Fix a memory leak in some error handling paths in 'v3_pci_probe()' Christophe JAILLET
@ 2020-04-19 9:51 ` Linus Walleij
2020-05-05 11:04 ` Lorenzo Pieralisi
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2020-04-19 9:51 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Lorenzo Pieralisi, Andrew Murray, Bjorn Helgaas, linux-pci,
linux-kernel, kernel-janitors
On Sat, Apr 18, 2020 at 10:16 AM Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
> IF we fails somewhere in 'v3_pci_probe()', we need to free 'host'.
> Use the managed version of 'pci_alloc_host_bridge()' to do that easily.
> The use of managed resources is already widely used in this driver.
>
> Fixes: 68a15eb7bd0c ("PCI: v3-semi: Add V3 Semiconductor PCI host driver")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PCI: v3-semi: Fix a memory leak in some error handling paths in 'v3_pci_probe()'
2020-04-18 8:16 [PATCH] PCI: v3-semi: Fix a memory leak in some error handling paths in 'v3_pci_probe()' Christophe JAILLET
2020-04-19 9:51 ` Linus Walleij
@ 2020-05-05 11:04 ` Lorenzo Pieralisi
1 sibling, 0 replies; 3+ messages in thread
From: Lorenzo Pieralisi @ 2020-05-05 11:04 UTC (permalink / raw)
To: Christophe JAILLET
Cc: linus.walleij, amurray, bhelgaas, linux-pci, linux-kernel,
kernel-janitors
On Sat, Apr 18, 2020 at 10:16:37AM +0200, Christophe JAILLET wrote:
> IF we fails somewhere in 'v3_pci_probe()', we need to free 'host'.
> Use the managed version of 'pci_alloc_host_bridge()' to do that easily.
> The use of managed resources is already widely used in this driver.
>
> Fixes: 68a15eb7bd0c ("PCI: v3-semi: Add V3 Semiconductor PCI host driver")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> Fixes could be older than this commit, but this is as far as git can go.
>
> There is also a 'clk_prepare_enable()' which looks un-ballanced. I don't
> know if it can be an issue.
>
> Compile tested only.
> ---
> drivers/pci/controller/pci-v3-semi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to pci/v3-semi, thanks !
Lorenzo
> diff --git a/drivers/pci/controller/pci-v3-semi.c b/drivers/pci/controller/pci-v3-semi.c
> index bd05221f5a22..ddcb4571a79b 100644
> --- a/drivers/pci/controller/pci-v3-semi.c
> +++ b/drivers/pci/controller/pci-v3-semi.c
> @@ -720,7 +720,7 @@ static int v3_pci_probe(struct platform_device *pdev)
> int irq;
> int ret;
>
> - host = pci_alloc_host_bridge(sizeof(*v3));
> + host = devm_pci_alloc_host_bridge(dev, sizeof(*v3));
> if (!host)
> return -ENOMEM;
>
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-05 11:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-18 8:16 [PATCH] PCI: v3-semi: Fix a memory leak in some error handling paths in 'v3_pci_probe()' Christophe JAILLET
2020-04-19 9:51 ` Linus Walleij
2020-05-05 11:04 ` Lorenzo Pieralisi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).