From: Linus Walleij <linus.walleij@linaro.org>
To: Christian Lamparter <chunkeey@googlemail.com>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Álvaro Fernández Rojas" <noltari@gmail.com>,
"Alexandre Courbot" <gnurou@gmail.com>,
"Andy Shevchenko" <andy.shevchenko@gmail.com>,
"Joachim Eastwood" <manabian@gmail.com>
Subject: Re: [PATCH v10 1/2] gpio: mmio: add DT support for memory-mapped GPIOs
Date: Wed, 8 Jun 2016 11:16:14 +0200 [thread overview]
Message-ID: <CACRpkdZ4A+HtYa0fn+uuHFaBXTELK3A9xRrZ==C85+33d5r5Zg@mail.gmail.com> (raw)
In-Reply-To: <4af460fea30b60fbb1d621fcb568c5f3b04e1eee.1463172434.git.chunkeey@googlemail.com>
On Fri, May 13, 2016 at 11:07 PM, Christian Lamparter
<chunkeey@googlemail.com> wrote:
> From: Álvaro Fernández Rojas <noltari@gmail.com>
>
> This patch adds support for defining memory-mapped GPIOs which
> are compatible with the existing gpio-mmio interface. The generic
> library provides support for many memory-mapped GPIO controllers
> that are found in various on-board FPGA and ASIC solutions that
> are used to control board's switches, LEDs, chip-selects,
> Ethernet/USB PHY power, etc.
>
> For setting GPIOs there are three configurations:
> 1. single input/output register resource (named "dat"),
> 2. set/clear pair (named "set" and "clr"),
> 3. single output register resource and single input resource
> ("set" and dat").
>
> The configuration is detected by which resources are present.
> For the single output register, this drives a 1 by setting a bit
> and a zero by clearing a bit. For the set clr pair, this drives
> a 1 by setting a bit in the set register and clears it by setting
> a bit in the clear register.
>
> For setting the GPIO direction, there are three configurations:
> a. simple bidirectional GPIOs that requires no configuration.
> b. an output direction register (named "dirout")
> where a 1 bit indicates the GPIO is an output.
> c. an input direction register (named "dirin")
> where a 1 bit indicates the GPIO is an input.
>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
> Signed-off-by: Christian Lamparter <chunkeey@googlemail.com>
Patch applied with Alex' ACK.
Yours,
Linus Walleij
next prev parent reply other threads:[~2016-06-08 9:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 21:07 [PATCH v10 0/2] gpio: add DT support for memory-mapped GPIOs Christian Lamparter
2016-05-13 21:07 ` [PATCH v10 1/2] gpio: mmio: " Christian Lamparter
2016-06-08 9:16 ` Linus Walleij [this message]
2016-05-13 21:07 ` [PATCH v10 2/2] gpio: mmio: add MyBook Live GPIO support Christian Lamparter
2016-06-08 9:17 ` Linus Walleij
2016-05-24 10:43 ` [PATCH v10 0/2] gpio: add DT support for memory-mapped GPIOs Linus Walleij
2016-06-07 3:49 ` Alexandre Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdZ4A+HtYa0fn+uuHFaBXTELK3A9xRrZ==C85+33d5r5Zg@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=andy.shevchenko@gmail.com \
--cc=chunkeey@googlemail.com \
--cc=gnurou@gmail.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manabian@gmail.com \
--cc=noltari@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).