* [PATCH 0/2] tools/gpio: Add missing initialization of device_name
@ 2016-03-25 12:36 Geert Uytterhoeven
2016-03-25 12:36 ` [PATCH 1/2] tools/gpio: Enable compiler optimization to catch more bugs Geert Uytterhoeven
2016-03-25 12:36 ` [PATCH 2/2] tools/gpio: Add missing initialization of device_name Geert Uytterhoeven
0 siblings, 2 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2016-03-25 12:36 UTC (permalink / raw)
To: Linus Walleij, Alexandre Courbot
Cc: linux-gpio, linux-kernel, Geert Uytterhoeven
Hi Linus, Alex,
This small series enables compiler optimization for the GPIO tools, to
catch more bugs, and fix the bug found by it.
Geert Uytterhoeven (2):
tools/gpio: Enable compiler optimization to catch more bugs
tools/gpio: Add missing initialization of device_name
tools/gpio/Makefile | 2 +-
tools/gpio/lsgpio.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
1.9.1
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] tools/gpio: Enable compiler optimization to catch more bugs
2016-03-25 12:36 [PATCH 0/2] tools/gpio: Add missing initialization of device_name Geert Uytterhoeven
@ 2016-03-25 12:36 ` Geert Uytterhoeven
2016-03-31 9:50 ` Linus Walleij
2016-03-25 12:36 ` [PATCH 2/2] tools/gpio: Add missing initialization of device_name Geert Uytterhoeven
1 sibling, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2016-03-25 12:36 UTC (permalink / raw)
To: Linus Walleij, Alexandre Courbot
Cc: linux-gpio, linux-kernel, Geert Uytterhoeven
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
tools/gpio/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/gpio/Makefile b/tools/gpio/Makefile
index 4d198d5c42032661..c155d6bc47a7580c 100644
--- a/tools/gpio/Makefile
+++ b/tools/gpio/Makefile
@@ -1,5 +1,5 @@
CC = $(CROSS_COMPILE)gcc
-CFLAGS += -Wall -g -D_GNU_SOURCE
+CFLAGS += -O2 -Wall -g -D_GNU_SOURCE
all: lsgpio
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] tools/gpio: Add missing initialization of device_name
2016-03-25 12:36 [PATCH 0/2] tools/gpio: Add missing initialization of device_name Geert Uytterhoeven
2016-03-25 12:36 ` [PATCH 1/2] tools/gpio: Enable compiler optimization to catch more bugs Geert Uytterhoeven
@ 2016-03-25 12:36 ` Geert Uytterhoeven
2016-03-31 9:51 ` Linus Walleij
1 sibling, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2016-03-25 12:36 UTC (permalink / raw)
To: Linus Walleij, Alexandre Courbot
Cc: linux-gpio, linux-kernel, Geert Uytterhoeven
lsgpio.c: In function ‘main’:
lsgpio.c:166:7: warning: ‘device_name’ may be used uninitialized in this functio
n [-Wmaybe-uninitialized]
ret = list_device(device_name);
^
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
tools/gpio/lsgpio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/gpio/lsgpio.c b/tools/gpio/lsgpio.c
index 1124da3759424fe6..eb3f56efd2158b4c 100644
--- a/tools/gpio/lsgpio.c
+++ b/tools/gpio/lsgpio.c
@@ -147,7 +147,7 @@ void print_usage(void)
int main(int argc, char **argv)
{
- const char *device_name;
+ const char *device_name = NULL;
int ret;
int c;
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] tools/gpio: Enable compiler optimization to catch more bugs
2016-03-25 12:36 ` [PATCH 1/2] tools/gpio: Enable compiler optimization to catch more bugs Geert Uytterhoeven
@ 2016-03-31 9:50 ` Linus Walleij
0 siblings, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2016-03-31 9:50 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Alexandre Courbot, linux-gpio, linux-kernel
On Fri, Mar 25, 2016 at 1:36 PM, Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
OK patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] tools/gpio: Add missing initialization of device_name
2016-03-25 12:36 ` [PATCH 2/2] tools/gpio: Add missing initialization of device_name Geert Uytterhoeven
@ 2016-03-31 9:51 ` Linus Walleij
0 siblings, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2016-03-31 9:51 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Alexandre Courbot, linux-gpio, linux-kernel
On Fri, Mar 25, 2016 at 1:36 PM, Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
> lsgpio.c: In function ‘main’:
> lsgpio.c:166:7: warning: ‘device_name’ may be used uninitialized in this functio
> n [-Wmaybe-uninitialized]
> ret = list_device(device_name);
> ^
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-03-31 9:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-25 12:36 [PATCH 0/2] tools/gpio: Add missing initialization of device_name Geert Uytterhoeven
2016-03-25 12:36 ` [PATCH 1/2] tools/gpio: Enable compiler optimization to catch more bugs Geert Uytterhoeven
2016-03-31 9:50 ` Linus Walleij
2016-03-25 12:36 ` [PATCH 2/2] tools/gpio: Add missing initialization of device_name Geert Uytterhoeven
2016-03-31 9:51 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).