* [PATCH 1/9] pinctrl: Use seq_putc() in three functions
2017-05-02 9:20 [PATCH 0/9] pinctrl: Fine-tuning for some function implementations SF Markus Elfring
@ 2017-05-02 9:21 ` SF Markus Elfring
2017-05-11 11:34 ` Linus Walleij
2017-05-02 9:22 ` [PATCH 2/9] pinctrl: Combine two seq_puts() calls into one call in two functions SF Markus Elfring
` (7 subsequent siblings)
8 siblings, 1 reply; 21+ messages in thread
From: SF Markus Elfring @ 2017-05-02 9:21 UTC (permalink / raw)
To: linux-gpio, Linus Walleij; +Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 1 May 2017 22:24:29 +0200
A single character (line break) should be put into a sequence.
Thus use the corresponding function "seq_putc".
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/pinctrl/pinconf.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/pinctrl/pinconf.c b/drivers/pinctrl/pinconf.c
index a02dba35fcf3..1a3fbdf81ecb 100644
--- a/drivers/pinctrl/pinconf.c
+++ b/drivers/pinctrl/pinconf.c
@@ -232,7 +232,7 @@ static void pinconf_show_config(struct seq_file *s, struct pinctrl_dev *pctldev,
configs[i]);
else
seq_printf(s, "%08lx", configs[i]);
- seq_puts(s, "\n");
+ seq_putc(s, '\n');
}
}
@@ -325,8 +325,7 @@ static int pinconf_pins_show(struct seq_file *s, void *what)
seq_printf(s, "pin %d (%s): ", pin, desc->name);
pinconf_dump_pin(pctldev, s, pin);
-
- seq_printf(s, "\n");
+ seq_putc(s, '\n');
}
mutex_unlock(&pctldev->mutex);
@@ -361,8 +360,7 @@ static int pinconf_groups_show(struct seq_file *s, void *what)
seq_printf(s, "%u (%s): ", selector, gname);
pinconf_dump_group(pctldev, s, selector, gname);
- seq_printf(s, "\n");
-
+ seq_putc(s, '\n');
selector++;
}
--
2.12.2
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [PATCH 1/9] pinctrl: Use seq_putc() in three functions
2017-05-02 9:21 ` [PATCH 1/9] pinctrl: Use seq_putc() in three functions SF Markus Elfring
@ 2017-05-11 11:34 ` Linus Walleij
0 siblings, 0 replies; 21+ messages in thread
From: Linus Walleij @ 2017-05-11 11:34 UTC (permalink / raw)
To: SF Markus Elfring; +Cc: linux-gpio, LKML, kernel-janitors
On Tue, May 2, 2017 at 11:21 AM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 1 May 2017 22:24:29 +0200
>
> A single character (line break) should be put into a sequence.
> Thus use the corresponding function "seq_putc".
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Looks reasonable. Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 2/9] pinctrl: Combine two seq_puts() calls into one call in two functions
2017-05-02 9:20 [PATCH 0/9] pinctrl: Fine-tuning for some function implementations SF Markus Elfring
2017-05-02 9:21 ` [PATCH 1/9] pinctrl: Use seq_putc() in three functions SF Markus Elfring
@ 2017-05-02 9:22 ` SF Markus Elfring
2017-05-03 17:47 ` Andy Shevchenko
2017-05-02 9:23 ` [PATCH 3/9] pinctrl: Combine five seq_printf() calls into one call in pinconf_dbg_config_print() SF Markus Elfring
` (6 subsequent siblings)
8 siblings, 1 reply; 21+ messages in thread
From: SF Markus Elfring @ 2017-05-02 9:22 UTC (permalink / raw)
To: linux-gpio, Linus Walleij; +Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 1 May 2017 22:42:13 +0200
Some text was put into a sequence by two separate function calls.
Print the same data by a single function call instead.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/pinctrl/pinconf.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/pinctrl/pinconf.c b/drivers/pinctrl/pinconf.c
index 1a3fbdf81ecb..a14ae8601b39 100644
--- a/drivers/pinctrl/pinconf.c
+++ b/drivers/pinctrl/pinconf.c
@@ -307,9 +307,9 @@ static int pinconf_pins_show(struct seq_file *s, void *what)
struct pinctrl_dev *pctldev = s->private;
unsigned i, pin;
- seq_puts(s, "Pin config settings per pin\n");
- seq_puts(s, "Format: pin (name): configs\n");
-
+ seq_puts(s,
+ "Pin config settings per pin\n"
+ "Format: pin (name): configs\n");
mutex_lock(&pctldev->mutex);
/* The pin number can be retrived from the pin controller descriptor */
@@ -352,8 +352,9 @@ static int pinconf_groups_show(struct seq_file *s, void *what)
unsigned ngroups = pctlops->get_groups_count(pctldev);
unsigned selector = 0;
- seq_puts(s, "Pin config settings per pin group\n");
- seq_puts(s, "Format: group (name): configs\n");
+ seq_puts(s,
+ "Pin config settings per pin group\n"
+ "Format: group (name): configs\n");
while (selector < ngroups) {
const char *gname = pctlops->get_group_name(pctldev, selector);
--
2.12.2
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [PATCH 2/9] pinctrl: Combine two seq_puts() calls into one call in two functions
2017-05-02 9:22 ` [PATCH 2/9] pinctrl: Combine two seq_puts() calls into one call in two functions SF Markus Elfring
@ 2017-05-03 17:47 ` Andy Shevchenko
0 siblings, 0 replies; 21+ messages in thread
From: Andy Shevchenko @ 2017-05-03 17:47 UTC (permalink / raw)
To: SF Markus Elfring; +Cc: linux-gpio, Linus Walleij, LKML, kernel-janitors
On Tue, May 2, 2017 at 12:22 PM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 1 May 2017 22:42:13 +0200
>
> Some text was put into a sequence by two separate function calls.
> Print the same data by a single function call instead.
I don't see a benefit here, sorry.
This is slow path in any case (printing is slow). Currently code is
neat, you do it slightly harder to parse.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 3/9] pinctrl: Combine five seq_printf() calls into one call in pinconf_dbg_config_print()
2017-05-02 9:20 [PATCH 0/9] pinctrl: Fine-tuning for some function implementations SF Markus Elfring
2017-05-02 9:21 ` [PATCH 1/9] pinctrl: Use seq_putc() in three functions SF Markus Elfring
2017-05-02 9:22 ` [PATCH 2/9] pinctrl: Combine two seq_puts() calls into one call in two functions SF Markus Elfring
@ 2017-05-02 9:23 ` SF Markus Elfring
2017-05-03 17:48 ` Andy Shevchenko
2017-05-02 9:24 ` [PATCH 4/9] pinctrl: Replace two seq_printf() calls by seq_puts() in pinconf_show_map() SF Markus Elfring
` (5 subsequent siblings)
8 siblings, 1 reply; 21+ messages in thread
From: SF Markus Elfring @ 2017-05-02 9:23 UTC (permalink / raw)
To: linux-gpio, Linus Walleij; +Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 1 May 2017 22:52:29 +0200
Some data were put into a sequence by five separate function calls.
Print the same data by a single function call instead.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/pinctrl/pinconf.c | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/drivers/pinctrl/pinconf.c b/drivers/pinctrl/pinconf.c
index a14ae8601b39..d37f98aafb4b 100644
--- a/drivers/pinctrl/pinconf.c
+++ b/drivers/pinctrl/pinconf.c
@@ -441,12 +441,15 @@ static int pinconf_dbg_config_print(struct seq_file *s, void *d)
}
if (!found) {
- seq_printf(s, "No config found for dev/state/pin, expected:\n");
- seq_printf(s, "Searched dev:%s\n", dbg->dev_name);
- seq_printf(s, "Searched state:%s\n", dbg->state_name);
- seq_printf(s, "Searched pin:%s\n", dbg->pin_name);
- seq_printf(s, "Use: modify config_pin <devname> "\
- "<state> <pinname> <value>\n");
+ seq_printf(s,
+ "No config found for dev/state/pin, expected:\n"
+ "Searched dev:%s\n"
+ "Searched state:%s\n"
+ "Searched pin:%s\n"
+ "Use: modify config_pin <devname> <state> <pinname> <value>\n",
+ dbg->dev_name,
+ dbg->state_name,
+ dbg->pin_name);
goto exit;
}
--
2.12.2
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [PATCH 3/9] pinctrl: Combine five seq_printf() calls into one call in pinconf_dbg_config_print()
2017-05-02 9:23 ` [PATCH 3/9] pinctrl: Combine five seq_printf() calls into one call in pinconf_dbg_config_print() SF Markus Elfring
@ 2017-05-03 17:48 ` Andy Shevchenko
0 siblings, 0 replies; 21+ messages in thread
From: Andy Shevchenko @ 2017-05-03 17:48 UTC (permalink / raw)
To: SF Markus Elfring; +Cc: linux-gpio, Linus Walleij, LKML, kernel-janitors
On Tue, May 2, 2017 at 12:23 PM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 1 May 2017 22:52:29 +0200
>
> Some data were put into a sequence by five separate function calls.
> Print the same data by a single function call instead.
> - seq_printf(s, "No config found for dev/state/pin, expected:\n");
> - seq_printf(s, "Searched dev:%s\n", dbg->dev_name);
> - seq_printf(s, "Searched state:%s\n", dbg->state_name);
> - seq_printf(s, "Searched pin:%s\n", dbg->pin_name);
> - seq_printf(s, "Use: modify config_pin <devname> "\
> - "<state> <pinname> <value>\n");
> + seq_printf(s,
> + "No config found for dev/state/pin, expected:\n"
> + "Searched dev:%s\n"
> + "Searched state:%s\n"
> + "Searched pin:%s\n"
> + "Use: modify config_pin <devname> <state> <pinname> <value>\n",
> + dbg->dev_name,
> + dbg->state_name,
> + dbg->pin_name);
Please, no.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 4/9] pinctrl: Replace two seq_printf() calls by seq_puts() in pinconf_show_map()
2017-05-02 9:20 [PATCH 0/9] pinctrl: Fine-tuning for some function implementations SF Markus Elfring
` (2 preceding siblings ...)
2017-05-02 9:23 ` [PATCH 3/9] pinctrl: Combine five seq_printf() calls into one call in pinconf_dbg_config_print() SF Markus Elfring
@ 2017-05-02 9:24 ` SF Markus Elfring
2017-05-11 13:24 ` Linus Walleij
2017-05-02 9:25 ` [PATCH 5/9] pinctrl: Adjust five checks for null pointers SF Markus Elfring
` (4 subsequent siblings)
8 siblings, 1 reply; 21+ messages in thread
From: SF Markus Elfring @ 2017-05-02 9:24 UTC (permalink / raw)
To: linux-gpio, Linus Walleij; +Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 2 May 2017 09:52:50 +0200
Strings which did not contain data format specifications should be put
into a sequence. Thus use the corresponding function "seq_puts".
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/pinctrl/pinconf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/pinconf.c b/drivers/pinctrl/pinconf.c
index d37f98aafb4b..dfa782e19f37 100644
--- a/drivers/pinctrl/pinconf.c
+++ b/drivers/pinctrl/pinconf.c
@@ -244,10 +244,10 @@ void pinconf_show_map(struct seq_file *s, struct pinctrl_map const *map)
switch (map->type) {
case PIN_MAP_TYPE_CONFIGS_PIN:
- seq_printf(s, "pin ");
+ seq_puts(s, "pin ");
break;
case PIN_MAP_TYPE_CONFIGS_GROUP:
- seq_printf(s, "group ");
+ seq_puts(s, "group ");
break;
default:
break;
--
2.12.2
^ permalink raw reply related [flat|nested] 21+ messages in thread* [PATCH 5/9] pinctrl: Adjust five checks for null pointers
2017-05-02 9:20 [PATCH 0/9] pinctrl: Fine-tuning for some function implementations SF Markus Elfring
` (3 preceding siblings ...)
2017-05-02 9:24 ` [PATCH 4/9] pinctrl: Replace two seq_printf() calls by seq_puts() in pinconf_show_map() SF Markus Elfring
@ 2017-05-02 9:25 ` SF Markus Elfring
2017-05-11 13:25 ` Linus Walleij
2017-05-02 9:26 ` [PATCH 6/9] pinctrl: Combine substrings for a message in pin_config_group_get() SF Markus Elfring
` (3 subsequent siblings)
8 siblings, 1 reply; 21+ messages in thread
From: SF Markus Elfring @ 2017-05-02 9:25 UTC (permalink / raw)
To: linux-gpio, Linus Walleij; +Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 2 May 2017 10:01:57 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script “checkpatch.pl” pointed information out like the following.
Comparison to NULL could be written !…
Thus fix the affected source code places.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/pinctrl/pinconf.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/pinctrl/pinconf.c b/drivers/pinctrl/pinconf.c
index dfa782e19f37..f2168b6e3418 100644
--- a/drivers/pinctrl/pinconf.c
+++ b/drivers/pinctrl/pinconf.c
@@ -319,7 +319,7 @@ static int pinconf_pins_show(struct seq_file *s, void *what)
pin = pctldev->desc->pins[i].number;
desc = pin_desc_get(pctldev, pin);
/* Skip if we cannot search the pin */
- if (desc == NULL)
+ if (!desc)
continue;
seq_printf(s, "pin %d (%s): ", pin, desc->name);
@@ -528,7 +528,7 @@ static ssize_t pinconf_dbg_config_write(struct file *file,
/* get arg 'device_name' */
token = strsep(&b, " ");
- if (token == NULL)
+ if (!token)
return -EINVAL;
if (strlen(token) >= MAX_NAME_LEN)
return -EINVAL;
@@ -536,7 +536,7 @@ static ssize_t pinconf_dbg_config_write(struct file *file,
/* get arg 'state_name' */
token = strsep(&b, " ");
- if (token == NULL)
+ if (!token)
return -EINVAL;
if (strlen(token) >= MAX_NAME_LEN)
return -EINVAL;
@@ -544,7 +544,7 @@ static ssize_t pinconf_dbg_config_write(struct file *file,
/* get arg 'pin_name' */
token = strsep(&b, " ");
- if (token == NULL)
+ if (!token)
return -EINVAL;
if (strlen(token) >= MAX_NAME_LEN)
return -EINVAL;
@@ -552,7 +552,7 @@ static ssize_t pinconf_dbg_config_write(struct file *file,
/* get new_value of config' */
token = strsep(&b, " ");
- if (token == NULL)
+ if (!token)
return -EINVAL;
if (strlen(token) >= MAX_NAME_LEN)
return -EINVAL;
--
2.12.2
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [PATCH 5/9] pinctrl: Adjust five checks for null pointers
2017-05-02 9:25 ` [PATCH 5/9] pinctrl: Adjust five checks for null pointers SF Markus Elfring
@ 2017-05-11 13:25 ` Linus Walleij
0 siblings, 0 replies; 21+ messages in thread
From: Linus Walleij @ 2017-05-11 13:25 UTC (permalink / raw)
To: SF Markus Elfring; +Cc: linux-gpio, LKML, kernel-janitors
On Tue, May 2, 2017 at 11:25 AM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 2 May 2017 10:01:57 +0200
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> The script “checkpatch.pl” pointed information out like the following.
>
> Comparison to NULL could be written !…
>
> Thus fix the affected source code places.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 6/9] pinctrl: Combine substrings for a message in pin_config_group_get()
2017-05-02 9:20 [PATCH 0/9] pinctrl: Fine-tuning for some function implementations SF Markus Elfring
` (4 preceding siblings ...)
2017-05-02 9:25 ` [PATCH 5/9] pinctrl: Adjust five checks for null pointers SF Markus Elfring
@ 2017-05-02 9:26 ` SF Markus Elfring
2017-05-03 17:49 ` Andy Shevchenko
2017-05-11 13:26 ` Linus Walleij
2017-05-02 9:27 ` [PATCH 7/9] pinctrl: Add spaces for better code readability SF Markus Elfring
` (2 subsequent siblings)
8 siblings, 2 replies; 21+ messages in thread
From: SF Markus Elfring @ 2017-05-02 9:26 UTC (permalink / raw)
To: linux-gpio, Linus Walleij; +Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 2 May 2017 10:22:47 +0200
The script "checkpatch.pl" pointed information out like the following.
WARNING: quoted string split across lines
Thus fix the affected source code place.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/pinctrl/pinconf.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/pinctrl/pinconf.c b/drivers/pinctrl/pinconf.c
index f2168b6e3418..037ac3e47891 100644
--- a/drivers/pinctrl/pinconf.c
+++ b/drivers/pinctrl/pinconf.c
@@ -87,9 +87,8 @@ int pin_config_group_get(const char *dev_name, const char *pin_group,
ops = pctldev->desc->confops;
if (!ops || !ops->pin_config_group_get) {
- dev_dbg(pctldev->dev, "cannot get configuration for pin "
- "group, missing group config get function in "
- "driver\n");
+ dev_dbg(pctldev->dev,
+ "cannot get configuration for pin group, missing group config get function in driver\n");
ret = -ENOTSUPP;
goto unlock;
}
--
2.12.2
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [PATCH 6/9] pinctrl: Combine substrings for a message in pin_config_group_get()
2017-05-02 9:26 ` [PATCH 6/9] pinctrl: Combine substrings for a message in pin_config_group_get() SF Markus Elfring
@ 2017-05-03 17:49 ` Andy Shevchenko
2017-05-11 13:26 ` Linus Walleij
1 sibling, 0 replies; 21+ messages in thread
From: Andy Shevchenko @ 2017-05-03 17:49 UTC (permalink / raw)
To: SF Markus Elfring; +Cc: linux-gpio, Linus Walleij, LKML, kernel-janitors
On Tue, May 2, 2017 at 12:26 PM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 2 May 2017 10:22:47 +0200
>
> The script "checkpatch.pl" pointed information out like the following.
>
> WARNING: quoted string split across lines
>
> Thus fix the affected source code place.
>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/pinctrl/pinconf.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pinctrl/pinconf.c b/drivers/pinctrl/pinconf.c
> index f2168b6e3418..037ac3e47891 100644
> --- a/drivers/pinctrl/pinconf.c
> +++ b/drivers/pinctrl/pinconf.c
> @@ -87,9 +87,8 @@ int pin_config_group_get(const char *dev_name, const char *pin_group,
> ops = pctldev->desc->confops;
>
> if (!ops || !ops->pin_config_group_get) {
> - dev_dbg(pctldev->dev, "cannot get configuration for pin "
> - "group, missing group config get function in "
> - "driver\n");
> + dev_dbg(pctldev->dev,
> + "cannot get configuration for pin group, missing group config get function in driver\n");
> ret = -ENOTSUPP;
> goto unlock;
> }
> --
> 2.12.2
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: [PATCH 6/9] pinctrl: Combine substrings for a message in pin_config_group_get()
2017-05-02 9:26 ` [PATCH 6/9] pinctrl: Combine substrings for a message in pin_config_group_get() SF Markus Elfring
2017-05-03 17:49 ` Andy Shevchenko
@ 2017-05-11 13:26 ` Linus Walleij
1 sibling, 0 replies; 21+ messages in thread
From: Linus Walleij @ 2017-05-11 13:26 UTC (permalink / raw)
To: SF Markus Elfring; +Cc: linux-gpio, LKML, kernel-janitors
On Tue, May 2, 2017 at 11:26 AM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 2 May 2017 10:22:47 +0200
>
> The script "checkpatch.pl" pointed information out like the following.
>
> WARNING: quoted string split across lines
>
> Thus fix the affected source code place.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 7/9] pinctrl: Add spaces for better code readability
2017-05-02 9:20 [PATCH 0/9] pinctrl: Fine-tuning for some function implementations SF Markus Elfring
` (5 preceding siblings ...)
2017-05-02 9:26 ` [PATCH 6/9] pinctrl: Combine substrings for a message in pin_config_group_get() SF Markus Elfring
@ 2017-05-02 9:27 ` SF Markus Elfring
2017-05-11 13:27 ` Linus Walleij
2017-05-02 9:28 ` [PATCH 8/9] pinctrl: Use seq_putc() in pinctrl_maps_show() SF Markus Elfring
2017-05-02 9:29 ` [PATCH 9/9] pinctrl: Adjust nine checks for null pointers SF Markus Elfring
8 siblings, 1 reply; 21+ messages in thread
From: SF Markus Elfring @ 2017-05-02 9:27 UTC (permalink / raw)
To: linux-gpio, Linus Walleij; +Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 2 May 2017 10:32:19 +0200
The script "checkpatch.pl" pointed information out like the following.
CHECK: spaces preferred around that '+' (ctx:VxV)
Thus fix the affected source code places.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/pinctrl/pinconf.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/pinctrl/pinconf.c b/drivers/pinctrl/pinconf.c
index 037ac3e47891..14a8644ad6b0 100644
--- a/drivers/pinctrl/pinconf.c
+++ b/drivers/pinctrl/pinconf.c
@@ -395,9 +395,9 @@ static const struct file_operations pinconf_groups_ops = {
struct dbg_cfg {
enum pinctrl_map_type map_type;
- char dev_name[MAX_NAME_LEN+1];
- char state_name[MAX_NAME_LEN+1];
- char pin_name[MAX_NAME_LEN+1];
+ char dev_name[MAX_NAME_LEN + 1];
+ char state_name[MAX_NAME_LEN + 1];
+ char pin_name[MAX_NAME_LEN + 1];
};
/*
@@ -486,7 +486,7 @@ static ssize_t pinconf_dbg_config_write(struct file *file,
const struct pinconf_ops *confops = NULL;
struct dbg_cfg *dbg = &pinconf_dbg_conf;
const struct pinctrl_map_configs *configs;
- char config[MAX_NAME_LEN+1];
+ char config[MAX_NAME_LEN + 1];
char buf[128];
char *b = &buf[0];
int buf_size;
--
2.12.2
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [PATCH 7/9] pinctrl: Add spaces for better code readability
2017-05-02 9:27 ` [PATCH 7/9] pinctrl: Add spaces for better code readability SF Markus Elfring
@ 2017-05-11 13:27 ` Linus Walleij
0 siblings, 0 replies; 21+ messages in thread
From: Linus Walleij @ 2017-05-11 13:27 UTC (permalink / raw)
To: SF Markus Elfring; +Cc: linux-gpio, LKML, kernel-janitors
On Tue, May 2, 2017 at 11:27 AM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 2 May 2017 10:32:19 +0200
>
> The script "checkpatch.pl" pointed information out like the following.
>
> CHECK: spaces preferred around that '+' (ctx:VxV)
>
> Thus fix the affected source code places.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 8/9] pinctrl: Use seq_putc() in pinctrl_maps_show()
2017-05-02 9:20 [PATCH 0/9] pinctrl: Fine-tuning for some function implementations SF Markus Elfring
` (6 preceding siblings ...)
2017-05-02 9:27 ` [PATCH 7/9] pinctrl: Add spaces for better code readability SF Markus Elfring
@ 2017-05-02 9:28 ` SF Markus Elfring
2017-05-03 17:45 ` Andy Shevchenko
2017-05-11 13:28 ` Linus Walleij
2017-05-02 9:29 ` [PATCH 9/9] pinctrl: Adjust nine checks for null pointers SF Markus Elfring
8 siblings, 2 replies; 21+ messages in thread
From: SF Markus Elfring @ 2017-05-02 9:28 UTC (permalink / raw)
To: linux-gpio, Linus Walleij; +Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 2 May 2017 10:47:35 +0200
A single character (line break) should be put into a sequence.
Thus use the corresponding function "seq_putc".
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/pinctrl/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c
index 1653cbda6a82..7df16771fa13 100644
--- a/drivers/pinctrl/core.c
+++ b/drivers/pinctrl/core.c
@@ -1732,7 +1732,7 @@ static int pinctrl_maps_show(struct seq_file *s, void *what)
break;
}
- seq_printf(s, "\n");
+ seq_putc(s, '\n');
}
mutex_unlock(&pinctrl_maps_mutex);
--
2.12.2
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [PATCH 8/9] pinctrl: Use seq_putc() in pinctrl_maps_show()
2017-05-02 9:28 ` [PATCH 8/9] pinctrl: Use seq_putc() in pinctrl_maps_show() SF Markus Elfring
@ 2017-05-03 17:45 ` Andy Shevchenko
2017-05-11 13:28 ` Linus Walleij
1 sibling, 0 replies; 21+ messages in thread
From: Andy Shevchenko @ 2017-05-03 17:45 UTC (permalink / raw)
To: SF Markus Elfring; +Cc: linux-gpio, Linus Walleij, LKML, kernel-janitors
On Tue, May 2, 2017 at 12:28 PM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 2 May 2017 10:47:35 +0200
>
> A single character (line break) should be put into a sequence.
> Thus use the corresponding function "seq_putc".
This could be folded to another one with similar changes.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 8/9] pinctrl: Use seq_putc() in pinctrl_maps_show()
2017-05-02 9:28 ` [PATCH 8/9] pinctrl: Use seq_putc() in pinctrl_maps_show() SF Markus Elfring
2017-05-03 17:45 ` Andy Shevchenko
@ 2017-05-11 13:28 ` Linus Walleij
1 sibling, 0 replies; 21+ messages in thread
From: Linus Walleij @ 2017-05-11 13:28 UTC (permalink / raw)
To: SF Markus Elfring; +Cc: linux-gpio, LKML, kernel-janitors
On Tue, May 2, 2017 at 11:28 AM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 2 May 2017 10:47:35 +0200
>
> A single character (line break) should be put into a sequence.
> Thus use the corresponding function "seq_putc".
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Patch applied.
Maybe I will coalesce it with other commits as Andy suggests.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 9/9] pinctrl: Adjust nine checks for null pointers
2017-05-02 9:20 [PATCH 0/9] pinctrl: Fine-tuning for some function implementations SF Markus Elfring
` (7 preceding siblings ...)
2017-05-02 9:28 ` [PATCH 8/9] pinctrl: Use seq_putc() in pinctrl_maps_show() SF Markus Elfring
@ 2017-05-02 9:29 ` SF Markus Elfring
2017-05-11 13:29 ` Linus Walleij
8 siblings, 1 reply; 21+ messages in thread
From: SF Markus Elfring @ 2017-05-02 9:29 UTC (permalink / raw)
To: linux-gpio, Linus Walleij; +Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 2 May 2017 11:04:55 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script “checkpatch.pl” pointed information out like the following.
Comparison to NULL could be written …
Thus fix the affected source code places.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/pinctrl/core.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c
index 7df16771fa13..b1044f07e0a1 100644
--- a/drivers/pinctrl/core.c
+++ b/drivers/pinctrl/core.c
@@ -170,7 +170,7 @@ const char *pin_get_name(struct pinctrl_dev *pctldev, const unsigned pin)
const struct pin_desc *desc;
desc = pin_desc_get(pctldev, pin);
- if (desc == NULL) {
+ if (!desc) {
dev_err(pctldev->dev, "failed to get pin(%d) name\n",
pin);
return NULL;
@@ -214,7 +214,7 @@ static void pinctrl_free_pindescs(struct pinctrl_dev *pctldev,
pindesc = radix_tree_lookup(&pctldev->pin_desc_tree,
pins[i].number);
- if (pindesc != NULL) {
+ if (pindesc) {
radix_tree_delete(&pctldev->pin_desc_tree,
pins[i].number);
if (pindesc->dynamic_name)
@@ -230,7 +230,7 @@ static int pinctrl_register_one_pin(struct pinctrl_dev *pctldev,
struct pin_desc *pindesc;
pindesc = pin_desc_get(pctldev, pin->number);
- if (pindesc != NULL) {
+ if (pindesc) {
dev_err(pctldev->dev, "pin %d already registered\n",
pin->number);
return -EINVAL;
@@ -248,7 +248,7 @@ static int pinctrl_register_one_pin(struct pinctrl_dev *pctldev,
pindesc->name = pin->name;
} else {
pindesc->name = kasprintf(GFP_KERNEL, "PIN%u", pin->number);
- if (pindesc->name == NULL) {
+ if (!pindesc->name) {
kfree(pindesc);
return -ENOMEM;
}
@@ -402,7 +402,7 @@ static int pinctrl_get_device_gpio_range(unsigned gpio,
struct pinctrl_gpio_range *range;
range = pinctrl_match_gpio_range(pctldev, gpio);
- if (range != NULL) {
+ if (range) {
*outdev = pctldev;
*outrange = range;
mutex_unlock(&pinctrldev_list_mutex);
@@ -947,7 +947,7 @@ static int add_setting(struct pinctrl *p, struct pinctrl_dev *pctldev,
else
setting->pctldev =
get_pinctrl_dev_from_devname(map->ctrl_dev_name);
- if (setting->pctldev == NULL) {
+ if (!setting->pctldev) {
kfree(setting);
/* Do not defer probing of hogs (circular loop) */
if (!strcmp(map->ctrl_dev_name, map->dev_name))
@@ -1094,7 +1094,7 @@ struct pinctrl *pinctrl_get(struct device *dev)
* return another pointer to it.
*/
p = find_pinctrl(dev);
- if (p != NULL) {
+ if (p) {
dev_dbg(dev, "obtain a copy of previously claimed pinctrl\n");
kref_get(&p->users);
return p;
@@ -1565,7 +1565,7 @@ static int pinctrl_pins_show(struct seq_file *s, void *what)
pin = pctldev->desc->pins[i].number;
desc = pin_desc_get(pctldev, pin);
/* Pin space may be sparse */
- if (desc == NULL)
+ if (!desc)
continue;
seq_printf(s, "pin %d (%s) ", pin, desc->name);
@@ -2145,7 +2145,7 @@ void pinctrl_unregister(struct pinctrl_dev *pctldev)
{
struct pinctrl_gpio_range *range, *n;
- if (pctldev == NULL)
+ if (!pctldev)
return;
mutex_lock(&pctldev->mutex);
--
2.12.2
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [PATCH 9/9] pinctrl: Adjust nine checks for null pointers
2017-05-02 9:29 ` [PATCH 9/9] pinctrl: Adjust nine checks for null pointers SF Markus Elfring
@ 2017-05-11 13:29 ` Linus Walleij
0 siblings, 0 replies; 21+ messages in thread
From: Linus Walleij @ 2017-05-11 13:29 UTC (permalink / raw)
To: SF Markus Elfring; +Cc: linux-gpio, LKML, kernel-janitors
On Tue, May 2, 2017 at 11:29 AM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 2 May 2017 11:04:55 +0200
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> The script “checkpatch.pl” pointed information out like the following.
>
> Comparison to NULL could be written …
>
> Thus fix the affected source code places.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 21+ messages in thread