From: Linus Walleij <linus.walleij@linaro.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Lee Jones <lee.jones@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH] mfd: qcom_rpm: fix offset error for msm8660
Date: Tue, 14 Jun 2016 21:38:01 +0200 [thread overview]
Message-ID: <CACRpkdZEMJoRKa3SSGOhkvZFjq8Y=v_vv8M7mfEkL1PRRB46-A@mail.gmail.com> (raw)
In-Reply-To: <20160614185108.GF28218@codeaurora.org>
On Tue, Jun 14, 2016 at 8:51 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> On 06/14, Linus Walleij wrote:
>> -#define RPM_REQUEST_CONTEXT 3
>> -#define RPM_REQ_SELECT 11
>> -#define RPM_ACK_CONTEXT 15
>> -#define RPM_ACK_SELECTOR 23
>> #define RPM_SELECT_SIZE 7
>
> The RPM_SELECT_SIZE is 7 on 8660, but now you've pointed out that
> otherwise the size is 4. I think you've uncovered another bug.
OMG you're right. I'll send a v2 fixing that too.
>> - RPM_CTRL_REG(rpm, RPM_REQ_SELECT + i));
>> + RPM_CTRL_REG(rpm, rpm->data->req_sel_off + i));
>
> Here we write from 0 to ARRAY_SIZE(sel_mask) which is 7. That
> would mean we write into the ack context that starts at 15 (we
> start writing at req_sel_off which is always 11). Oops.
Argh well it seems it didn't hurt so far but let's have it fixed.
Yours,
Linus Walleij
next prev parent reply other threads:[~2016-06-14 19:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 9:48 [PATCH] mfd: qcom_rpm: fix offset error for msm8660 Linus Walleij
2016-06-14 18:51 ` Stephen Boyd
2016-06-14 19:38 ` Linus Walleij [this message]
2016-06-14 19:38 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdZEMJoRKa3SSGOhkvZFjq8Y=v_vv8M7mfEkL1PRRB46-A@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@codeaurora.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).