* [PATCH 4/4] drivers/pinctrl/qcom/pinctrl-msm.c: drop negativity check on unsigned value
@ 2014-07-17 16:29 Andrey Utkin
2014-07-23 13:25 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Andrey Utkin @ 2014-07-17 16:29 UTC (permalink / raw)
To: kernel-janitors, linux-kernel
Cc: sboyd, bjorn.andersson, linus.walleij, Andrey Utkin
[linux-3.16-rc5/drivers/pinctrl/pinctrl-msm.c:145]: (style) Checking if
unsigned variable 'mux_bit' is less than zero.
if (WARN_ON(g->mux_bit < 0))
return -EINVAL;
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80491
Reported-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Andrey Utkin <andrey.krieger.utkin@gmail.com>
---
drivers/pinctrl/qcom/pinctrl-msm.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c
index 90d383d..2738108 100644
--- a/drivers/pinctrl/qcom/pinctrl-msm.c
+++ b/drivers/pinctrl/qcom/pinctrl-msm.c
@@ -142,9 +142,6 @@ static int msm_pinmux_enable(struct pinctrl_dev *pctldev,
g = &pctrl->soc->groups[group];
- if (WARN_ON(g->mux_bit < 0))
- return -EINVAL;
-
for (i = 0; i < g->nfuncs; i++) {
if (g->funcs[i] == function)
break;
--
1.8.5.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 4/4] drivers/pinctrl/qcom/pinctrl-msm.c: drop negativity check on unsigned value
2014-07-17 16:29 [PATCH 4/4] drivers/pinctrl/qcom/pinctrl-msm.c: drop negativity check on unsigned value Andrey Utkin
@ 2014-07-23 13:25 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2014-07-23 13:25 UTC (permalink / raw)
To: Andrey Utkin; +Cc: kernel-janitors, linux-kernel, Stephen Boyd, Bjorn Andersson
On Thu, Jul 17, 2014 at 6:29 PM, Andrey Utkin
<andrey.krieger.utkin@gmail.com> wrote:
> [linux-3.16-rc5/drivers/pinctrl/pinctrl-msm.c:145]: (style) Checking if
> unsigned variable 'mux_bit' is less than zero.
>
> if (WARN_ON(g->mux_bit < 0))
> return -EINVAL;
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80491
> Reported-by: David Binderman <dcb314@hotmail.com>
> Signed-off-by: Andrey Utkin <andrey.krieger.utkin@gmail.com>
Patch applied after fixing $SUBJECT, Björn protest if you don't like
it...
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-23 13:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-17 16:29 [PATCH 4/4] drivers/pinctrl/qcom/pinctrl-msm.c: drop negativity check on unsigned value Andrey Utkin
2014-07-23 13:25 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).