* [PATCH] bus: ixp4xx: return on error in ixp4xx_exp_probe()
@ 2021-08-06 15:00 Dan Carpenter
2021-08-07 22:49 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2021-08-06 15:00 UTC (permalink / raw)
To: Linus Walleij; +Cc: Imre Kaloz, Krzysztof Halasa, linux-kernel, kernel-janitors
This code was intended to return an error code if regmap_read() fails
but the return statement was missing.
Fixes: 1c953bda90ca ("bus: ixp4xx: Add a driver for IXP4xx expansion bus")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/bus/intel-ixp4xx-eb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bus/intel-ixp4xx-eb.c b/drivers/bus/intel-ixp4xx-eb.c
index 9acd00da413c..a4388440aca7 100644
--- a/drivers/bus/intel-ixp4xx-eb.c
+++ b/drivers/bus/intel-ixp4xx-eb.c
@@ -369,7 +369,7 @@ static int ixp4xx_exp_probe(struct platform_device *pdev)
/* We check that the regmap work only on first read */
ret = regmap_read(eb->rmap, IXP4XX_EXP_CNFG0, &val);
if (ret)
- dev_err_probe(dev, ret, "cannot read regmap\n");
+ return dev_err_probe(dev, ret, "cannot read regmap\n");
if (val & IXP4XX_EXP_CNFG0_MEM_MAP)
eb->bus_base = IXP4XX_EXP_BOOT_BASE;
else
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] bus: ixp4xx: return on error in ixp4xx_exp_probe()
2021-08-06 15:00 [PATCH] bus: ixp4xx: return on error in ixp4xx_exp_probe() Dan Carpenter
@ 2021-08-07 22:49 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2021-08-07 22:49 UTC (permalink / raw)
To: Dan Carpenter
Cc: Linus Walleij, Imre Kaloz, Krzysztof Halasa, linux-kernel,
kernel-janitors
On Fri, Aug 6, 2021 at 5:00 PM Dan Carpenter <dan.carpenter@oracle.com> wrote:
> This code was intended to return an error code if regmap_read() fails
> but the return statement was missing.
>
> Fixes: 1c953bda90ca ("bus: ixp4xx: Add a driver for IXP4xx expansion bus")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Ooops that's a bug.
Patch applied, I will relay this to the ARM SoC tree.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-07 22:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-06 15:00 [PATCH] bus: ixp4xx: return on error in ixp4xx_exp_probe() Dan Carpenter
2021-08-07 22:49 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).