[PATCH 0/2] gpio: sysfs: fix memory leaks

[PATCH 0/2] gpio: sysfs: fix memory leaks

[Johan Hovold]

Here are two more fixes for long-standing memory leaks in the gpio sysfs
interface (for v3.19).

Johan


Johan Hovold (2):
  gpio: sysfs: fix memory leak in gpiod_export_link
  gpio: sysfs: fix memory leak in gpiod_sysfs_set_active_low

 drivers/gpio/gpiolib-sysfs.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.0.5

[PATCH 1/2] gpio: sysfs: fix memory leak in gpiod_export_link

[Johan Hovold]

Fix memory leak in the gpio sysfs interface due to failure to drop
reference to device returned by class_find_device when creating a link.

Fixes: a4177ee7f1a8 ("gpiolib: allow exported GPIO nodes to be named
using sysfs links")
Cc: stable <stable@vger.kernel.org>	# v2.6.32
Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/gpio/gpiolib-sysfs.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/gpiolib-sysfs.c b/drivers/gpio/gpiolib-sysfs.c
index 14c4f94813eb..820b1e70ddfe 100644
--- a/drivers/gpio/gpiolib-sysfs.c
+++ b/drivers/gpio/gpiolib-sysfs.c
@@ -648,6 +648,7 @@ int gpiod_export_link(struct device *dev, const char *name,
 		if (tdev != NULL) {
 			status = sysfs_create_link(&dev->kobj, &tdev->kobj,
 						name);
+			put_device(tdev);
 		} else {
 			status = -ENODEV;
 		}
-- 
2.0.5

[PATCH 2/2] gpio: sysfs: fix memory leak in gpiod_sysfs_set_active_low

[Johan Hovold]

Fix memory leak in the gpio sysfs interface due to failure to drop
reference to device returned by class_find_device when setting the
gpio-line polarity.

Fixes: 0769746183ca ("gpiolib: add support for changing value polarity
in sysfs")
Cc: stable <stable@vger.kernel.org>	# v2.6.33
Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/gpio/gpiolib-sysfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpiolib-sysfs.c b/drivers/gpio/gpiolib-sysfs.c
index 820b1e70ddfe..4908d09873e5 100644
--- a/drivers/gpio/gpiolib-sysfs.c
+++ b/drivers/gpio/gpiolib-sysfs.c
@@ -696,7 +696,7 @@ int gpiod_sysfs_set_active_low(struct gpio_desc *desc, int value)
 	}
 
 	status = sysfs_set_active_low(desc, dev, value);
-
+	put_device(dev);
 unlock:
 	mutex_unlock(&sysfs_lock);
 
-- 
2.0.5

Re: [PATCH 1/2] gpio: sysfs: fix memory leak in gpiod_export_link

[Linus Walleij]

On Mon, Jan 26, 2015 at 12:02 PM, Johan Hovold <johan@kernel.org> wrote:

> Fix memory leak in the gpio sysfs interface due to failure to drop
> reference to device returned by class_find_device when creating a link.
>
> Fixes: a4177ee7f1a8 ("gpiolib: allow exported GPIO nodes to be named
> using sysfs links")
> Cc: stable <stable@vger.kernel.org>     # v2.6.32
> Signed-off-by: Johan Hovold <johan@kernel.org>

Patch applied.

Let's see if I get it into v3.19 properly...

Yours,
Linus Walleij

Re: [PATCH 2/2] gpio: sysfs: fix memory leak in gpiod_sysfs_set_active_low

[Linus Walleij]

On Mon, Jan 26, 2015 at 12:02 PM, Johan Hovold <johan@kernel.org> wrote:

> Fix memory leak in the gpio sysfs interface due to failure to drop
> reference to device returned by class_find_device when setting the
> gpio-line polarity.
>
> Fixes: 0769746183ca ("gpiolib: add support for changing value polarity
> in sysfs")
> Cc: stable <stable@vger.kernel.org>     # v2.6.33
> Signed-off-by: Johan Hovold <johan@kernel.org>

Patch applied.

Yours,
Linus Walleij