From: Linus Walleij <linus.walleij@linaro.org>
To: "Antoine Ténart" <antoine.tenart@free-electrons.com>
Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
zmxu@marvell.com, Jisheng Zhang <jszhang@marvell.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RESEND 1/5] pinctrl: allows not to define the get_group_pins operation
Date: Tue, 22 Apr 2014 14:48:04 +0200 [thread overview]
Message-ID: <CACRpkdZrLZZwpVCzo_Ms2=7SqUoryt-6OtF7ePhGp4kwJgDgXQ@mail.gmail.com> (raw)
In-Reply-To: <1397135274-10764-2-git-send-email-antoine.tenart@free-electrons.com>
On Thu, Apr 10, 2014 at 3:07 PM, Antoine Ténart
<antoine.tenart@free-electrons.com> wrote:
> When using a group only pinctrl driver, which does not have any
> information on the pins it is useless to define a get_group_pins
> always returning an empty list of pins.
>
> When not using get_group_pin[1], a driver must implement it so
> pins = NULL and num_pins = 0. This patch makes it the default
> behaviour if not defined in the pinctrl driver when used in
> pinmux enable and disable funtions and in pinctrl_groups_show.
>
> It also adds a check in pinctrl_get_group_pins and return -EINVAL if
> not defined. This function is called in the gpiolib when adding when
> pingroup range. It cannot be used if no group is defined, so this seams
> reasonable.
>
> [1] get_group_pin(struct pinctrl_dev *pctldev,
> unsigned selector,
> const unsigned **pins,
> unsigned *num_pins);
>
> Signed-off-by: Antoine Ténart <antoine.tenart@free-electrons.com>
OK makes perfect sense.
Patch applied.
Can you please check the Documentation/pinctrl.txt to see
if anything needs to be updated due to this?
Yours,
Linus Walleij
next prev parent reply other threads:[~2014-04-22 12:48 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-10 13:07 [PATCH RESEND 0/5] ARM: berlin: add pinctrl support Antoine Ténart
2014-04-10 13:07 ` [PATCH RESEND 1/5] pinctrl: allows not to define the get_group_pins operation Antoine Ténart
2014-04-11 9:21 ` Sebastian Hesselbarth
2014-04-22 12:48 ` Linus Walleij [this message]
2014-04-22 15:58 ` Antoine Ténart
2014-04-10 13:07 ` [PATCH RESEND 2/5] pinctrl: berlin: add a pinctrl driver for Marvell Berlin SoCs Antoine Ténart
2014-04-11 6:44 ` Jisheng Zhang
2014-04-11 8:18 ` Antoine Ténart
2014-04-11 8:27 ` Jisheng Zhang
2014-04-11 9:21 ` Antoine Ténart
2014-04-11 9:03 ` Sebastian Hesselbarth
2014-04-11 12:37 ` Antoine Ténart
2014-04-11 13:35 ` Sebastian Hesselbarth
2014-04-22 12:52 ` Linus Walleij
2014-04-22 15:56 ` Antoine Ténart
2014-04-23 14:05 ` Linus Walleij
2014-04-10 13:07 ` [PATCH RESEND 3/5] ARM: berlin: add the pinctrl dependency for the " Antoine Ténart
2014-04-11 9:05 ` Sebastian Hesselbarth
2014-04-17 13:13 ` Antoine Ténart
2014-04-17 13:24 ` Sebastian Hesselbarth
2014-04-10 13:07 ` [PATCH RESEND 4/5] Documentation: add the Marvell Berlin pinctrl documentation Antoine Ténart
2014-04-11 6:33 ` Jisheng Zhang
2014-04-11 8:12 ` Antoine Ténart
2014-04-11 8:18 ` Jisheng Zhang
2014-04-11 8:22 ` Andrew Lunn
2014-04-11 9:13 ` Sebastian Hesselbarth
2014-04-10 13:07 ` [PATCH RESEND 5/5] ARM: dts: berlin: add the pinctrl node and muxing setup for uarts Antoine Ténart
2014-04-11 8:18 ` Andrew Lunn
2014-04-11 9:09 ` Antoine Ténart
2014-04-11 9:19 ` Sebastian Hesselbarth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdZrLZZwpVCzo_Ms2=7SqUoryt-6OtF7ePhGp4kwJgDgXQ@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=alexandre.belloni@free-electrons.com \
--cc=antoine.tenart@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=jszhang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=zmxu@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).