From: Linus Walleij <linus.walleij@linaro.org>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Neil Armstrong <narmstrong@baylibre.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Chris Healy <cphealy@gmail.com>
Subject: Re: [PATCH v2 13/15] pinctrl-sx150x: Use handle_bad_irq instead of handle_edge_irq
Date: Tue, 8 Nov 2016 09:47:23 +0100 [thread overview]
Message-ID: <CACRpkdZw-g+OJcnvTpdzaUMAyCvrjNMQu6d31f-6MZHS2OL_2w@mail.gmail.com> (raw)
In-Reply-To: <1478537603-23653-14-git-send-email-andrew.smirnov@gmail.com>
On Mon, Nov 7, 2016 at 5:53 PM, Andrey Smirnov <andrew.smirnov@gmail.com> wrote:
> Althought the function passed as a "handler" during GPIO chip
> instantiation is not going to ever be called, specifying handle_edge_irq
> there makes for a rather confusing read, both because no "ack" callback
> in specified for irqchip and because there's no acking action is
> necessary.
>
> Specify handle_bad_irq instead a make a note of the situation. This
> commit should be a no-op behaviour wise.
>
> Tested-by: Neil Armstrong <narmstrong@baylibre.com>
> Acked-by: Neil Armstrong <narmstrong@baylibre.com>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Patch applied!
Yours,
Linus Walleij
next prev parent reply other threads:[~2016-11-08 8:47 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-07 16:53 [PATCH v2 00/15] pinctrl-sx150x: Various bug-fixes and code simplifications Andrey Smirnov
2016-11-07 16:53 ` [PATCH v2 01/15] pinctrl-sx150x: Improve OF device matching code Andrey Smirnov
2016-11-08 8:34 ` Linus Walleij
2016-11-07 16:53 ` [PATCH v2 02/15] pinctrl-sx150x: Add SX1503 specific data Andrey Smirnov
2016-11-08 8:35 ` Linus Walleij
2016-11-07 16:53 ` [PATCH v2 03/15] bindings: pinctrl-sx150x: Document SX1503 compatibility string Andrey Smirnov
2016-11-08 8:35 ` Linus Walleij
2016-11-07 16:53 ` [PATCH v2 04/15] pinctrl-sx150x: Replace magic number in sx150x_init_hw Andrey Smirnov
2016-11-08 8:36 ` Linus Walleij
2016-11-07 16:53 ` [PATCH v2 05/15] pinctrl-sx150x: Fix incorrect constant " Andrey Smirnov
2016-11-08 8:37 ` Linus Walleij
2016-11-07 16:53 ` [PATCH v2 06/15] pinctrl-sx150x: Move some code out of sx150x_init_hw Andrey Smirnov
2016-11-08 8:38 ` Linus Walleij
2016-11-07 16:53 ` [PATCH v2 07/15] pinctrl-sx150x: Improve sx150x_init_misc for SX1504/5/6 Andrey Smirnov
2016-11-08 8:38 ` Linus Walleij
2016-11-07 16:53 ` [PATCH v2 08/15] pinctrl-sx150x: Convert driver to use regmap API Andrey Smirnov
2016-11-08 8:39 ` Linus Walleij
2016-11-07 16:53 ` [PATCH v2 09/15] pinctrl-sx150x: Replace sx150x_*_cfg by means of " Andrey Smirnov
2016-11-08 8:43 ` Linus Walleij
2016-11-07 16:53 ` [PATCH v2 10/15] pinctrl-sx150x: Remove excessive locking Andrey Smirnov
2016-11-08 8:44 ` Linus Walleij
2016-11-07 16:53 ` [PATCH v2 11/15] pinctrl-sx150x: Improve oscio GPIO functions Andrey Smirnov
2016-11-08 8:45 ` Linus Walleij
2016-11-07 16:53 ` [PATCH v2 12/15] pinctrl-sx150x: Simplify interrupt handler Andrey Smirnov
2016-11-08 8:46 ` Linus Walleij
2016-11-07 16:53 ` [PATCH v2 13/15] pinctrl-sx150x: Use handle_bad_irq instead of handle_edge_irq Andrey Smirnov
2016-11-08 8:47 ` Linus Walleij [this message]
2016-11-07 16:53 ` [PATCH v2 14/15] pinctrl-sx150x: Remove magic numbers from sx150x_irq_set_type Andrey Smirnov
2016-11-08 8:48 ` Linus Walleij
2016-11-07 16:53 ` [PATCH v2 15/15] pinctrl-sx150x: Remove magic numbers from sx150x_reset Andrey Smirnov
2016-11-08 8:49 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdZw-g+OJcnvTpdzaUMAyCvrjNMQu6d31f-6MZHS2OL_2w@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=andrew.smirnov@gmail.com \
--cc=cphealy@gmail.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).