* [PATCH] gpio: sprd: Remove unused irq trigger setting
@ 2019-01-21 5:05 Baolin Wang
2019-01-21 12:47 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Baolin Wang @ 2019-01-21 5:05 UTC (permalink / raw)
To: linus.walleij, bgolaszewski
Cc: orsonzhai, zhang.lyra, baolin.wang, neo.hou, broonie, linux-gpio,
linux-kernel
The Spreadtrum PMIC interrupt controller has no registers to set irq
trigger type, since it is always high level trigger. That means the
PMIC EIC controller as a child device of PMIC INTC does not need to
set the trigger type, so remove it.
Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
---
drivers/gpio/gpio-pmic-eic-sprd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpio/gpio-pmic-eic-sprd.c b/drivers/gpio/gpio-pmic-eic-sprd.c
index 29e044f..ac573da 100644
--- a/drivers/gpio/gpio-pmic-eic-sprd.c
+++ b/drivers/gpio/gpio-pmic-eic-sprd.c
@@ -322,7 +322,6 @@ static int sprd_pmic_eic_probe(struct platform_device *pdev)
ret = devm_request_threaded_irq(&pdev->dev, pmic_eic->irq, NULL,
sprd_pmic_eic_irq_handler,
- IRQF_TRIGGER_LOW |
IRQF_ONESHOT | IRQF_NO_SUSPEND,
dev_name(&pdev->dev), pmic_eic);
if (ret) {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio: sprd: Remove unused irq trigger setting
2019-01-21 5:05 [PATCH] gpio: sprd: Remove unused irq trigger setting Baolin Wang
@ 2019-01-21 12:47 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2019-01-21 12:47 UTC (permalink / raw)
To: Baolin Wang
Cc: Bartosz Golaszewski, Orson Zhai, Lyra Zhang, neo.hou, Mark Brown,
open list:GPIO SUBSYSTEM, linux-kernel
On Mon, Jan 21, 2019 at 6:06 AM Baolin Wang <baolin.wang@linaro.org> wrote:
> The Spreadtrum PMIC interrupt controller has no registers to set irq
> trigger type, since it is always high level trigger. That means the
> PMIC EIC controller as a child device of PMIC INTC does not need to
> set the trigger type, so remove it.
>
> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-21 12:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-21 5:05 [PATCH] gpio: sprd: Remove unused irq trigger setting Baolin Wang
2019-01-21 12:47 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).