Run-time dependencies for STE Modem remoteproc driver

Run-time dependencies for STE Modem remoteproc driver

[Jean Delvare]

Hi all,

While other remoteproc drivers have proper platform dependencies set
(OMAP_REMOTEPROC depends on ARCH_OMAP4 || SOC_OMAP5, DA8XX_REMOTEPROC
depends on ARCH_DAVINCI_DA8XX), STE_MODEM_RPROC has no such
dependencies. So the driver is presented on all architectures and can
be enabled even on platforms where it makes no sense.

Could we please add run-time dependencies so that the driver can only
be selected where it makes sense? We can always add || COMPILE_TEST to
allow build-testing everywhere.

This brings the question: on which architectures / platforms is the STE
Modem remoteproc driver needed?

Thanks,
-- 
Jean Delvare
SUSE L3 Support

Re: Run-time dependencies for STE Modem remoteproc driver

[Linus Walleij]

On Mon, Jul 21, 2014 at 6:15 PM, Jean Delvare <jdelvare@suse.de> wrote:

> This brings the question: on which architectures / platforms is the STE
> Modem remoteproc driver needed?

NONE.

Yours,
Linus Walleij

Re: Run-time dependencies for STE Modem remoteproc driver

[Jean Delvare]

Hi Linus,

On Wed, 23 Jul 2014 17:21:17 +0200, Linus Walleij wrote:
> On Mon, Jul 21, 2014 at 6:15 PM, Jean Delvare <jdelvare@suse.de> wrote:
> 
> > This brings the question: on which architectures / platforms is the STE
> > Modem remoteproc driver needed?
> 
> NONE.

Hm, OK :D So I will disable this driver in all our kernels. Maybe this
should be mentioned in the Kconfig help text?

Still, I suppose that the driver had an intended target, maybe we can
use that as a run-time dependency? Or should we just make the driver
depend on COMPILE_TEST?

Thanks,
-- 
Jean Delvare
SUSE L3 Support

Re: Run-time dependencies for STE Modem remoteproc driver

[Linus Walleij]

On Thu, Jul 24, 2014 at 11:52 AM, Jean Delvare <jdelvare@suse.de> wrote:
> Hi Linus,
>
> On Wed, 23 Jul 2014 17:21:17 +0200, Linus Walleij wrote:
>> On Mon, Jul 21, 2014 at 6:15 PM, Jean Delvare <jdelvare@suse.de> wrote:
>>
>> > This brings the question: on which architectures / platforms is the STE
>> > Modem remoteproc driver needed?
>>
>> NONE.
>
> Hm, OK :D So I will disable this driver in all our kernels. Maybe this
> should be mentioned in the Kconfig help text?
>
> Still, I suppose that the driver had an intended target, maybe we can
> use that as a run-time dependency? Or should we just make the driver
> depend on COMPILE_TEST?

Yeah that sounds like a pretty good idea actually, as we shouldn't
just delete it.

Yours,
Linus Walleij