[PATCH] gpio/davinci: add interrupt support for GPIOs 16-31

[PATCH] gpio/davinci: add interrupt support for GPIOs 16-31

[Vitaly Andrianov]

Interrupts for GPIOs 16 through 31 are enabled by bit 1 in the
"binten" register (offset 8). Previous versions of GPIO only
used bit 0, which enables GPIO 0-15 interrupts.

Signed-off-by: Reece Pollack <x0183204@ti.com>
Signed-off-by: Vitaly Andrianov <vitalya@ti.com>
---
 drivers/gpio/gpio-davinci.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
index c5e05c8..c90629f 100644
--- a/drivers/gpio/gpio-davinci.c
+++ b/drivers/gpio/gpio-davinci.c
@@ -546,6 +546,8 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev)
 		chips[0].gpio_irq = bank_irq;
 		chips[0].gpio_unbanked = pdata->gpio_unbanked;
 		binten = BIT(0);
+		if (pdata->gpio_unbanked > 16)
+			binten |= BIT(1);
 
 		/* AINTC handles mask/unmask; GPIO handles triggering */
 		irq = bank_irq;
-- 
1.9.1

Re: [PATCH] gpio/davinci: add interrupt support for GPIOs 16-31

[Linus Walleij]

On Thu, Jun 18, 2015 at 7:10 PM, Vitaly Andrianov <vitalya@ti.com> wrote:

> Interrupts for GPIOs 16 through 31 are enabled by bit 1 in the
> "binten" register (offset 8). Previous versions of GPIO only
> used bit 0, which enables GPIO 0-15 interrupts.
>
> Signed-off-by: Reece Pollack <x0183204@ti.com>
> Signed-off-by: Vitaly Andrianov <vitalya@ti.com>

Sekhar/Kevin: OK with this? We don't have a maintainer
listed for davinci GPIO so I assume it's you guys...

Should this be tagged for stable?

Yours,
Linus Walleij

Re: [PATCH] gpio/davinci: add interrupt support for GPIOs 16-31

[Sekhar Nori]

On Tuesday 14 July 2015 07:31 PM, Linus Walleij wrote:
> On Thu, Jun 18, 2015 at 7:10 PM, Vitaly Andrianov <vitalya@ti.com> wrote:
> 
>> Interrupts for GPIOs 16 through 31 are enabled by bit 1 in the
>> "binten" register (offset 8). Previous versions of GPIO only
>> used bit 0, which enables GPIO 0-15 interrupts.
>>
>> Signed-off-by: Reece Pollack <x0183204@ti.com>
>> Signed-off-by: Vitaly Andrianov <vitalya@ti.com>
> 
> Sekhar/Kevin: OK with this? We don't have a maintainer
> listed for davinci GPIO so I assume it's you guys...

Hi Linus, I had reviewed this patch and there was a v2 send based on my
comments on July 03.

> Should this be tagged for stable?

Not sure about that. It affects Keystone devices. Vitaly?

Thanks,
Sekhar

Re: [PATCH] gpio/davinci: add interrupt support for GPIOs 16-31

[Vitaly Andrianov]

On 07/16/2015 05:04 AM, Sekhar Nori wrote:
> On Tuesday 14 July 2015 07:31 PM, Linus Walleij wrote:
>> On Thu, Jun 18, 2015 at 7:10 PM, Vitaly Andrianov <vitalya@ti.com> wrote:
>>
>>> Interrupts for GPIOs 16 through 31 are enabled by bit 1 in the
>>> "binten" register (offset 8). Previous versions of GPIO only
>>> used bit 0, which enables GPIO 0-15 interrupts.
>>>
>>> Signed-off-by: Reece Pollack <x0183204@ti.com>
>>> Signed-off-by: Vitaly Andrianov <vitalya@ti.com>
>>
>> Sekhar/Kevin: OK with this? We don't have a maintainer
>> listed for davinci GPIO so I assume it's you guys...
>
> Hi Linus, I had reviewed this patch and there was a v2 send based on my
> comments on July 03.
>
>> Should this be tagged for stable?
>
> Not sure about that. It affects Keystone devices. Vitaly?
>
> Thanks,
> Sekhar
>
We used this patch for a long time. So, I guess it is stable.
Thanks,
Vitaly

Re: [PATCH] gpio/davinci: add interrupt support for GPIOs 16-31

[Sekhar Nori]

On Thursday 16 July 2015 11:11 PM, Vitaly Andrianov wrote:
> 
> 
> On 07/16/2015 05:04 AM, Sekhar Nori wrote:
>> On Tuesday 14 July 2015 07:31 PM, Linus Walleij wrote:
>>> On Thu, Jun 18, 2015 at 7:10 PM, Vitaly Andrianov <vitalya@ti.com>
>>> wrote:
>>>
>>>> Interrupts for GPIOs 16 through 31 are enabled by bit 1 in the
>>>> "binten" register (offset 8). Previous versions of GPIO only
>>>> used bit 0, which enables GPIO 0-15 interrupts.
>>>>
>>>> Signed-off-by: Reece Pollack <x0183204@ti.com>
>>>> Signed-off-by: Vitaly Andrianov <vitalya@ti.com>
>>>
>>> Sekhar/Kevin: OK with this? We don't have a maintainer
>>> listed for davinci GPIO so I assume it's you guys...
>>
>> Hi Linus, I had reviewed this patch and there was a v2 send based on my
>> comments on July 03.
>>
>>> Should this be tagged for stable?
>>
>> Not sure about that. It affects Keystone devices. Vitaly?
>>
>> Thanks,
>> Sekhar
>>
> We used this patch for a long time. So, I guess it is stable.

You misunderstood. Should this patch be marked for backporting to older
kernels because it fixes a critical issue on devices otherwise working
in that kernel? See Documentation/stable_kernel_rules.txt

Thanks,
Sekhar

Re: [PATCH] gpio/davinci: add interrupt support for GPIOs 16-31

[Vitaly Andrianov]

On 07/17/2015 01:02 AM, Sekhar Nori wrote:
> On Thursday 16 July 2015 11:11 PM, Vitaly Andrianov wrote:
>>
>>
>> On 07/16/2015 05:04 AM, Sekhar Nori wrote:
>>> On Tuesday 14 July 2015 07:31 PM, Linus Walleij wrote:
>>>> On Thu, Jun 18, 2015 at 7:10 PM, Vitaly Andrianov <vitalya@ti.com>
>>>> wrote:
>>>>
>>>>> Interrupts for GPIOs 16 through 31 are enabled by bit 1 in the
>>>>> "binten" register (offset 8). Previous versions of GPIO only
>>>>> used bit 0, which enables GPIO 0-15 interrupts.
>>>>>
>>>>> Signed-off-by: Reece Pollack <x0183204@ti.com>
>>>>> Signed-off-by: Vitaly Andrianov <vitalya@ti.com>
>>>>
>>>> Sekhar/Kevin: OK with this? We don't have a maintainer
>>>> listed for davinci GPIO so I assume it's you guys...
>>>
>>> Hi Linus, I had reviewed this patch and there was a v2 send based on my
>>> comments on July 03.
>>>
>>>> Should this be tagged for stable?
>>>
>>> Not sure about that. It affects Keystone devices. Vitaly?
>>>
>>> Thanks,
>>> Sekhar
>>>
>> We used this patch for a long time. So, I guess it is stable.
>
> You misunderstood. Should this patch be marked for backporting to older
> kernels because it fixes a critical issue on devices otherwise working
> in that kernel? See Documentation/stable_kernel_rules.txt
>
> Thanks,
> Sekhar
>
Sorry. As I understand from the stable_kernel_rules.txt this patch _IS_ 
_NOT_ for "-stable"

Thanks,
Vitaly