From: Linus Walleij <linus.walleij@linaro.org>
To: Alexandre Courbot <acourbot@nvidia.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Rhyland Klein <rklein@nvidia.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpio: better lookup method for platform GPIOs
Date: Thu, 28 Nov 2013 15:45:37 +0100 [thread overview]
Message-ID: <CACRpkda-TtKQr6hDx4corjxYv7r7f6_9sNp_2ocbvg9MHyOk7Q@mail.gmail.com> (raw)
In-Reply-To: <1385628388-23827-1-git-send-email-acourbot@nvidia.com>
On Thu, Nov 28, 2013 at 9:46 AM, Alexandre Courbot <acourbot@nvidia.com> wrote:
> Change the format of the platform GPIO lookup tables to make them less
> confusing and improve lookup efficiency.
>
> The previous format was a single linked-list that required to compare
> the device name and function ID of every single GPIO defined for each
> lookup. Switch that to a list of per-device tables, so that the lookup
> can be done in two steps, omitting the GPIOs that are not relevant for a
> particular device.
>
> The matching rules are now defined as follows:
> - The device name must match *exactly*, and can be NULL for GPIOs not
> assigned to a particular device,
> - If the function ID in the lookup table is NULL, the con_id argument of
> gpiod_get() will not be used for lookup. However, if it is defined, it
> must match exactly.
> - The index must always match.
>
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> ---
> Let's change this bad design before more users start using it. ;)
OK given that Mika has based his patches on this I'll request
that he ACK this and then I'll merge this so that he can put
this patch at the bottom of his patch stack.
Mika: requesting ACK.
Yours,
Linus Walleij
next prev parent reply other threads:[~2013-11-28 14:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-28 8:46 [PATCH] gpio: better lookup method for platform GPIOs Alexandre Courbot
2013-11-28 14:45 ` Linus Walleij [this message]
2013-11-28 15:42 ` Andy Shevchenko
2013-11-28 16:59 ` Mika Westerberg
2013-11-28 15:54 ` Andy Shevchenko
2013-11-29 6:17 ` Andy Shevchenko
2013-12-02 10:50 ` Alex Courbot
2013-11-29 11:57 ` Heikki Krogerus
2013-11-29 11:59 ` Heikki Krogerus
2013-12-02 10:33 ` Alex Courbot
2013-12-02 11:11 ` Heikki Krogerus
2013-12-02 12:30 ` Alexandre Courbot
2013-12-03 3:20 ` [PATCH v3] " Alexandre Courbot
2013-12-03 11:04 ` Heikki Krogerus
2013-12-03 12:12 ` Linus Walleij
2013-12-09 13:07 ` Linus Walleij
2013-12-02 11:01 ` [PATCH v2] " Alexandre Courbot
2013-12-02 11:49 ` Andy Shevchenko
2013-12-02 12:37 ` Alexandre Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkda-TtKQr6hDx4corjxYv7r7f6_9sNp_2ocbvg9MHyOk7Q@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=acourbot@nvidia.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rklein@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).