From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Alexandre Courbot <acourbot@nvidia.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Rhyland Klein <rklein@nvidia.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpio: better lookup method for platform GPIOs
Date: Fri, 29 Nov 2013 08:17:15 +0200 [thread overview]
Message-ID: <CAHp75VcsYjj0_QKSeHFiFjrA92uZWdJPs5pLrzFK_HGM1ehUDw@mail.gmail.com> (raw)
In-Reply-To: <CAHp75VcHa7cxAt_utwMVp7j+YeKcqa0_N5B=7-ZmTMD_6AV1Lw@mail.gmail.com>
> On Thu, Nov 28, 2013 at 10:46 AM, Alexandre Courbot <acourbot@nvidia.com> wrote:
One missed, but not least, thing.
>> +static struct gpiod_lookup_table *gpiod_find_lookup_table(struct device *dev)
>> {
>> const char *dev_id = dev ? dev_name(dev) : NULL;
>> - struct gpio_desc *desc = ERR_PTR(-ENODEV);
>> - unsigned int match, best = 0;
>> - struct gpiod_lookup *p;
>> + struct gpiod_lookup_table *table;
>>
>> mutex_lock(&gpio_lookup_lock);
>>
>> - list_for_each_entry(p, &gpio_lookup_list, list) {
>> - match = 0;
>> + list_for_each_entry(table, &gpio_lookup_list, list) {
[]
>> + if (dev_id != table->dev_id)
>> + continue;
>>
>> - match += 2;
>> - }
>> + return table;
>
> What about
>
> if (dev_id == table->dev_id)
> return table;
>
> ?
And unlock mutex, of course! It seems you missed this in the first place.
>
>> + }
>>
>> - if (p->con_id) {
>> - if (!con_id || strcmp(p->con_id, con_id))
>> - continue;
>> + mutex_unlock(&gpio_lookup_lock);
>>
>> - match += 1;
>> - }
>> + return NULL;
>> +}
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2013-11-29 6:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-28 8:46 [PATCH] gpio: better lookup method for platform GPIOs Alexandre Courbot
2013-11-28 14:45 ` Linus Walleij
2013-11-28 15:42 ` Andy Shevchenko
2013-11-28 16:59 ` Mika Westerberg
2013-11-28 15:54 ` Andy Shevchenko
2013-11-29 6:17 ` Andy Shevchenko [this message]
2013-12-02 10:50 ` Alex Courbot
2013-11-29 11:57 ` Heikki Krogerus
2013-11-29 11:59 ` Heikki Krogerus
2013-12-02 10:33 ` Alex Courbot
2013-12-02 11:11 ` Heikki Krogerus
2013-12-02 12:30 ` Alexandre Courbot
2013-12-03 3:20 ` [PATCH v3] " Alexandre Courbot
2013-12-03 11:04 ` Heikki Krogerus
2013-12-03 12:12 ` Linus Walleij
2013-12-09 13:07 ` Linus Walleij
2013-12-02 11:01 ` [PATCH v2] " Alexandre Courbot
2013-12-02 11:49 ` Andy Shevchenko
2013-12-02 12:37 ` Alexandre Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VcsYjj0_QKSeHFiFjrA92uZWdJPs5pLrzFK_HGM1ehUDw@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=acourbot@nvidia.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rklein@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).