* [PATCH] pinctrl: meson: fix gpio request disabling other modes
@ 2016-12-06 14:08 Neil Armstrong
2016-12-07 0:47 ` Kevin Hilman
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Neil Armstrong @ 2016-12-06 14:08 UTC (permalink / raw)
To: linus.walleij, carlo, khilman
Cc: Neil Armstrong, linux-gpio, linux-amlogic, linux-arm-kernel,
linux-kernel, Beniamino Galvani
The pinctrl_gpio_request is called with the "full" gpio number, already
containing the base, then meson_pmx_request_gpio is then called with the
final pin number.
Remove the base addition when calling meson_pmx_disable_other_groups.
Fixes: 6ac730951104 ("pinctrl: add driver for Amlogic Meson SoCs")
CC: Beniamino Galvani <b.galvani@gmail.com>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
drivers/pinctrl/meson/pinctrl-meson.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/meson/pinctrl-meson.c b/drivers/pinctrl/meson/pinctrl-meson.c
index a579126..620c231a 100644
--- a/drivers/pinctrl/meson/pinctrl-meson.c
+++ b/drivers/pinctrl/meson/pinctrl-meson.c
@@ -212,7 +212,7 @@ static int meson_pmx_request_gpio(struct pinctrl_dev *pcdev,
{
struct meson_pinctrl *pc = pinctrl_dev_get_drvdata(pcdev);
- meson_pmx_disable_other_groups(pc, range->pin_base + offset, -1);
+ meson_pmx_disable_other_groups(pc, offset, -1);
return 0;
}
--
2.7.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] pinctrl: meson: fix gpio request disabling other modes
2016-12-06 14:08 [PATCH] pinctrl: meson: fix gpio request disabling other modes Neil Armstrong
@ 2016-12-07 0:47 ` Kevin Hilman
2016-12-11 21:50 ` Beniamino Galvani
2016-12-28 12:41 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Kevin Hilman @ 2016-12-07 0:47 UTC (permalink / raw)
To: Neil Armstrong
Cc: linus.walleij, carlo, linux-gpio, linux-amlogic,
linux-arm-kernel, linux-kernel, Beniamino Galvani
Neil Armstrong <narmstrong@baylibre.com> writes:
> The pinctrl_gpio_request is called with the "full" gpio number, already
> containing the base, then meson_pmx_request_gpio is then called with the
> final pin number.
> Remove the base addition when calling meson_pmx_disable_other_groups.
>
> Fixes: 6ac730951104 ("pinctrl: add driver for Amlogic Meson SoCs")
> CC: Beniamino Galvani <b.galvani@gmail.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Acked-by: Kevin Hilman <khilman@baylibre.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pinctrl: meson: fix gpio request disabling other modes
2016-12-06 14:08 [PATCH] pinctrl: meson: fix gpio request disabling other modes Neil Armstrong
2016-12-07 0:47 ` Kevin Hilman
@ 2016-12-11 21:50 ` Beniamino Galvani
2016-12-28 12:41 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Beniamino Galvani @ 2016-12-11 21:50 UTC (permalink / raw)
To: Neil Armstrong
Cc: linus.walleij, carlo, khilman, linux-gpio, linux-amlogic,
linux-arm-kernel, linux-kernel
On Tue, Dec 06, 2016 at 03:08:16PM +0100, Neil Armstrong wrote:
> The pinctrl_gpio_request is called with the "full" gpio number, already
> containing the base, then meson_pmx_request_gpio is then called with the
> final pin number.
> Remove the base addition when calling meson_pmx_disable_other_groups.
>
> Fixes: 6ac730951104 ("pinctrl: add driver for Amlogic Meson SoCs")
> CC: Beniamino Galvani <b.galvani@gmail.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Acked-by: Beniamino Galvani <b.galvani@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pinctrl: meson: fix gpio request disabling other modes
2016-12-06 14:08 [PATCH] pinctrl: meson: fix gpio request disabling other modes Neil Armstrong
2016-12-07 0:47 ` Kevin Hilman
2016-12-11 21:50 ` Beniamino Galvani
@ 2016-12-28 12:41 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2016-12-28 12:41 UTC (permalink / raw)
To: Neil Armstrong
Cc: Carlo Caione, Kevin Hilman, linux-gpio,
open list:ARM/Amlogic Meson...,
linux-arm-kernel, linux-kernel, Beniamino Galvani
On Tue, Dec 6, 2016 at 3:08 PM, Neil Armstrong <narmstrong@baylibre.com> wrote:
> The pinctrl_gpio_request is called with the "full" gpio number, already
> containing the base, then meson_pmx_request_gpio is then called with the
> final pin number.
> Remove the base addition when calling meson_pmx_disable_other_groups.
>
> Fixes: 6ac730951104 ("pinctrl: add driver for Amlogic Meson SoCs")
> CC: Beniamino Galvani <b.galvani@gmail.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Patch applied for fixes. Sorry for the delay, merge window appeared inbetween.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-12-28 12:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-06 14:08 [PATCH] pinctrl: meson: fix gpio request disabling other modes Neil Armstrong
2016-12-07 0:47 ` Kevin Hilman
2016-12-11 21:50 ` Beniamino Galvani
2016-12-28 12:41 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).