* [PATCH 5/9] gpio/nomadik: use typesafe __io_address()
@ 2012-04-23 9:14 Linus Walleij
2012-04-23 9:17 ` Russell King - ARM Linux
0 siblings, 1 reply; 3+ messages in thread
From: Linus Walleij @ 2012-04-23 9:14 UTC (permalink / raw)
To: linux-kernel, linux-arm-kernel
Cc: Grant Likely, Philippe LANGLAIS, Rabin Vincent, Jonas Aberg,
Lee Jones, Linus Walleij
From: Linus Walleij <linus.walleij@linaro.org>
We were using a custom io_p2v() (physical-to-virtual) translation
macro, but with the advent of the cross-platform __io_address()
let us try to get rid of this. Inspired by a similar patch by
Jonas Aberg.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/gpio/gpio-nomadik.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-nomadik.c b/drivers/gpio/gpio-nomadik.c
index 7b45d88..edf9a95 100644
--- a/drivers/gpio/gpio-nomadik.c
+++ b/drivers/gpio/gpio-nomadik.c
@@ -1186,7 +1186,7 @@ static int __devinit nmk_gpio_probe(struct platform_device *dev)
*/
nmk_chip->bank = dev->id;
nmk_chip->clk = clk;
- nmk_chip->addr = io_p2v(res->start);
+ nmk_chip->addr = __io_address(res->start);
nmk_chip->chip = nmk_gpio_template;
nmk_chip->parent_irq = irq;
nmk_chip->secondary_parent_irq = secondary_irq;
--
1.7.9.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 5/9] gpio/nomadik: use typesafe __io_address()
2012-04-23 9:14 [PATCH 5/9] gpio/nomadik: use typesafe __io_address() Linus Walleij
@ 2012-04-23 9:17 ` Russell King - ARM Linux
2012-04-23 11:19 ` Linus Walleij
0 siblings, 1 reply; 3+ messages in thread
From: Russell King - ARM Linux @ 2012-04-23 9:17 UTC (permalink / raw)
To: Linus Walleij
Cc: linux-kernel, linux-arm-kernel, Rabin Vincent, Jonas Aberg,
Philippe LANGLAIS, Linus Walleij, Grant Likely, Lee Jones
On Mon, Apr 23, 2012 at 11:14:42AM +0200, Linus Walleij wrote:
> From: Linus Walleij <linus.walleij@linaro.org>
>
> We were using a custom io_p2v() (physical-to-virtual) translation
> macro, but with the advent of the cross-platform __io_address()
> let us try to get rid of this. Inspired by a similar patch by
> Jonas Aberg.
Is there any point to io_p2v() or __io_address() anymore? Won't ioremap()
do here?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 5/9] gpio/nomadik: use typesafe __io_address()
2012-04-23 9:17 ` Russell King - ARM Linux
@ 2012-04-23 11:19 ` Linus Walleij
0 siblings, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2012-04-23 11:19 UTC (permalink / raw)
To: Russell King - ARM Linux
Cc: Linus Walleij, linux-kernel, linux-arm-kernel, Rabin Vincent,
Jonas Aberg, Philippe LANGLAIS, Grant Likely, Lee Jones
On Mon, Apr 23, 2012 at 11:17 AM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Mon, Apr 23, 2012 at 11:14:42AM +0200, Linus Walleij wrote:
>> From: Linus Walleij <linus.walleij@linaro.org>
>>
>> We were using a custom io_p2v() (physical-to-virtual) translation
>> macro, but with the advent of the cross-platform __io_address()
>> let us try to get rid of this. Inspired by a similar patch by
>> Jonas Aberg.
>
> Is there any point to io_p2v() or __io_address() anymore? Won't ioremap()
> do here?
Hey it works, I'll delete the static maps as well and send an updated patch.
Thanks Russell,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-04-23 11:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-23 9:14 [PATCH 5/9] gpio/nomadik: use typesafe __io_address() Linus Walleij
2012-04-23 9:17 ` Russell King - ARM Linux
2012-04-23 11:19 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).