LKML Archive on
 help / color / Atom feed
From: Linus Walleij <>
To: Stephan Gerhold <>
Cc: Mark Brown <>,
	Liam Girdwood <>,
	"" <>
Subject: Re: [PATCH 1/2] regulator: ab8500: Remove AB8505 USB regulator
Date: Thu, 7 Nov 2019 09:02:11 +0100
Message-ID: <> (raw)
In-Reply-To: <>

On Wed, Nov 6, 2019 at 6:33 PM Stephan Gerhold <> wrote:

> The USB regulator was removed for AB8500 in
> commit 41a06aa738ad ("regulator: ab8500: Remove USB regulator").
> It was then added for AB8505 in
> commit 547f384f33db ("regulator: ab8500: add support for ab8505").
> However, there was never an entry added for it in
> ab8505_regulator_match. This causes all regulators after it
> to be initialized with the wrong device tree data, eventually
> leading to an out-of-bounds array read.
> Given that it is not used anywhere in the kernel, it seems
> likely that similar arguments against supporting it exist for
> AB8505 (it is controlled by hardware).
> Therefore, simply remove it like for AB8500 instead of adding
> an entry in ab8505_regulator_match.
> Fixes: 547f384f33db ("regulator: ab8500: add support for ab8505")
> Cc: Linus Walleij <>
> Signed-off-by: Stephan Gerhold <>

Reviewed-by: Linus Walleij <>

Linus Walleij

  parent reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-06 17:31 Stephan Gerhold
2019-11-06 17:31 ` [PATCH 2/2] regulator: ab8500: Remove SYSCLKREQ from enum ab8505_regulator_id Stephan Gerhold
2019-11-07  8:02   ` Linus Walleij
2019-11-07 13:13   ` Applied "regulator: ab8500: Remove SYSCLKREQ from enum ab8505_regulator_id" to the regulator tree Mark Brown
2019-11-07  8:02 ` Linus Walleij [this message]
2020-01-10  8:02   ` [PATCH 1/2] regulator: ab8500: Remove AB8505 USB regulator Naresh Kamboju
2020-01-10  8:16     ` Greg Kroah-Hartman
2019-11-07 13:13 ` Applied "regulator: ab8500: Remove AB8505 USB regulator" to the regulator tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on

Archives are clonable:
	git clone --mirror lkml/git/0.git
	git clone --mirror lkml/git/1.git
	git clone --mirror lkml/git/2.git
	git clone --mirror lkml/git/3.git
	git clone --mirror lkml/git/4.git
	git clone --mirror lkml/git/5.git
	git clone --mirror lkml/git/6.git
	git clone --mirror lkml/git/7.git
	git clone --mirror lkml/git/8.git
	git clone --mirror lkml/git/9.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ \
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone