linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] power: remove duplicated include of abx500.h from ab8500_fb.c
@ 2012-10-15  0:48 Thiago Farina
  2012-10-15 12:37 ` Linus Walleij
  0 siblings, 1 reply; 2+ messages in thread
From: Thiago Farina @ 2012-10-15  0:48 UTC (permalink / raw)
  To: Anton Vorontsov, David Woodhouse; +Cc: linux-kernel

Signed-off-by: Thiago Farina <tfarina@chromium.org>
---
 drivers/power/ab8500_fg.c | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/drivers/power/ab8500_fg.c b/drivers/power/ab8500_fg.c
index 2db8cc2..1041397 100644
--- a/drivers/power/ab8500_fg.c
+++ b/drivers/power/ab8500_fg.c
@@ -15,22 +15,21 @@
  *	Arun R Murthy <arun.murthy@stericsson.com>
  */
 
-#include <linux/init.h>
-#include <linux/module.h>
+#include <linux/completion.h>
+#include <linux/delay.h>
 #include <linux/device.h>
+#include <linux/init.h>
 #include <linux/interrupt.h>
-#include <linux/platform_device.h>
-#include <linux/power_supply.h>
 #include <linux/kobject.h>
-#include <linux/mfd/abx500/ab8500.h>
 #include <linux/mfd/abx500.h>
-#include <linux/slab.h>
 #include <linux/mfd/abx500/ab8500-bm.h>
-#include <linux/delay.h>
 #include <linux/mfd/abx500/ab8500-gpadc.h>
-#include <linux/mfd/abx500.h>
+#include <linux/mfd/abx500/ab8500.h>
+#include <linux/module.h>
+#include <linux/platform_device.h>
+#include <linux/power_supply.h>
+#include <linux/slab.h>
 #include <linux/time.h>
-#include <linux/completion.h>
 
 #define MILLI_TO_MICRO			1000
 #define FG_LSB_IN_MA			1627
-- 
1.8.0.rc2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] power: remove duplicated include of abx500.h from ab8500_fb.c
  2012-10-15  0:48 [PATCH] power: remove duplicated include of abx500.h from ab8500_fb.c Thiago Farina
@ 2012-10-15 12:37 ` Linus Walleij
  0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2012-10-15 12:37 UTC (permalink / raw)
  To: Thiago Farina; +Cc: Anton Vorontsov, David Woodhouse, linux-kernel

On Mon, Oct 15, 2012 at 2:48 AM, Thiago Farina <tfransosi@gmail.com> wrote:

> Signed-off-by: Thiago Farina <tfarina@chromium.org>

The subject of this patch and the empty commit blurb does not
describe what you're actually doing: you are also re-arranging all
the #include directives in alphabetic order, so please tell that
in the commit message.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-10-15 12:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-15  0:48 [PATCH] power: remove duplicated include of abx500.h from ab8500_fb.c Thiago Farina
2012-10-15 12:37 ` Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).