* [PATCH] input: ixp4xx-beeper: include linux/io.h
@ 2019-10-02 9:57 Arnd Bergmann
2019-10-02 12:00 ` Linus Walleij
2019-10-02 12:07 ` Arnd Bergmann
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2019-10-02 9:57 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Arnd Bergmann, Enrico Weigelt, Linus Walleij, linux-input, linux-kernel
asm/io.h may not be included implicitly, causing a rare
randconfig build error:
drivers/input/misc/ixp4xx-beeper.c:48:3: error: implicit declaration of function '__raw_writel' [-Werror,-Wimplicit-function-declaration]
__raw_writel((count & ~IXP4XX_OST_RELOAD_MASK) | IXP4XX_OST_ENABLE,
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/input/misc/ixp4xx-beeper.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/misc/ixp4xx-beeper.c b/drivers/input/misc/ixp4xx-beeper.c
index 764cf21c0aaf..456325f0ea59 100644
--- a/drivers/input/misc/ixp4xx-beeper.c
+++ b/drivers/input/misc/ixp4xx-beeper.c
@@ -17,6 +17,7 @@
#include <linux/platform_device.h>
#include <linux/interrupt.h>
#include <linux/gpio.h>
+#include <linux/io.h>
MODULE_AUTHOR("Alessandro Zummo <a.zummo@towertech.it>");
MODULE_DESCRIPTION("ixp4xx beeper driver");
--
2.20.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] input: ixp4xx-beeper: include linux/io.h
2019-10-02 9:57 [PATCH] input: ixp4xx-beeper: include linux/io.h Arnd Bergmann
@ 2019-10-02 12:00 ` Linus Walleij
2019-10-02 12:07 ` Arnd Bergmann
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2019-10-02 12:00 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Dmitry Torokhov, Enrico Weigelt, Linux Input, linux-kernel
On Wed, Oct 2, 2019 at 11:57 AM Arnd Bergmann <arnd@arndb.de> wrote:
> asm/io.h may not be included implicitly, causing a rare
> randconfig build error:
>
> drivers/input/misc/ixp4xx-beeper.c:48:3: error: implicit declaration of function '__raw_writel' [-Werror,-Wimplicit-function-declaration]
> __raw_writel((count & ~IXP4XX_OST_RELOAD_MASK) | IXP4XX_OST_ENABLE,
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
I am thinking a bit about the future of this driver. Isn't it more
reasonable to just make a hrtimer-driven PWM and use the existing
PWM userspace ABI and timer framework in Linux for this?
Not that there is a generic timer-driven PWM but ... that is
essentially what this driver is.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] input: ixp4xx-beeper: include linux/io.h
2019-10-02 9:57 [PATCH] input: ixp4xx-beeper: include linux/io.h Arnd Bergmann
2019-10-02 12:00 ` Linus Walleij
@ 2019-10-02 12:07 ` Arnd Bergmann
1 sibling, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2019-10-02 12:07 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Enrico Weigelt, Linus Walleij, open list:HID CORE LAYER, linux-kernel
On Wed, Oct 2, 2019 at 11:57 AM Arnd Bergmann <arnd@arndb.de> wrote:
>
> asm/io.h may not be included implicitly, causing a rare
> randconfig build error:
>
> drivers/input/misc/ixp4xx-beeper.c:48:3: error: implicit declaration of function '__raw_writel' [-Werror,-Wimplicit-function-declaration]
> __raw_writel((count & ~IXP4XX_OST_RELOAD_MASK) | IXP4XX_OST_ENABLE,
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Please ignore, this does not apply to mainline and is probably only needed
on top of another patch that I will submit in the future.
Arnd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-02 12:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-02 9:57 [PATCH] input: ixp4xx-beeper: include linux/io.h Arnd Bergmann
2019-10-02 12:00 ` Linus Walleij
2019-10-02 12:07 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).