* [PATCH] pinctrl: amd: Pick some different unicode symbols
@ 2022-08-23 23:07 Mario Limonciello
2022-08-24 13:51 ` David Laight
2022-08-26 13:23 ` Linus Walleij
0 siblings, 2 replies; 5+ messages in thread
From: Mario Limonciello @ 2022-08-23 23:07 UTC (permalink / raw)
To: mario.limonciello, Basavaraj Natikar, Shyam Sundar S K, Linus Walleij
Cc: Kent Gibson, linux-gpio, linux-kernel
Feedback from Kent had showed some better selections for symbols to
use for pinctrl-amd debugfs output. Adopt some of those instead.
Fixes: e8129a076a50 ("pinctrl: amd: Use unicode for debugfs output")
Suggested-by: Kent Gibson <warthog618@gmail.com>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
drivers/pinctrl/pinctrl-amd.c | 28 ++++++++++++++--------------
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-amd.c b/drivers/pinctrl/pinctrl-amd.c
index 4691a33bc374..fda41907c4f1 100644
--- a/drivers/pinctrl/pinctrl-amd.c
+++ b/drivers/pinctrl/pinctrl-amd.c
@@ -246,7 +246,7 @@ static void amd_gpio_dbg_show(struct seq_file *s, struct gpio_chip *gc)
}
seq_printf(s, "GPIO bank%d\n", bank);
for (; i < pin_num; i++) {
- seq_printf(s, "📌%d\t", i);
+ seq_printf(s, "#%d\t", i);
raw_spin_lock_irqsave(&gpio_dev->lock, flags);
pin_reg = readl(gpio_dev->base + i * 4);
raw_spin_unlock_irqrestore(&gpio_dev->lock, flags);
@@ -278,32 +278,32 @@ static void amd_gpio_dbg_show(struct seq_file *s, struct gpio_chip *gc)
}
if (pin_reg & BIT(INTERRUPT_MASK_OFF))
- interrupt_mask = "-";
+ interrupt_mask = "😛";
else
- interrupt_mask = "+";
- seq_printf(s, "int %s (🎭 %s)| active-%s| %s-🔫| ",
+ interrupt_mask = "😷";
+ seq_printf(s, "int %s (%s)| active-%s| %s-⚡| ",
interrupt_enable,
interrupt_mask,
active_level,
level_trig);
if (pin_reg & BIT(WAKE_CNTRL_OFF_S0I3))
- wake_cntrl0 = "+";
+ wake_cntrl0 = "⏰";
else
- wake_cntrl0 = "∅";
- seq_printf(s, "S0i3 🌅 %s| ", wake_cntrl0);
+ wake_cntrl0 = " ∅";
+ seq_printf(s, "S0i3 %s| ", wake_cntrl0);
if (pin_reg & BIT(WAKE_CNTRL_OFF_S3))
- wake_cntrl1 = "+";
+ wake_cntrl1 = "⏰";
else
- wake_cntrl1 = "∅";
- seq_printf(s, "S3 🌅 %s| ", wake_cntrl1);
+ wake_cntrl1 = " ∅";
+ seq_printf(s, "S3 %s| ", wake_cntrl1);
if (pin_reg & BIT(WAKE_CNTRL_OFF_S4))
- wake_cntrl2 = "+";
+ wake_cntrl2 = "⏰";
else
- wake_cntrl2 = "∅";
- seq_printf(s, "S4/S5 🌅 %s| ", wake_cntrl2);
+ wake_cntrl2 = " ∅";
+ seq_printf(s, "S4/S5 %s| ", wake_cntrl2);
if (pin_reg & BIT(PULL_UP_ENABLE_OFF)) {
pull_up_enable = "+";
@@ -367,7 +367,7 @@ static void amd_gpio_dbg_show(struct seq_file *s, struct gpio_chip *gc)
debounce_enable = " ∅";
}
snprintf(debounce_value, sizeof(debounce_value), "%u", time * unit);
- seq_printf(s, "debounce %s (⏰ %sus)| ", debounce_enable, debounce_value);
+ seq_printf(s, "debounce %s (🕑 %sus)| ", debounce_enable, debounce_value);
seq_printf(s, " 0x%x\n", pin_reg);
}
}
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* RE: [PATCH] pinctrl: amd: Pick some different unicode symbols
2022-08-23 23:07 [PATCH] pinctrl: amd: Pick some different unicode symbols Mario Limonciello
@ 2022-08-24 13:51 ` David Laight
2022-08-26 13:24 ` Linus Walleij
2022-08-26 13:23 ` Linus Walleij
1 sibling, 1 reply; 5+ messages in thread
From: David Laight @ 2022-08-24 13:51 UTC (permalink / raw)
To: 'Mario Limonciello',
Basavaraj Natikar, Shyam Sundar S K, Linus Walleij
Cc: Kent Gibson, linux-gpio, linux-kernel
From: Mario Limonciello
> Sent: 24 August 2022 00:08
>
> Feedback from Kent had showed some better selections for symbols to
> use for pinctrl-amd debugfs output. Adopt some of those instead.
I hope I'm never the person you tries to write a test script
to check the output....
Or describe them to someone else...
David
> Fixes: e8129a076a50 ("pinctrl: amd: Use unicode for debugfs output")
The best 'fix' is to remove all the stupid characters.
> Suggested-by: Kent Gibson <warthog618@gmail.com>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> drivers/pinctrl/pinctrl-amd.c | 28 ++++++++++++++--------------
> 1 file changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-amd.c b/drivers/pinctrl/pinctrl-amd.c
> index 4691a33bc374..fda41907c4f1 100644
> --- a/drivers/pinctrl/pinctrl-amd.c
> +++ b/drivers/pinctrl/pinctrl-amd.c
> @@ -246,7 +246,7 @@ static void amd_gpio_dbg_show(struct seq_file *s, struct gpio_chip *gc)
> }
> seq_printf(s, "GPIO bank%d\n", bank);
> for (; i < pin_num; i++) {
> - seq_printf(s, "📌%d\t", i);
> + seq_printf(s, "#%d\t", i);
> raw_spin_lock_irqsave(&gpio_dev->lock, flags);
> pin_reg = readl(gpio_dev->base + i * 4);
> raw_spin_unlock_irqrestore(&gpio_dev->lock, flags);
> @@ -278,32 +278,32 @@ static void amd_gpio_dbg_show(struct seq_file *s, struct gpio_chip *gc)
> }
>
> if (pin_reg & BIT(INTERRUPT_MASK_OFF))
> - interrupt_mask = "-";
> + interrupt_mask = "😛";
> else
> - interrupt_mask = "+";
> - seq_printf(s, "int %s (🎭 %s)| active-%s| %s-🔫| ",
> + interrupt_mask = "😷";
> + seq_printf(s, "int %s (%s)| active-%s| %s-⚡| ",
> interrupt_enable,
> interrupt_mask,
> active_level,
> level_trig);
>
> if (pin_reg & BIT(WAKE_CNTRL_OFF_S0I3))
> - wake_cntrl0 = "+";
> + wake_cntrl0 = "⏰";
> else
> - wake_cntrl0 = "∅";
> - seq_printf(s, "S0i3 🌅 %s| ", wake_cntrl0);
> + wake_cntrl0 = " ∅";
> + seq_printf(s, "S0i3 %s| ", wake_cntrl0);
>
> if (pin_reg & BIT(WAKE_CNTRL_OFF_S3))
> - wake_cntrl1 = "+";
> + wake_cntrl1 = "⏰";
> else
> - wake_cntrl1 = "∅";
> - seq_printf(s, "S3 🌅 %s| ", wake_cntrl1);
> + wake_cntrl1 = " ∅";
> + seq_printf(s, "S3 %s| ", wake_cntrl1);
>
> if (pin_reg & BIT(WAKE_CNTRL_OFF_S4))
> - wake_cntrl2 = "+";
> + wake_cntrl2 = "⏰";
> else
> - wake_cntrl2 = "∅";
> - seq_printf(s, "S4/S5 🌅 %s| ", wake_cntrl2);
> + wake_cntrl2 = " ∅";
> + seq_printf(s, "S4/S5 %s| ", wake_cntrl2);
>
> if (pin_reg & BIT(PULL_UP_ENABLE_OFF)) {
> pull_up_enable = "+";
> @@ -367,7 +367,7 @@ static void amd_gpio_dbg_show(struct seq_file *s, struct gpio_chip *gc)
> debounce_enable = " ∅";
> }
> snprintf(debounce_value, sizeof(debounce_value), "%u", time * unit);
> - seq_printf(s, "debounce %s (⏰ %sus)| ", debounce_enable, debounce_value);
> + seq_printf(s, "debounce %s (🕑 %sus)| ", debounce_enable, debounce_value);
> seq_printf(s, " 0x%x\n", pin_reg);
> }
> }
> --
> 2.34.1
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] pinctrl: amd: Pick some different unicode symbols
2022-08-23 23:07 [PATCH] pinctrl: amd: Pick some different unicode symbols Mario Limonciello
2022-08-24 13:51 ` David Laight
@ 2022-08-26 13:23 ` Linus Walleij
1 sibling, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2022-08-26 13:23 UTC (permalink / raw)
To: Mario Limonciello
Cc: Basavaraj Natikar, Shyam Sundar S K, Kent Gibson, linux-gpio,
linux-kernel
On Wed, Aug 24, 2022 at 1:07 AM Mario Limonciello
<mario.limonciello@amd.com> wrote:
> Feedback from Kent had showed some better selections for symbols to
> use for pinctrl-amd debugfs output. Adopt some of those instead.
>
> Fixes: e8129a076a50 ("pinctrl: amd: Use unicode for debugfs output")
> Suggested-by: Kent Gibson <warthog618@gmail.com>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] pinctrl: amd: Pick some different unicode symbols
2022-08-24 13:51 ` David Laight
@ 2022-08-26 13:24 ` Linus Walleij
2022-08-26 13:29 ` Limonciello, Mario
0 siblings, 1 reply; 5+ messages in thread
From: Linus Walleij @ 2022-08-26 13:24 UTC (permalink / raw)
To: David Laight
Cc: Mario Limonciello, Basavaraj Natikar, Shyam Sundar S K,
Kent Gibson, linux-gpio, linux-kernel
On Wed, Aug 24, 2022 at 3:51 PM David Laight <David.Laight@aculab.com> wrote:
> I hope I'm never the person you tries to write a test script
> to check the output....
> Or describe them to someone else...
I think these are the people doing those scripts at AMD.
> The best 'fix' is to remove all the stupid characters.
I let the people using the debugfs decide :P
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] pinctrl: amd: Pick some different unicode symbols
2022-08-26 13:24 ` Linus Walleij
@ 2022-08-26 13:29 ` Limonciello, Mario
0 siblings, 0 replies; 5+ messages in thread
From: Limonciello, Mario @ 2022-08-26 13:29 UTC (permalink / raw)
To: Linus Walleij, David Laight
Cc: Natikar, Basavaraj, S-k, Shyam-sundar, Kent Gibson, linux-gpio,
linux-kernel
[Public]
> -----Original Message-----
> From: Linus Walleij <linus.walleij@linaro.org>
> Sent: Friday, August 26, 2022 08:25
> To: David Laight <David.Laight@aculab.com>
> Cc: Limonciello, Mario <Mario.Limonciello@amd.com>; Natikar, Basavaraj
> <Basavaraj.Natikar@amd.com>; S-k, Shyam-sundar <Shyam-sundar.S-
> k@amd.com>; Kent Gibson <warthog618@gmail.com>; linux-
> gpio@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] pinctrl: amd: Pick some different unicode symbols
>
> On Wed, Aug 24, 2022 at 3:51 PM David Laight <David.Laight@aculab.com>
> wrote:
>
> > I hope I'm never the person you tries to write a test script
> > to check the output....
> > Or describe them to someone else...
>
> I think these are the people doing those scripts at AMD.
For the types of things this debugfs file is used for, it's typically a human inspection.
That is comparing the net result of what is programmed by firmware and interpreted
by the kernel against a schematic or document. It doesn’t really lend well to scripts, but does
to fitting all the information on a single screen in a concise format.
>
> > The best 'fix' is to remove all the stupid characters.
>
> I let the people using the debugfs decide :P
>
> Yours,
> Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-08-26 13:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-23 23:07 [PATCH] pinctrl: amd: Pick some different unicode symbols Mario Limonciello
2022-08-24 13:51 ` David Laight
2022-08-26 13:24 ` Linus Walleij
2022-08-26 13:29 ` Limonciello, Mario
2022-08-26 13:23 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).