From: Linus Walleij <linus.walleij@linaro.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Timur Tabi <timur@codeaurora.org>,
Pramod Gurav <pramod.gurav@smartplayin.com>,
Bjorn Andersson <bjorn.andersson@sonymobile.com>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
"Ivan T. Ivanov" <iivanov@mm-sol.com>,
Andy Gross <agross@codeaurora.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 4/4] pinctrl: qcom: Add support for reset for apq8064
Date: Mon, 19 Jan 2015 11:18:31 +0100 [thread overview]
Message-ID: <CACRpkdaY_6vdY+d0mmce75q7Gh_Jku1MtVuYeus9EO0LfgDHng@mail.gmail.com> (raw)
In-Reply-To: <54B7086E.7060807@codeaurora.org>
On Thu, Jan 15, 2015 at 1:23 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> On 01/14/2015 03:54 PM, Timur Tabi wrote:
>> On Wed, Jan 14, 2015 at 5:44 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:
>>> I think so. Can you send a patch? Plus it would be nice to move i = 0 in
>>> the for loop at the same time.
>> Sadly, Qualcomm policy makes that very cumbersome for me. I won't be
>> able to send a patch any time soon.
>>
>
> Hm... we'll have to figure out that part. Anyway here's the patch.
>
> ---8<----
> From: Stephen Boyd <sboyd@codeaurora.org>
> Subject: [PATCH] pinctrl: qcom: Don't iterate past end of function array
>
> Timur reports that this code crashes if nfunctions is 0. Fix the
> loop iteration to only consider valid elements of the functions
> array.
>
> Reported-by: Timur Tabi <timur@codeaurora.org>
> Cc: Pramod Gurav <pramod.gurav@smartplayin.com>
> Cc: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> Cc: Ivan T. Ivanov <iivanov@mm-sol.com>
> Cc: Andy Gross <agross@codeaurora.org>
> Fixes: 327455817a92 "pinctrl: qcom: Add support for reset for apq8064"
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
This patch applied for fixes.
Yours,
Linus Walleij
prev parent reply other threads:[~2015-01-19 10:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-29 14:30 [PATCH v3 0/4] Add reset support for apq8064 Pramod Gurav
2014-08-29 14:30 ` [PATCH v3 1/4] ARM: DT: APQ8064: Add pinctrl support Pramod Gurav
2014-08-29 14:30 ` [PATCH v3 2/4] ARM: DT: APQ8064: Add node for ps_hold function in pinctrl Pramod Gurav
2014-08-29 14:30 ` [PATCH v3 3/4] pinctrl: msm: Add ps_hold function in pinctrl-apq8064 binding documentation Pramod Gurav
2014-09-02 12:31 ` Linus Walleij
2014-08-29 14:30 ` [PATCH v3 4/4] pinctrl: qcom: Add support for reset for apq8064 Pramod Gurav
2014-08-29 18:42 ` Bjorn Andersson
2014-08-30 5:08 ` Pramod Gurav
2014-09-02 12:36 ` Linus Walleij
2014-09-02 17:06 ` Bjorn Andersson
2015-01-14 23:38 ` Timur Tabi
2015-01-14 23:44 ` Stephen Boyd
2015-01-14 23:54 ` Timur Tabi
2015-01-15 0:23 ` Stephen Boyd
2015-01-19 10:18 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdaY_6vdY+d0mmce75q7Gh_Jku1MtVuYeus9EO0LfgDHng@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=agross@codeaurora.org \
--cc=bjorn.andersson@sonymobile.com \
--cc=iivanov@mm-sol.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pramod.gurav@smartplayin.com \
--cc=sboyd@codeaurora.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).