From: Timur Tabi <timur@codeaurora.org>
To: Pramod Gurav <pramod.gurav@smartplayin.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
linux-arm-msm@vger.kernel.org,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bjorn Andersson <bjorn.andersson@sonymobile.com>,
Stephen Boyd <sboyd@codeaurora.org>,
"Ivan T. Ivanov" <iivanov@mm-sol.com>,
Andy Gross <agross@codeaurora.org>
Subject: Re: [PATCH v3 4/4] pinctrl: qcom: Add support for reset for apq8064
Date: Wed, 14 Jan 2015 17:38:22 -0600 [thread overview]
Message-ID: <CAOZdJXXRgrYUEcX4f5zRuKgX-Dtbpvf-SV4-8rjuohv3=0NJhQ@mail.gmail.com> (raw)
In-Reply-To: <1409322659-17693-5-git-send-email-pramod.gurav@smartplayin.com>
On Fri, Aug 29, 2014 at 9:30 AM, Pramod Gurav
<pramod.gurav@smartplayin.com> wrote:
>
> +static void msm_pinctrl_setup_pm_reset(struct msm_pinctrl *pctrl)
> +{
> + int i = 0;
> + const struct msm_function *func = pctrl->soc->functions;
> +
> + for (; i <= pctrl->soc->nfunctions; i++)
Shouldn't this be
i < pctrl->soc->nfunctions
As it stands, if nfunctions == 0, this function crashes.
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2015-01-14 23:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-29 14:30 [PATCH v3 0/4] Add reset support for apq8064 Pramod Gurav
2014-08-29 14:30 ` [PATCH v3 1/4] ARM: DT: APQ8064: Add pinctrl support Pramod Gurav
2014-08-29 14:30 ` [PATCH v3 2/4] ARM: DT: APQ8064: Add node for ps_hold function in pinctrl Pramod Gurav
2014-08-29 14:30 ` [PATCH v3 3/4] pinctrl: msm: Add ps_hold function in pinctrl-apq8064 binding documentation Pramod Gurav
2014-09-02 12:31 ` Linus Walleij
2014-08-29 14:30 ` [PATCH v3 4/4] pinctrl: qcom: Add support for reset for apq8064 Pramod Gurav
2014-08-29 18:42 ` Bjorn Andersson
2014-08-30 5:08 ` Pramod Gurav
2014-09-02 12:36 ` Linus Walleij
2014-09-02 17:06 ` Bjorn Andersson
2015-01-14 23:38 ` Timur Tabi [this message]
2015-01-14 23:44 ` Stephen Boyd
2015-01-14 23:54 ` Timur Tabi
2015-01-15 0:23 ` Stephen Boyd
2015-01-19 10:18 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOZdJXXRgrYUEcX4f5zRuKgX-Dtbpvf-SV4-8rjuohv3=0NJhQ@mail.gmail.com' \
--to=timur@codeaurora.org \
--cc=agross@codeaurora.org \
--cc=bjorn.andersson@sonymobile.com \
--cc=iivanov@mm-sol.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pramod.gurav@smartplayin.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).