* [PATCH] pinctrl: mediatek: mt8365: fix IES control pins
@ 2022-04-26 12:57 Mattijs Korpershoek
2022-04-28 23:10 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Mattijs Korpershoek @ 2022-04-26 12:57 UTC (permalink / raw)
To: Sean Wang, Linus Walleij
Cc: Kevin Hilman, Fabien Parent, linux-gpio, linux-mediatek,
linux-arm-kernel, linux-kernel, Mattijs Korpershoek,
Youngmin Han
IES26 (BIT 16 of IES1_CFG_ADDR) controls the following pads:
- PAD_I2S_DATA_IN (GPIO114)
- PAD_I2S_LRCK (GPIO115)
- PAD_I2S_BCK (GPIO116)
The pinctrl table is wrong since it lists pins 114 to 112.
Update the table with the correct values.
Fixes: e94d8b6fb83a ("pinctrl: mediatek: add support for mt8365 SoC")
Reported-by: Youngmin Han <Youngmin.Han@geappliances.com>
Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
---
drivers/pinctrl/mediatek/pinctrl-mt8365.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/mediatek/pinctrl-mt8365.c b/drivers/pinctrl/mediatek/pinctrl-mt8365.c
index 727c65221aef..57f37a294063 100644
--- a/drivers/pinctrl/mediatek/pinctrl-mt8365.c
+++ b/drivers/pinctrl/mediatek/pinctrl-mt8365.c
@@ -259,7 +259,7 @@ static const struct mtk_pin_ies_smt_set mt8365_ies_set[] = {
MTK_PIN_IES_SMT_SPEC(104, 104, 0x420, 13),
MTK_PIN_IES_SMT_SPEC(105, 109, 0x420, 14),
MTK_PIN_IES_SMT_SPEC(110, 113, 0x420, 15),
- MTK_PIN_IES_SMT_SPEC(114, 112, 0x420, 16),
+ MTK_PIN_IES_SMT_SPEC(114, 116, 0x420, 16),
MTK_PIN_IES_SMT_SPEC(117, 119, 0x420, 17),
MTK_PIN_IES_SMT_SPEC(120, 122, 0x420, 18),
MTK_PIN_IES_SMT_SPEC(123, 125, 0x420, 19),
--
2.32.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: mediatek: mt8365: fix IES control pins
2022-04-26 12:57 [PATCH] pinctrl: mediatek: mt8365: fix IES control pins Mattijs Korpershoek
@ 2022-04-28 23:10 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2022-04-28 23:10 UTC (permalink / raw)
To: Mattijs Korpershoek
Cc: Sean Wang, Kevin Hilman, Fabien Parent, linux-gpio,
linux-mediatek, linux-arm-kernel, linux-kernel, Youngmin Han
On Tue, Apr 26, 2022 at 2:57 PM Mattijs Korpershoek
<mkorpershoek@baylibre.com> wrote:
> IES26 (BIT 16 of IES1_CFG_ADDR) controls the following pads:
>
> - PAD_I2S_DATA_IN (GPIO114)
> - PAD_I2S_LRCK (GPIO115)
> - PAD_I2S_BCK (GPIO116)
>
> The pinctrl table is wrong since it lists pins 114 to 112.
>
> Update the table with the correct values.
>
> Fixes: e94d8b6fb83a ("pinctrl: mediatek: add support for mt8365 SoC")
> Reported-by: Youngmin Han <Youngmin.Han@geappliances.com>
> Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
Patch applied for fixes.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-28 23:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-26 12:57 [PATCH] pinctrl: mediatek: mt8365: fix IES control pins Mattijs Korpershoek
2022-04-28 23:10 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).