* [PATCH v2] gpio: ath79: Fix potential NULL dereference in ath79_gpio_probe()
@ 2018-03-24 23:40 Alban Bedel
2018-03-27 13:43 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Alban Bedel @ 2018-03-24 23:40 UTC (permalink / raw)
To: linux-gpio; +Cc: Wei Yongjun, Alban Bedel, Linus Walleij, linux-kernel
From: Wei Yongjun <weiyongjun1@huawei.com>
platform_get_resource() may return NULL, add proper
check to avoid potential NULL dereferencing.
This is detected by Coccinelle semantic patch.
@@
expression pdev, res, n, t, e, e1, e2;
@@
res = platform_get_resource(pdev, t, n);
+ if (!res)
+ return -EINVAL;
... when != res == NULL
e = devm_ioremap(e1, res->start, e2);
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
[albeu@free.fr: Fixed patch to apply on current tree]
Signed-off-by: Alban Bedel <albeu@free.fr>
---
drivers/gpio/gpio-ath79.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpio/gpio-ath79.c b/drivers/gpio/gpio-ath79.c
index 3ae7c18..684e9d6 100644
--- a/drivers/gpio/gpio-ath79.c
+++ b/drivers/gpio/gpio-ath79.c
@@ -258,6 +258,8 @@ static int ath79_gpio_probe(struct platform_device *pdev)
}
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+ if (!res)
+ return -EINVAL;
ctrl->base = devm_ioremap_nocache(
&pdev->dev, res->start, resource_size(res));
if (!ctrl->base)
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] gpio: ath79: Fix potential NULL dereference in ath79_gpio_probe()
2018-03-24 23:40 [PATCH v2] gpio: ath79: Fix potential NULL dereference in ath79_gpio_probe() Alban Bedel
@ 2018-03-27 13:43 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2018-03-27 13:43 UTC (permalink / raw)
To: Alban Bedel; +Cc: open list:GPIO SUBSYSTEM, Wei Yongjun, linux-kernel
On Sun, Mar 25, 2018 at 12:40 AM, Alban Bedel <albeu@free.fr> wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> platform_get_resource() may return NULL, add proper
> check to avoid potential NULL dereferencing.
>
> This is detected by Coccinelle semantic patch.
>
> @@
> expression pdev, res, n, t, e, e1, e2;
> @@
>
> res = platform_get_resource(pdev, t, n);
> + if (!res)
> + return -EINVAL;
> ... when != res == NULL
> e = devm_ioremap(e1, res->start, e2);
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> [albeu@free.fr: Fixed patch to apply on current tree]
> Signed-off-by: Alban Bedel <albeu@free.fr>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-27 13:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-24 23:40 [PATCH v2] gpio: ath79: Fix potential NULL dereference in ath79_gpio_probe() Alban Bedel
2018-03-27 13:43 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).