* [PATCH] gpiolib: Add decode of WM8994 GPIO configuration
@ 2011-11-28 18:05 Mark Brown
2011-11-29 8:31 ` Linus Walleij
0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2011-11-28 18:05 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-kernel, patches, Mark Brown
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
drivers/gpio/gpio-wm8994.c | 79 ++++++++++++++++++++++++++++++++++++++++++-
1 files changed, 77 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-wm8994.c b/drivers/gpio/gpio-wm8994.c
index 96198f3..92ea535 100644
--- a/drivers/gpio/gpio-wm8994.c
+++ b/drivers/gpio/gpio-wm8994.c
@@ -117,6 +117,60 @@ static int wm8994_gpio_to_irq(struct gpio_chip *chip, unsigned offset)
#ifdef CONFIG_DEBUG_FS
+static const char *wm8994_gpio_fn(u16 fn)
+{
+ switch (fn) {
+ case WM8994_GP_FN_PIN_SPECIFIC:
+ return "pin-specific";
+ case WM8994_GP_FN_GPIO:
+ return "GPIO";
+ case WM8994_GP_FN_SDOUT:
+ return "SDOUT";
+ case WM8994_GP_FN_IRQ:
+ return "IRQ";
+ case WM8994_GP_FN_TEMPERATURE:
+ return "Temperature";
+ case WM8994_GP_FN_MICBIAS1_DET:
+ return "MICBIAS1 detect";
+ case WM8994_GP_FN_MICBIAS1_SHORT:
+ return "MICBIAS1 short";
+ case WM8994_GP_FN_MICBIAS2_DET:
+ return "MICBIAS2 detect";
+ case WM8994_GP_FN_MICBIAS2_SHORT:
+ return "MICBIAS2 short";
+ case WM8994_GP_FN_FLL1_LOCK:
+ return "FLL1 lock";
+ case WM8994_GP_FN_FLL2_LOCK:
+ return "FLL2 lock";
+ case WM8994_GP_FN_SRC1_LOCK:
+ return "SRC1 lock";
+ case WM8994_GP_FN_SRC2_LOCK:
+ return "SRC2 lock";
+ case WM8994_GP_FN_DRC1_ACT:
+ return "DRC1 activity";
+ case WM8994_GP_FN_DRC2_ACT:
+ return "DRC2 activity";
+ case WM8994_GP_FN_DRC3_ACT:
+ return "DRC3 activity";
+ case WM8994_GP_FN_WSEQ_STATUS:
+ return "Write sequencer";
+ case WM8994_GP_FN_FIFO_ERROR:
+ return "FIFO error";
+ case WM8994_GP_FN_OPCLK:
+ return "OPCLK";
+ case WM8994_GP_FN_THW:
+ return "Thermal warning";
+ case WM8994_GP_FN_DCS_DONE:
+ return "DC servo";
+ case WM8994_GP_FN_FLL1_OUT:
+ return "FLL1 output";
+ case WM8994_GP_FN_FLL2_OUT:
+ return "FLL1 output";
+ default:
+ return "Unknown";
+ }
+}
+
static void wm8994_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip)
{
struct wm8994_gpio *wm8994_gpio = to_wm8994_gpio(chip);
@@ -148,8 +202,29 @@ static void wm8994_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip)
continue;
}
- /* No decode yet; note that GPIO2 is special */
- seq_printf(s, "(%x)\n", reg);
+ if (reg & WM8994_GPN_DIR)
+ seq_printf(s, "in ");
+ else
+ seq_printf(s, "out ");
+
+ if (reg & WM8994_GPN_PU)
+ seq_printf(s, "pull up ");
+
+ if (reg & WM8994_GPN_PD)
+ seq_printf(s, "pull down ");
+
+ if (reg & WM8994_GPN_POL)
+ seq_printf(s, "inverted ");
+ else
+ seq_printf(s, "noninverted ");
+
+ if (reg & WM8994_GPN_OP_CFG)
+ seq_printf(s, "open drain ");
+ else
+ seq_printf(s, "CMOS ");
+
+ seq_printf(s, "%s (%x)\n",
+ wm8994_gpio_fn(reg & WM8994_GPN_FN_MASK), reg);
}
}
#else
--
1.7.7.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gpiolib: Add decode of WM8994 GPIO configuration
2011-11-28 18:05 [PATCH] gpiolib: Add decode of WM8994 GPIO configuration Mark Brown
@ 2011-11-29 8:31 ` Linus Walleij
2011-11-29 10:46 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Linus Walleij @ 2011-11-29 8:31 UTC (permalink / raw)
To: Mark Brown; +Cc: Linus Walleij, linux-kernel, patches
On Mon, Nov 28, 2011 at 7:05 PM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
"gpiolib: Add decode of WM8994 GPIO configuration"
Nitpicky: I would write "gpio/wm8994: add decode of gpio configuration" but
that's up to you.
Perhaps some commit blurb about the niceness of decoding stuff here?
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Thanks,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpiolib: Add decode of WM8994 GPIO configuration
2011-11-29 8:31 ` Linus Walleij
@ 2011-11-29 10:46 ` Mark Brown
0 siblings, 0 replies; 3+ messages in thread
From: Mark Brown @ 2011-11-29 10:46 UTC (permalink / raw)
To: Linus Walleij; +Cc: Linus Walleij, linux-kernel, patches
On Tue, Nov 29, 2011 at 09:31:18AM +0100, Linus Walleij wrote:
> On Mon, Nov 28, 2011 at 7:05 PM, Mark Brown
> <broonie@opensource.wolfsonmicro.com> wrote:
> "gpiolib: Add decode of WM8994 GPIO configuration"
> Nitpicky: I would write "gpio/wm8994: add decode of gpio configuration" but
> that's up to you.
The brief survey of changelogs have "gpiolib".
> Perhaps some commit blurb about the niceness of decoding stuff here?
I'm not sure that really adds anything; I think the concept of decoding
things into human readable text is standard enough.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-11-29 10:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-11-28 18:05 [PATCH] gpiolib: Add decode of WM8994 GPIO configuration Mark Brown
2011-11-29 8:31 ` Linus Walleij
2011-11-29 10:46 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).