* [PATCH -next] pinctrl: sirf: drop pointless static qualifier in sirfsoc_gpio_probe
@ 2019-01-23 8:41 YueHaibing
2019-01-28 13:43 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-01-23 8:41 UTC (permalink / raw)
To: linus.walleij, baohua, keescook
Cc: linux-kernel, linux-arm-kernel, linux-gpio, YueHaibing
There is no need to have the 'sgpio' variable static since new
value always be assigned before use it.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/pinctrl/sirf/pinctrl-sirf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/sirf/pinctrl-sirf.c b/drivers/pinctrl/sirf/pinctrl-sirf.c
index 2e42d73..2b3bd1a 100644
--- a/drivers/pinctrl/sirf/pinctrl-sirf.c
+++ b/drivers/pinctrl/sirf/pinctrl-sirf.c
@@ -782,7 +782,7 @@ static void sirfsoc_gpio_set_pulldown(struct sirfsoc_gpio_chip *sgpio,
static int sirfsoc_gpio_probe(struct device_node *np)
{
int i, err = 0;
- static struct sirfsoc_gpio_chip *sgpio;
+ struct sirfsoc_gpio_chip *sgpio;
struct sirfsoc_gpio_bank *bank;
void __iomem *regs;
struct platform_device *pdev;
--
2.7.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] pinctrl: sirf: drop pointless static qualifier in sirfsoc_gpio_probe
2019-01-23 8:41 [PATCH -next] pinctrl: sirf: drop pointless static qualifier in sirfsoc_gpio_probe YueHaibing
@ 2019-01-28 13:43 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2019-01-28 13:43 UTC (permalink / raw)
To: YueHaibing
Cc: Barry Song, Kees Cook, linux-kernel, Linux ARM, open list:GPIO SUBSYSTEM
On Wed, Jan 23, 2019 at 9:42 AM YueHaibing <yuehaibing@huawei.com> wrote:
> There is no need to have the 'sgpio' variable static since new
> value always be assigned before use it.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Patch applied.
I haven't heard from the SirfSoC people in some time, I wonder
if they still actively maintain this file?
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-28 13:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-23 8:41 [PATCH -next] pinctrl: sirf: drop pointless static qualifier in sirfsoc_gpio_probe YueHaibing
2019-01-28 13:43 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).