linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] gpio: zynq: remove unneeded (void *) casts in of_match_table
@ 2017-05-12 16:18 Masahiro Yamada
  2017-05-12 16:36 ` Sören Brinkmann
  2017-05-22 15:13 ` Linus Walleij
  0 siblings, 2 replies; 3+ messages in thread
From: Masahiro Yamada @ 2017-05-12 16:18 UTC (permalink / raw)
  To: linux-gpio
  Cc: Masahiro Yamada, Michal Simek, Sören Brinkmann,
	Linus Walleij, linux-kernel, Alexandre Courbot, linux-arm-kernel

of_device_id::data is an opaque pointer.  No explicit cast is needed.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 drivers/gpio/gpio-zynq.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c
index 6b4d10d..ed87c9a 100644
--- a/drivers/gpio/gpio-zynq.c
+++ b/drivers/gpio/gpio-zynq.c
@@ -651,9 +651,8 @@ static const struct zynq_platform_data zynq_gpio_def = {
 };
 
 static const struct of_device_id zynq_gpio_of_match[] = {
-	{ .compatible = "xlnx,zynq-gpio-1.0", .data = (void *)&zynq_gpio_def },
-	{ .compatible = "xlnx,zynqmp-gpio-1.0",
-					.data = (void *)&zynqmp_gpio_def },
+	{ .compatible = "xlnx,zynq-gpio-1.0", .data = &zynq_gpio_def },
+	{ .compatible = "xlnx,zynqmp-gpio-1.0", .data = &zynqmp_gpio_def },
 	{ /* end of table */ }
 };
 MODULE_DEVICE_TABLE(of, zynq_gpio_of_match);
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] gpio: zynq: remove unneeded (void *) casts in of_match_table
  2017-05-12 16:18 [PATCH] gpio: zynq: remove unneeded (void *) casts in of_match_table Masahiro Yamada
@ 2017-05-12 16:36 ` Sören Brinkmann
  2017-05-22 15:13 ` Linus Walleij
  1 sibling, 0 replies; 3+ messages in thread
From: Sören Brinkmann @ 2017-05-12 16:36 UTC (permalink / raw)
  To: Masahiro Yamada
  Cc: linux-gpio, Alexandre Courbot, Linus Walleij, Michal Simek,
	linux-kernel, linux-arm-kernel

On Sat, 2017-05-13 at 01:18:45 +0900, Masahiro Yamada wrote:
> of_device_id::data is an opaque pointer.  No explicit cast is needed.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Sören Brinkmann <soren.brinkmann@xilinx.com>

	Sören

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] gpio: zynq: remove unneeded (void *) casts in of_match_table
  2017-05-12 16:18 [PATCH] gpio: zynq: remove unneeded (void *) casts in of_match_table Masahiro Yamada
  2017-05-12 16:36 ` Sören Brinkmann
@ 2017-05-22 15:13 ` Linus Walleij
  1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2017-05-22 15:13 UTC (permalink / raw)
  To: Masahiro Yamada
  Cc: linux-gpio, Michal Simek, Sören Brinkmann, linux-kernel,
	Alexandre Courbot, linux-arm-kernel

On Fri, May 12, 2017 at 6:18 PM, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:

> of_device_id::data is an opaque pointer.  No explicit cast is needed.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Patch applied with Sören's ACK.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-05-22 15:13 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-12 16:18 [PATCH] gpio: zynq: remove unneeded (void *) casts in of_match_table Masahiro Yamada
2017-05-12 16:36 ` Sören Brinkmann
2017-05-22 15:13 ` Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).