* [PATCH] gpio-omap.txt: add reg and interrupts properties
@ 2018-12-14 19:48 Andreas Klinger
2018-12-14 22:02 ` Linus Walleij
2018-12-20 20:46 ` Rob Herring
0 siblings, 2 replies; 3+ messages in thread
From: Andreas Klinger @ 2018-12-14 19:48 UTC (permalink / raw)
To: grygorii.strashko, ssantosh, khilman, linus.walleij,
bgolaszewski, robh+dt, mark.rutland
Cc: linux-omap, linux-gpio, devicetree, linux-kernel
Document properties reg and interrupts for OMAP GPIO controller bindings
Also add unit address in node name of the example
Signed-off-by: Andreas Klinger <ak@it-klinger.de>
---
Documentation/devicetree/bindings/gpio/gpio-omap.txt | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/gpio/gpio-omap.txt b/Documentation/devicetree/bindings/gpio/gpio-omap.txt
index 8d950522e7fa..e57b2cb28f6c 100644
--- a/Documentation/devicetree/bindings/gpio/gpio-omap.txt
+++ b/Documentation/devicetree/bindings/gpio/gpio-omap.txt
@@ -5,6 +5,8 @@ Required properties:
- "ti,omap2-gpio" for OMAP2 controllers
- "ti,omap3-gpio" for OMAP3 controllers
- "ti,omap4-gpio" for OMAP4 controllers
+- reg : Physical base address of the controller and length of memory mapped
+ region.
- gpio-controller : Marks the device node as a GPIO controller.
- #gpio-cells : Should be two.
- first cell is the pin number
@@ -18,6 +20,8 @@ Required properties:
2 = high-to-low edge triggered.
4 = active high level-sensitive.
8 = active low level-sensitive.
+- interrupts : The interrupt the controller is rising as output when an
+ interrupt occures
OMAP specific properties:
- ti,hwmods: Name of the hwmod associated to the GPIO:
@@ -29,11 +33,13 @@ OMAP specific properties:
Example:
-gpio4: gpio4 {
+gpio0: gpio@44e07000 {
compatible = "ti,omap4-gpio";
- ti,hwmods = "gpio4";
+ reg = <0x44e07000 0x1000>;
+ ti,hwmods = "gpio1";
gpio-controller;
#gpio-cells = <2>;
interrupt-controller;
#interrupt-cells = <2>;
+ interrupts = <96>;
};
--
2.11.0
--
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio-omap.txt: add reg and interrupts properties
2018-12-14 19:48 [PATCH] gpio-omap.txt: add reg and interrupts properties Andreas Klinger
@ 2018-12-14 22:02 ` Linus Walleij
2018-12-20 20:46 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2018-12-14 22:02 UTC (permalink / raw)
To: Andreas Klinger
Cc: Grygorii Strashko, Santosh Shilimkar, Kevin Hilman,
Bartosz Golaszewski, Rob Herring, Mark Rutland, Linux-OMAP,
open list:GPIO SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-kernel
On Fri, Dec 14, 2018 at 8:48 PM Andreas Klinger <ak@it-klinger.de>
wrote:> Document properties reg and interrupts for OMAP GPIO
controller bindings
>
> Also add unit address in node name of the example
>
> Signed-off-by: Andreas Klinger <ak@it-klinger.de>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio-omap.txt: add reg and interrupts properties
2018-12-14 19:48 [PATCH] gpio-omap.txt: add reg and interrupts properties Andreas Klinger
2018-12-14 22:02 ` Linus Walleij
@ 2018-12-20 20:46 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2018-12-20 20:46 UTC (permalink / raw)
To: Andreas Klinger
Cc: grygorii.strashko, ssantosh, khilman, linus.walleij,
bgolaszewski, mark.rutland, linux-omap, linux-gpio, devicetree,
linux-kernel
On Fri, Dec 14, 2018 at 08:48:25PM +0100, Andreas Klinger wrote:
> Document properties reg and interrupts for OMAP GPIO controller bindings
>
> Also add unit address in node name of the example
>
> Signed-off-by: Andreas Klinger <ak@it-klinger.de>
> ---
> Documentation/devicetree/bindings/gpio/gpio-omap.txt | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
Applied.
Rob
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-20 20:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-14 19:48 [PATCH] gpio-omap.txt: add reg and interrupts properties Andreas Klinger
2018-12-14 22:02 ` Linus Walleij
2018-12-20 20:46 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).