* [PATCH] pinctrl: nomadik: Remove unused variable in nmk_gpio_dbg_show_one
@ 2020-12-29 20:47 Nathan Chancellor
2021-01-05 15:15 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Nathan Chancellor @ 2020-12-29 20:47 UTC (permalink / raw)
To: Thomas Gleixner, Linus Walleij
Cc: linux-arm-kernel, linux-gpio, linux-kernel, clang-built-linux,
Nathan Chancellor
Clang warns:
drivers/pinctrl/nomadik/pinctrl-nomadik.c:952:8: warning: unused
variable 'wake' [-Wunused-variable]
bool wake;
^
1 warning generated.
There were two wake declarations added to nmk_gpio_dbg_show_one when
converting it to use irq_has_action but only one is used within its
scope. Remove the unused one so there is no more warning.
Fixes: f3925032d7fd ("pinctrl: nomadik: Use irq_has_action()")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
drivers/pinctrl/nomadik/pinctrl-nomadik.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik.c b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
index d4ea10803fd9..abfe11c7b49f 100644
--- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c
+++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
@@ -949,7 +949,6 @@ static void nmk_gpio_dbg_show_one(struct seq_file *s,
} else {
int irq = chip->to_irq(chip, offset);
const int pullidx = pull ? 1 : 0;
- bool wake;
int val;
static const char * const pulls[] = {
"none ",
base-commit: 5c8fe583cce542aa0b84adc939ce85293de36e5e
--
2.30.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: nomadik: Remove unused variable in nmk_gpio_dbg_show_one
2020-12-29 20:47 [PATCH] pinctrl: nomadik: Remove unused variable in nmk_gpio_dbg_show_one Nathan Chancellor
@ 2021-01-05 15:15 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2021-01-05 15:15 UTC (permalink / raw)
To: Nathan Chancellor
Cc: Thomas Gleixner, Linux ARM, open list:GPIO SUBSYSTEM,
linux-kernel, clang-built-linux
On Tue, Dec 29, 2020 at 9:47 PM Nathan Chancellor
<natechancellor@gmail.com> wrote:
> drivers/pinctrl/nomadik/pinctrl-nomadik.c:952:8: warning: unused
> variable 'wake' [-Wunused-variable]
> bool wake;
> ^
> 1 warning generated.
>
> There were two wake declarations added to nmk_gpio_dbg_show_one when
> converting it to use irq_has_action but only one is used within its
> scope. Remove the unused one so there is no more warning.
>
> Fixes: f3925032d7fd ("pinctrl: nomadik: Use irq_has_action()")
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-05 15:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-29 20:47 [PATCH] pinctrl: nomadik: Remove unused variable in nmk_gpio_dbg_show_one Nathan Chancellor
2021-01-05 15:15 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).