From: Linus Walleij <linus.walleij@linaro.org>
To: Neil Armstrong <narmstrong@baylibre.com>,
Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: Peter Rosin <peda@axentia.se>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Wei Chen <Wei.Chen@csr.com>, Roland Stigge <stigge@antcom.de>,
Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Subject: Re: [PATCH v2] pinctrl: Add SX150X GPIO Extender Pinctrl Driver
Date: Fri, 21 Oct 2016 00:08:01 +0200 [thread overview]
Message-ID: <CACRpkdbZfLMGndsMvueXA6jvsX62tyKjikz1FzpKW+yL=weoXA@mail.gmail.com> (raw)
In-Reply-To: <1474991325-1754-1-git-send-email-narmstrong@baylibre.com>
On Tue, Sep 27, 2016 at 5:48 PM, Neil Armstrong <narmstrong@baylibre.com> wrote:
> Since the I2C sx150x GPIO expander driver uses platform_data to manage
> the pins configurations, rewrite the driver as a pinctrl driver using
> pinconf to get/set pin configurations from DT or debugfs.
>
> The pinctrl driver is functionnally equivalent as the gpio-only driver
> and can use DT for pinconf. The platform_data confirmation is dropped.
>
> This patchset removed the gpio-only driver and selects the Pinctrl driver
> config instead. This patchset also migrates the gpio dt-bindings to pinctrl
> and add the pinctrl optional properties.
>
> The driver was tested with a SX1509 device on a BeagleBone black with
> interrupt support and on an X86_64 machine over an I2C to USB converter.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
I think we're ready to apply this to the GPIO and pinctrl trees.
Could you:
- Rebase on top of v4.9-rc1 (fails to apply for me)
- Add the collected ACKs
- See if Andrey can provide an additional Test tag
- Resend
Also please look at Andreys patches to see if there is some good
inspiration for further cleanups.
Yours,
Linus Walleij
prev parent reply other threads:[~2016-10-20 22:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 15:48 [PATCH v2] pinctrl: Add SX150X GPIO Extender Pinctrl Driver Neil Armstrong
2016-09-27 16:18 ` Peter Rosin
2016-10-09 1:29 ` Rob Herring
2016-10-20 22:08 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdbZfLMGndsMvueXA6jvsX62tyKjikz1FzpKW+yL=weoXA@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=Wei.Chen@csr.com \
--cc=andrew.smirnov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=peda@axentia.se \
--cc=stigge@antcom.de \
--cc=vladimir_zapolskiy@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).