* [PATCH] pinctrl: at91-pio4: Make PINCTRL_AT91PIO4 depend on HAS_IOMEM to fix build error
@ 2020-11-24 9:17 Tiezhu Yang
2020-12-04 8:55 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Tiezhu Yang @ 2020-11-24 9:17 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-gpio, linux-kernel, Xuefeng Li
If CONFIG_HAS_IOMEM is not set, devm_platform_ioremap_resource() will
be not built in drivers/base/platform.c and then there exists a build
error about undefined reference to "devm_platform_ioremap_resource"
in pinctrl-at91-pio4.c under COMPILE_TEST and CONFIG_PINCTRL_AT91PIO4,
make PINCTRL_AT91PIO4 depend on HAS_IOMEM to fix it.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
drivers/pinctrl/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 8150953..d132e1a 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -82,6 +82,7 @@ config PINCTRL_AT91
config PINCTRL_AT91PIO4
bool "AT91 PIO4 pinctrl driver"
depends on OF
+ depends on HAS_IOMEM
depends on ARCH_AT91 || COMPILE_TEST
select PINMUX
select GENERIC_PINCONF
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: at91-pio4: Make PINCTRL_AT91PIO4 depend on HAS_IOMEM to fix build error
2020-11-24 9:17 [PATCH] pinctrl: at91-pio4: Make PINCTRL_AT91PIO4 depend on HAS_IOMEM to fix build error Tiezhu Yang
@ 2020-12-04 8:55 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2020-12-04 8:55 UTC (permalink / raw)
To: Tiezhu Yang; +Cc: open list:GPIO SUBSYSTEM, linux-kernel, Xuefeng Li
On Tue, Nov 24, 2020 at 10:17 AM Tiezhu Yang <yangtiezhu@loongson.cn> wrote:
> If CONFIG_HAS_IOMEM is not set, devm_platform_ioremap_resource() will
> be not built in drivers/base/platform.c and then there exists a build
> error about undefined reference to "devm_platform_ioremap_resource"
> in pinctrl-at91-pio4.c under COMPILE_TEST and CONFIG_PINCTRL_AT91PIO4,
> make PINCTRL_AT91PIO4 depend on HAS_IOMEM to fix it.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Patch applied as non-critical fix for v5.11.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-04 8:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-24 9:17 [PATCH] pinctrl: at91-pio4: Make PINCTRL_AT91PIO4 depend on HAS_IOMEM to fix build error Tiezhu Yang
2020-12-04 8:55 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).