From: Linus Walleij <linus.walleij@linaro.org>
To: Nikita Travkin <nikita@trvn.ru>
Cc: dmitry.torokhov@gmail.com, robh+dt@kernel.org,
Michael.Srba@seznam.cz, broonie@kernel.org,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
phone-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH 1/6] input: touchscreen: zinitix: Make sure the IRQ is allocated before it gets enabled
Date: Tue, 9 Nov 2021 05:37:33 +0100 [thread overview]
Message-ID: <CACRpkdbnZ+U4GgaWyM7v62Ex6SNBMs-j6-pc7k1Wkan18=O+uw@mail.gmail.com> (raw)
In-Reply-To: <20211027181350.91630-2-nikita@trvn.ru>
On Wed, Oct 27, 2021 at 8:15 PM Nikita Travkin <nikita@trvn.ru> wrote:
> Since irq request is the last thing in the driver probe, it happens
> later than the input device registration. This means that there is a
> small time window where if the open method is called the driver will
> attempt to enable not yet available irq.
>
> Fix that by moving the irq request before the input device registration.
>
> Fixes: 26822652c85e ("Input: add zinitix touchscreen driver")
> Signed-off-by: Nikita Travkin <nikita@trvn.ru>
Good catch!
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
next prev parent reply other threads:[~2021-11-09 4:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 18:13 [PATCH 0/6] Add touch-keys support to the Zinitix touch driver Nikita Travkin
2021-10-27 18:13 ` [PATCH 1/6] input: touchscreen: zinitix: Make sure the IRQ is allocated before it gets enabled Nikita Travkin
2021-11-09 4:37 ` Linus Walleij [this message]
2021-10-27 18:13 ` [PATCH 2/6] dt-bindings: input/ts/zinitix: Convert to YAML, fix and extend Nikita Travkin
2021-11-01 21:39 ` Rob Herring
2021-11-09 4:39 ` Linus Walleij
2021-10-27 18:13 ` [PATCH 3/6] Input: zinitix - Handle proper supply names Nikita Travkin
2021-10-27 18:30 ` Luca Weiss
2021-10-27 18:13 ` [PATCH 4/6] input: touchscreen: zinitix: Add compatible for bt532 Nikita Travkin
2021-11-09 4:41 ` Linus Walleij
2021-10-27 18:13 ` [PATCH 5/6] dt-bindings: input: zinitix: Document touch-keys support Nikita Travkin
2021-10-27 18:33 ` Luca Weiss
2021-10-27 18:54 ` Nikita Travkin
2021-11-01 21:41 ` Rob Herring
2021-10-27 18:13 ` [PATCH 6/6] input: touchscreen: zinitix: Add touchkey support Nikita Travkin
2021-11-09 4:42 ` Linus Walleij
2021-11-10 6:01 ` kernel test robot
2021-11-09 4:45 ` [PATCH 0/6] Add touch-keys support to the Zinitix touch driver Linus Walleij
2021-11-09 15:23 ` Nikita Travkin
2021-11-11 10:40 ` Linus Walleij
2022-01-04 21:04 ` Linus Walleij
2022-01-05 5:10 ` Nikita Travkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdbnZ+U4GgaWyM7v62Ex6SNBMs-j6-pc7k1Wkan18=O+uw@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=Michael.Srba@seznam.cz \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikita@trvn.ru \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).