From: Rob Herring <robh@kernel.org>
To: Nikita Travkin <nikita@trvn.ru>
Cc: linux-kernel@vger.kernel.org, dmitry.torokhov@gmail.com,
~postmarketos/upstreaming@lists.sr.ht, broonie@kernel.org,
devicetree@vger.kernel.org, linus.walleij@linaro.org,
Michael.Srba@seznam.cz, robh+dt@kernel.org,
phone-devel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH 2/6] dt-bindings: input/ts/zinitix: Convert to YAML, fix and extend
Date: Mon, 1 Nov 2021 16:39:16 -0500 [thread overview]
Message-ID: <YYBehK8JfcxN/geo@robh.at.kernel.org> (raw)
In-Reply-To: <20211027181350.91630-3-nikita@trvn.ru>
On Wed, 27 Oct 2021 23:13:46 +0500, Nikita Travkin wrote:
> From: Linus Walleij <linus.walleij@linaro.org>
>
> This converts the Zinitix BT4xx and BT5xx touchscreen bindings to YAML, fix
> them up a bit and extends them.
>
> We list all the existing BT4xx and BT5xx components with compatible strings.
> These are all similar, use the same bindings and work in similar ways.
>
> We rename the supplies from the erroneous vdd/vddo to the actual supply
> names vcca/vdd as specified on the actual component. It is long established
> that supplies shall be named after the supply pin names of a component.
> The confusion probably stems from that in a certain product the rails to the
> component were named vdd/vddo. Drop some notes on how OS implementations should
> avoid confusion by first looking for vddo, and if that exists assume the
> legacy binding pair and otherwise use vcca/vdd.
>
> Add reset-gpios as sometimes manufacturers pulls a GPIO line to the reset
> line on the chip.
>
> Add optional touchscreen-fuzz-x and touchscreen-fuzz-y properties.
>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Michael Srba <Michael.Srba@seznam.cz>
> Cc: phone-devel@vger.kernel.org
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> [Fixed dt_schema_check error]
> Signed-off-by: Nikita Travkin <nikita@trvn.ru>
> ---
> This patch was previously submited here:
> https://lore.kernel.org/linux-input/20210625113435.2539282-1-linus.walleij@linaro.org/
>
> Changes since the original patch:
> - Use enum for compatible list instead of oneOf + const
> ---
> .../input/touchscreen/zinitix,bt400.yaml | 115 ++++++++++++++++++
> .../bindings/input/touchscreen/zinitix.txt | 40 ------
> 2 files changed, 115 insertions(+), 40 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/input/touchscreen/zinitix,bt400.yaml
> delete mode 100644 Documentation/devicetree/bindings/input/touchscreen/zinitix.txt
>
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2021-11-01 21:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 18:13 [PATCH 0/6] Add touch-keys support to the Zinitix touch driver Nikita Travkin
2021-10-27 18:13 ` [PATCH 1/6] input: touchscreen: zinitix: Make sure the IRQ is allocated before it gets enabled Nikita Travkin
2021-11-09 4:37 ` Linus Walleij
2021-10-27 18:13 ` [PATCH 2/6] dt-bindings: input/ts/zinitix: Convert to YAML, fix and extend Nikita Travkin
2021-11-01 21:39 ` Rob Herring [this message]
2021-11-09 4:39 ` Linus Walleij
2021-10-27 18:13 ` [PATCH 3/6] Input: zinitix - Handle proper supply names Nikita Travkin
2021-10-27 18:30 ` Luca Weiss
2021-10-27 18:13 ` [PATCH 4/6] input: touchscreen: zinitix: Add compatible for bt532 Nikita Travkin
2021-11-09 4:41 ` Linus Walleij
2021-10-27 18:13 ` [PATCH 5/6] dt-bindings: input: zinitix: Document touch-keys support Nikita Travkin
2021-10-27 18:33 ` Luca Weiss
2021-10-27 18:54 ` Nikita Travkin
2021-11-01 21:41 ` Rob Herring
2021-10-27 18:13 ` [PATCH 6/6] input: touchscreen: zinitix: Add touchkey support Nikita Travkin
2021-11-09 4:42 ` Linus Walleij
2021-11-10 6:01 ` kernel test robot
2021-11-09 4:45 ` [PATCH 0/6] Add touch-keys support to the Zinitix touch driver Linus Walleij
2021-11-09 15:23 ` Nikita Travkin
2021-11-11 10:40 ` Linus Walleij
2022-01-04 21:04 ` Linus Walleij
2022-01-05 5:10 ` Nikita Travkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYBehK8JfcxN/geo@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=Michael.Srba@seznam.cz \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikita@trvn.ru \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).