* [PATCH] gpio/crystalcove: set IRQCHIP_SKIP_SET_WAKE for the irqchip
@ 2015-05-28 2:58 Aaron Lu
2015-06-02 9:23 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Aaron Lu @ 2015-05-28 2:58 UTC (permalink / raw)
To: Linus Walleij, Alexandre Courbot
Cc: linux-gpio, linux-kernel, Zhu, Lejun, Yang, Bin
The CrystalCove GPIO irqchip doesn't have irq_set_wake callback defined
so we should set IRQCHIP_SKIP_SET_WAKE for it or it would cause an irq
desc's wake_depth unbalanced warning during system resume phase from the
gpio_keys driver, which is the driver for the power button of the ASUS
T100 laptop.
Signed-off-by: Aaron Lu <aaron.lu@intel.com>
Cc: <stable@vger.kernel.org>
---
drivers/gpio/gpio-crystalcove.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/gpio-crystalcove.c b/drivers/gpio/gpio-crystalcove.c
index 91a7ffe83135..ab457fc00e75 100644
--- a/drivers/gpio/gpio-crystalcove.c
+++ b/drivers/gpio/gpio-crystalcove.c
@@ -255,6 +255,7 @@ static struct irq_chip crystalcove_irqchip = {
.irq_set_type = crystalcove_irq_type,
.irq_bus_lock = crystalcove_bus_lock,
.irq_bus_sync_unlock = crystalcove_bus_sync_unlock,
+ .flags = IRQCHIP_SKIP_SET_WAKE,
};
static irqreturn_t crystalcove_gpio_irq_handler(int irq, void *data)
--
2.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio/crystalcove: set IRQCHIP_SKIP_SET_WAKE for the irqchip
2015-05-28 2:58 [PATCH] gpio/crystalcove: set IRQCHIP_SKIP_SET_WAKE for the irqchip Aaron Lu
@ 2015-06-02 9:23 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2015-06-02 9:23 UTC (permalink / raw)
To: Aaron Lu, Shobhit Kumar
Cc: Alexandre Courbot, linux-gpio, linux-kernel, Zhu, Lejun, Yang, Bin
On Thu, May 28, 2015 at 4:58 AM, Aaron Lu <aaron.lu@intel.com> wrote:
> The CrystalCove GPIO irqchip doesn't have irq_set_wake callback defined
> so we should set IRQCHIP_SKIP_SET_WAKE for it or it would cause an irq
> desc's wake_depth unbalanced warning during system resume phase from the
> gpio_keys driver, which is the driver for the power button of the ASUS
> T100 laptop.
>
> Signed-off-by: Aaron Lu <aaron.lu@intel.com>
> Cc: <stable@vger.kernel.org>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-06-02 9:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-28 2:58 [PATCH] gpio/crystalcove: set IRQCHIP_SKIP_SET_WAKE for the irqchip Aaron Lu
2015-06-02 9:23 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).