* [PATCH] pinctrl: qcom: spmi-mpp: Add compatible for pmi8994
@ 2021-04-29 0:37 Bjorn Andersson
2021-05-03 19:31 ` Rob Herring
2021-05-19 0:27 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Bjorn Andersson @ 2021-04-29 0:37 UTC (permalink / raw)
To: Bjorn Andersson, Andy Gross, Linus Walleij, Rob Herring
Cc: linux-arm-msm, linux-gpio, devicetree, linux-kernel
The PMI8994 has 4 multi-purpose-pins, add a compatible for this hardware
block to the MPP driver.
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
PS. I see that while the related gpio driver was converted to hierarchical IRQ
chips the mpp driver didn't get the same treatment. We should fix this at some
point...
Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.txt | 1 +
drivers/pinctrl/qcom/pinctrl-spmi-mpp.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.txt b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.txt
index 0ba07bc96c55..5363d44cbb74 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.txt
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.txt
@@ -21,6 +21,7 @@ of PMIC's from Qualcomm.
"qcom,pmi8950-mpp",
"qcom,pm8994-mpp",
"qcom,pma8084-mpp",
+ "qcom,pmi8994-mpp",
And must contain either "qcom,spmi-mpp" or "qcom,ssbi-mpp"
if the device is on an spmi bus or an ssbi bus respectively.
diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c b/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c
index 3c213f799feb..2da9b5f68f3f 100644
--- a/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c
+++ b/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c
@@ -920,6 +920,7 @@ static const struct of_device_id pmic_mpp_of_match[] = {
{ .compatible = "qcom,pmi8950-mpp" }, /* 4 MPP's */
{ .compatible = "qcom,pm8994-mpp" }, /* 8 MPP's */
{ .compatible = "qcom,pma8084-mpp" }, /* 8 MPP's */
+ { .compatible = "qcom,pmi8994-mpp" }, /* 4 MPP's */
{ .compatible = "qcom,spmi-mpp" }, /* Generic */
{ },
};
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: qcom: spmi-mpp: Add compatible for pmi8994
2021-04-29 0:37 [PATCH] pinctrl: qcom: spmi-mpp: Add compatible for pmi8994 Bjorn Andersson
@ 2021-05-03 19:31 ` Rob Herring
2021-05-19 0:27 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2021-05-03 19:31 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Rob Herring, linux-gpio, Andy Gross, linux-kernel, Linus Walleij,
linux-arm-msm, devicetree
On Wed, 28 Apr 2021 17:37:51 -0700, Bjorn Andersson wrote:
> The PMI8994 has 4 multi-purpose-pins, add a compatible for this hardware
> block to the MPP driver.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
>
> PS. I see that while the related gpio driver was converted to hierarchical IRQ
> chips the mpp driver didn't get the same treatment. We should fix this at some
> point...
>
> Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.txt | 1 +
> drivers/pinctrl/qcom/pinctrl-spmi-mpp.c | 1 +
> 2 files changed, 2 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: qcom: spmi-mpp: Add compatible for pmi8994
2021-04-29 0:37 [PATCH] pinctrl: qcom: spmi-mpp: Add compatible for pmi8994 Bjorn Andersson
2021-05-03 19:31 ` Rob Herring
@ 2021-05-19 0:27 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2021-05-19 0:27 UTC (permalink / raw)
To: Bjorn Andersson, Brian Masney
Cc: Andy Gross, Rob Herring, MSM, open list:GPIO SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-kernel
On Thu, Apr 29, 2021 at 2:37 AM Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
> The PMI8994 has 4 multi-purpose-pins, add a compatible for this hardware
> block to the MPP driver.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Patch applied!
> PS. I see that while the related gpio driver was converted to hierarchical IRQ
> chips the mpp driver didn't get the same treatment. We should fix this at some
> point...
Oooups. I think Brian & I discussed that and that we "take GPIO first"
or so, and then forgot step 2. It should pretty much be a copy/paste
operation of the gitlog of what Brian did with the GPIO driver.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-19 0:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-29 0:37 [PATCH] pinctrl: qcom: spmi-mpp: Add compatible for pmi8994 Bjorn Andersson
2021-05-03 19:31 ` Rob Herring
2021-05-19 0:27 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).