* [PATCH] kasan: make function get_wild_bug_type static
@ 2017-06-22 9:00 Colin King
2017-06-22 9:28 ` Dmitry Vyukov
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-06-22 9:00 UTC (permalink / raw)
To: Andrey Ryabinin, Alexander Potapenko, Dmitry Vyukov, kasan-dev, linux-mm
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The helper function get_wild_bug_type does not need to be in global scope,
so make it static.
Cleans up sparse warning:
"symbol 'get_wild_bug_type' was not declared. Should it be static?"
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
mm/kasan/report.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/kasan/report.c b/mm/kasan/report.c
index beee0e980e2d..04bb1d3eb9ec 100644
--- a/mm/kasan/report.c
+++ b/mm/kasan/report.c
@@ -107,7 +107,7 @@ static const char *get_shadow_bug_type(struct kasan_access_info *info)
return bug_type;
}
-const char *get_wild_bug_type(struct kasan_access_info *info)
+static const char *get_wild_bug_type(struct kasan_access_info *info)
{
const char *bug_type = "unknown-crash";
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] kasan: make function get_wild_bug_type static
2017-06-22 9:00 [PATCH] kasan: make function get_wild_bug_type static Colin King
@ 2017-06-22 9:28 ` Dmitry Vyukov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Vyukov @ 2017-06-22 9:28 UTC (permalink / raw)
To: Colin King
Cc: Andrey Ryabinin, Alexander Potapenko, kasan-dev, linux-mm,
kernel-janitors, LKML, Andrew Morton
On Thu, Jun 22, 2017 at 11:00 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The helper function get_wild_bug_type does not need to be in global scope,
> so make it static.
>
> Cleans up sparse warning:
> "symbol 'get_wild_bug_type' was not declared. Should it be static?"
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Dmitry Vyukov <dvyukov@google.com>
> ---
> mm/kasan/report.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/kasan/report.c b/mm/kasan/report.c
> index beee0e980e2d..04bb1d3eb9ec 100644
> --- a/mm/kasan/report.c
> +++ b/mm/kasan/report.c
> @@ -107,7 +107,7 @@ static const char *get_shadow_bug_type(struct kasan_access_info *info)
> return bug_type;
> }
>
> -const char *get_wild_bug_type(struct kasan_access_info *info)
> +static const char *get_wild_bug_type(struct kasan_access_info *info)
> {
> const char *bug_type = "unknown-crash";
>
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-22 9:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-22 9:00 [PATCH] kasan: make function get_wild_bug_type static Colin King
2017-06-22 9:28 ` Dmitry Vyukov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).