* [PATCH v4] brcmfmac: add missing header dependencies
@ 2016-08-29 12:39 Baoyou Xie
2016-08-29 15:31 ` Rafał Miłecki
2016-09-03 10:10 ` [v4] " Kalle Valo
0 siblings, 2 replies; 5+ messages in thread
From: Baoyou Xie @ 2016-08-29 12:39 UTC (permalink / raw)
To: arend.vanspriel, franky.lin, hante.meuleman, kvalo
Cc: linux-wireless, brcm80211-dev-list.pdl, netdev, linux-kernel,
arnd, baoyou.xie, xie.baoyou
We get 1 warning when build kernel with W=1:
drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c:23:6: warning: no previous prototype for '__brcmf_err' [-Wmissing-prototypes]
In fact, this function is declared in brcmfmac/debug.h, so this patch
add missing header dependencies.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
Acked-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c
index a10f35c..fe67559 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c
@@ -19,6 +19,7 @@
#ifndef __CHECKER__
#define CREATE_TRACE_POINTS
#include "tracepoint.h"
+#include "debug.h"
void __brcmf_err(const char *func, const char *fmt, ...)
{
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v4] brcmfmac: add missing header dependencies
2016-08-29 12:39 [PATCH v4] brcmfmac: add missing header dependencies Baoyou Xie
@ 2016-08-29 15:31 ` Rafał Miłecki
2016-08-29 16:39 ` Rafał Miłecki
[not found] ` <CA+DQWkxpoScXLNhScNpwmLnaMhgVHoGLrH72dAm7OiOX2nW2vA@mail.gmail.com>
2016-09-03 10:10 ` [v4] " Kalle Valo
1 sibling, 2 replies; 5+ messages in thread
From: Rafał Miłecki @ 2016-08-29 15:31 UTC (permalink / raw)
To: Baoyou Xie
Cc: Arend Van Spriel, Franky Lin, Hante Meuleman, Kalle Valo,
linux-wireless,
open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER,
Network Development, Linux Kernel Mailing List, Arnd Bergmann,
xie.baoyou
On 29 August 2016 at 14:39, Baoyou Xie <baoyou.xie@linaro.org> wrote:
> We get 1 warning when build kernel with W=1:
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c:23:6: warning: no previous prototype for '__brcmf_err' [-Wmissing-prototypes]
building? I'm not native English, but I think so.
> In fact, this function is declared in brcmfmac/debug.h, so this patch
> add missing header dependencies.
adds
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
Please don't resend patches just to add tags like that. This only
increases a noise and patchwork handles this just fine, see:
https://patchwork.kernel.org/patch/9303285/
https://patchwork.kernel.org/patch/9303285/mbox/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v4] brcmfmac: add missing header dependencies
2016-08-29 15:31 ` Rafał Miłecki
@ 2016-08-29 16:39 ` Rafał Miłecki
[not found] ` <CA+DQWkxpoScXLNhScNpwmLnaMhgVHoGLrH72dAm7OiOX2nW2vA@mail.gmail.com>
1 sibling, 0 replies; 5+ messages in thread
From: Rafał Miłecki @ 2016-08-29 16:39 UTC (permalink / raw)
To: Baoyou Xie
Cc: Arend Van Spriel, Franky Lin, Hante Meuleman, Kalle Valo,
linux-wireless,
open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER,
Network Development, Linux Kernel Mailing List, Arnd Bergmann,
xie.baoyou
On 29 August 2016 at 17:42, Baoyou Xie <baoyou.xie@linaro.org> wrote:
> On 29 August 2016 at 23:31, Rafał Miłecki <zajec5@gmail.com> wrote:
>>
>> On 29 August 2016 at 14:39, Baoyou Xie <baoyou.xie@linaro.org> wrote:
>> > We get 1 warning when build kernel with W=1:
>> > drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c:23:6:
>> > warning: no previous prototype for '__brcmf_err' [-Wmissing-prototypes]
>>
>> building? I'm not native English, but I think so.
>>
>>
>> > In fact, this function is declared in brcmfmac/debug.h, so this patch
>> > add missing header dependencies.
>>
>> adds
>>
>>
>> > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
>> > Acked-by: Arnd Bergmann <arnd@arndb.de>
>>
>> Please don't resend patches just to add tags like that. This only
>> increases a noise and patchwork handles this just fine, see:
>> https://patchwork.kernel.org/patch/9303285/
>> https://patchwork.kernel.org/patch/9303285/mbox/
>
>
> it modifies a typo biuld/build.
Please send your replies to all, not privately.
OK, so you should also include a changelog in the comments part of diff, e.g.:
V4: Fix typo in "biuld"
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v4] brcmfmac: add missing header dependencies
[not found] ` <CA+DQWkxpoScXLNhScNpwmLnaMhgVHoGLrH72dAm7OiOX2nW2vA@mail.gmail.com>
@ 2016-08-30 16:08 ` Kalle Valo
0 siblings, 0 replies; 5+ messages in thread
From: Kalle Valo @ 2016-08-30 16:08 UTC (permalink / raw)
To: Baoyou Xie
Cc: Rafał Miłecki, Arend Van Spriel, Franky Lin,
Hante Meuleman, linux-wireless,
open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER,
Network Development, Linux Kernel Mailing List, Arnd Bergmann,
xie.baoyou
Baoyou Xie <baoyou.xie@linaro.org> writes:
> On 29 August 2016 at 23:31, Rafał Miłecki <zajec5@gmail.com> wrote:
>
> On 29 August 2016 at 14:39, Baoyou Xie <baoyou.xie@linaro.org> wrote:
> > We get 1 warning when build kernel with W=1:
> > drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c:23:6:
> warning: no previous prototype for '__brcmf_err' [-Wmissing-prototypes]
>
> building? I'm not native English, but I think so.
>
>
> > In fact, this function is declared in brcmfmac/debug.h, so this patch
> > add missing header dependencies.
>
> adds
>
>
> > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> > Acked-by: Arnd Bergmann <arnd@arndb.de>
>
> Please don't resend patches just to add tags like that. This only
> increases a noise and patchwork handles this just fine, see:
> https://patchwork.kernel.org/patch/9303285/
> https://patchwork.kernel.org/patch/9303285/mbox/
>
>
> Do I need to resend a patch that fixes two typos(build/add)? or you modify them
> on your way?
I can fix those when I commit the patch.
--
Kalle Valo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [v4] brcmfmac: add missing header dependencies
2016-08-29 12:39 [PATCH v4] brcmfmac: add missing header dependencies Baoyou Xie
2016-08-29 15:31 ` Rafał Miłecki
@ 2016-09-03 10:10 ` Kalle Valo
1 sibling, 0 replies; 5+ messages in thread
From: Kalle Valo @ 2016-09-03 10:10 UTC (permalink / raw)
To: Baoyou Xie
Cc: arend.vanspriel, franky.lin, hante.meuleman, linux-wireless,
brcm80211-dev-list.pdl, netdev, linux-kernel, arnd, baoyou.xie,
xie.baoyou
Baoyou Xie <baoyou.xie@linaro.org> wrote:
> We get 1 warning when building kernel with W=1:
>
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c:23:6: warning: no previous prototype for '__brcmf_err' [-Wmissing-prototypes]
>
> In fact, this function is declared in brcmfmac/debug.h, so this patch
> adds missing header dependencies.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
Thanks, 1 patch applied to wireless-drivers-next.git:
8af92af3f2d5 brcmfmac: add missing header dependencies
--
Sent by pwcli
https://patchwork.kernel.org/patch/9303939/
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-09-03 10:11 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-29 12:39 [PATCH v4] brcmfmac: add missing header dependencies Baoyou Xie
2016-08-29 15:31 ` Rafał Miłecki
2016-08-29 16:39 ` Rafał Miłecki
[not found] ` <CA+DQWkxpoScXLNhScNpwmLnaMhgVHoGLrH72dAm7OiOX2nW2vA@mail.gmail.com>
2016-08-30 16:08 ` Kalle Valo
2016-09-03 10:10 ` [v4] " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).