* Re: b43: LCN-PHY add place for new PHY support
[not found] <201107230012.p6N0CZSM002466@hera.kernel.org>
@ 2011-08-08 11:57 ` Geert Uytterhoeven
2011-08-08 12:26 ` Rafał Miłecki
0 siblings, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2011-08-08 11:57 UTC (permalink / raw)
To: Rafał Miłecki, John W. Linville
Cc: Linux Kernel Mailing List, linux-wireless
On Sat, Jul 23, 2011 at 02:12, Linux Kernel Mailing List
<linux-kernel@vger.kernel.org> wrote:
> Gitweb: http://git.kernel.org/linus/1d738e64f3d957d56c1b51e64ebdef986a8760e3
> Commit: 1d738e64f3d957d56c1b51e64ebdef986a8760e3
> Parent: 0cd20a278e1ef9da9f6a987942794c9d65af8c4d
> Author: Rafał Miłecki <zajec5@gmail.com>
> AuthorDate: Thu Jul 7 15:25:27 2011 +0200
> Committer: John W. Linville <linville@tuxdriver.com>
> CommitDate: Fri Jul 8 11:11:25 2011 -0400
> diff --git a/drivers/net/wireless/b43/phy_lcn.h b/drivers/net/wireless/b43/phy_lcn.h
> new file mode 100644
> index 0000000..c046c2a
> --- /dev/null
> +++ b/drivers/net/wireless/b43/phy_lcn.h
> \ No newline at end of file
Woops...
gcc/cpp also complains:
drivers/net/wireless/b43/phy_lcn.h:14:28: warning: no newline at end of file
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: b43: LCN-PHY add place for new PHY support
2011-08-08 11:57 ` b43: LCN-PHY add place for new PHY support Geert Uytterhoeven
@ 2011-08-08 12:26 ` Rafał Miłecki
2011-08-08 16:07 ` Gábor Stefanik
0 siblings, 1 reply; 5+ messages in thread
From: Rafał Miłecki @ 2011-08-08 12:26 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: John W. Linville, Linux Kernel Mailing List, linux-wireless
W dniu 8 sierpnia 2011 13:57 użytkownik Geert Uytterhoeven
<geert@linux-m68k.org> napisał:
> On Sat, Jul 23, 2011 at 02:12, Linux Kernel Mailing List
> <linux-kernel@vger.kernel.org> wrote:
>> Gitweb: http://git.kernel.org/linus/1d738e64f3d957d56c1b51e64ebdef986a8760e3
>> Commit: 1d738e64f3d957d56c1b51e64ebdef986a8760e3
>> Parent: 0cd20a278e1ef9da9f6a987942794c9d65af8c4d
>> Author: Rafał Miłecki <zajec5@gmail.com>
>> AuthorDate: Thu Jul 7 15:25:27 2011 +0200
>> Committer: John W. Linville <linville@tuxdriver.com>
>> CommitDate: Fri Jul 8 11:11:25 2011 -0400
>
>> diff --git a/drivers/net/wireless/b43/phy_lcn.h b/drivers/net/wireless/b43/phy_lcn.h
>> new file mode 100644
>> index 0000000..c046c2a
>> --- /dev/null
>> +++ b/drivers/net/wireless/b43/phy_lcn.h
>
>> \ No newline at end of file
>
> Woops...
>
> gcc/cpp also complains:
>
> drivers/net/wireless/b43/phy_lcn.h:14:28: warning: no newline at end of file
Sorry, I didn't know we want empty lines at the end. I also don't
think it's mentioned in kernel's CodingStyle.
I'll fix that when doing LCN stuff, if you agree separated patch is not needed.
My gcc didn't complain :|
--
Rafał
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: b43: LCN-PHY add place for new PHY support
2011-08-08 12:26 ` Rafał Miłecki
@ 2011-08-08 16:07 ` Gábor Stefanik
2011-08-08 17:25 ` John W. Linville
2011-08-08 21:02 ` Rafał Miłecki
0 siblings, 2 replies; 5+ messages in thread
From: Gábor Stefanik @ 2011-08-08 16:07 UTC (permalink / raw)
To: Rafał Miłecki
Cc: Geert Uytterhoeven, John W. Linville, Linux Kernel Mailing List,
linux-wireless
2011/8/8 Rafał Miłecki <zajec5@gmail.com>:
> W dniu 8 sierpnia 2011 13:57 użytkownik Geert Uytterhoeven
> <geert@linux-m68k.org> napisał:
>> On Sat, Jul 23, 2011 at 02:12, Linux Kernel Mailing List
>> <linux-kernel@vger.kernel.org> wrote:
>>> Gitweb: http://git.kernel.org/linus/1d738e64f3d957d56c1b51e64ebdef986a8760e3
>>> Commit: 1d738e64f3d957d56c1b51e64ebdef986a8760e3
>>> Parent: 0cd20a278e1ef9da9f6a987942794c9d65af8c4d
>>> Author: Rafał Miłecki <zajec5@gmail.com>
>>> AuthorDate: Thu Jul 7 15:25:27 2011 +0200
>>> Committer: John W. Linville <linville@tuxdriver.com>
>>> CommitDate: Fri Jul 8 11:11:25 2011 -0400
>>
>>> diff --git a/drivers/net/wireless/b43/phy_lcn.h b/drivers/net/wireless/b43/phy_lcn.h
>>> new file mode 100644
>>> index 0000000..c046c2a
>>> --- /dev/null
>>> +++ b/drivers/net/wireless/b43/phy_lcn.h
>>
>>> \ No newline at end of file
>>
>> Woops...
>>
>> gcc/cpp also complains:
>>
>> drivers/net/wireless/b43/phy_lcn.h:14:28: warning: no newline at end of file
>
> Sorry, I didn't know we want empty lines at the end. I also don't
> think it's mentioned in kernel's CodingStyle.
I'm pretty sure it is basic Unix knowledge that all text files SHOULD
(RFC 2119) end with a newline character, unless otherwise noted
explicitly. In fact, many Unix text editors automatically insert a
newline at the end, and forbid you from deleting it.
>
> I'll fix that when doing LCN stuff, if you agree separated patch is not needed.
>
> My gcc didn't complain :|
>
> --
> Rafał
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: b43: LCN-PHY add place for new PHY support
2011-08-08 16:07 ` Gábor Stefanik
@ 2011-08-08 17:25 ` John W. Linville
2011-08-08 21:02 ` Rafał Miłecki
1 sibling, 0 replies; 5+ messages in thread
From: John W. Linville @ 2011-08-08 17:25 UTC (permalink / raw)
To: Gábor Stefanik
Cc: Rafał Miłecki, Geert Uytterhoeven,
Linux Kernel Mailing List, linux-wireless
On Mon, Aug 08, 2011 at 06:07:07PM +0200, Gábor Stefanik wrote:
> 2011/8/8 Rafał Miłecki <zajec5@gmail.com>:
> > W dniu 8 sierpnia 2011 13:57 użytkownik Geert Uytterhoeven
> > <geert@linux-m68k.org> napisał:
> >> On Sat, Jul 23, 2011 at 02:12, Linux Kernel Mailing List
> >> <linux-kernel@vger.kernel.org> wrote:
> >>> Gitweb: http://git.kernel.org/linus/1d738e64f3d957d56c1b51e64ebdef986a8760e3
> >>> Commit: 1d738e64f3d957d56c1b51e64ebdef986a8760e3
> >>> Parent: 0cd20a278e1ef9da9f6a987942794c9d65af8c4d
> >>> Author: Rafał Miłecki <zajec5@gmail.com>
> >>> AuthorDate: Thu Jul 7 15:25:27 2011 +0200
> >>> Committer: John W. Linville <linville@tuxdriver.com>
> >>> CommitDate: Fri Jul 8 11:11:25 2011 -0400
> >>
> >>> diff --git a/drivers/net/wireless/b43/phy_lcn.h b/drivers/net/wireless/b43/phy_lcn.h
> >>> new file mode 100644
> >>> index 0000000..c046c2a
> >>> --- /dev/null
> >>> +++ b/drivers/net/wireless/b43/phy_lcn.h
> >>
> >>> \ No newline at end of file
> >>
> >> Woops...
> >>
> >> gcc/cpp also complains:
> >>
> >> drivers/net/wireless/b43/phy_lcn.h:14:28: warning: no newline at end of file
> >
> > Sorry, I didn't know we want empty lines at the end. I also don't
> > think it's mentioned in kernel's CodingStyle.
>
> I'm pretty sure it is basic Unix knowledge that all text files SHOULD
> (RFC 2119) end with a newline character, unless otherwise noted
> explicitly. In fact, many Unix text editors automatically insert a
> newline at the end, and forbid you from deleting it.
Please use an editor that does this appropriately, but do _not_
simply add an empty line at the end of a file. 'git am' complains
about empty lines at the end of a file during a commit.
I find that simple loading and saving such files with vi is sufficient
for me -- YMMV.
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: b43: LCN-PHY add place for new PHY support
2011-08-08 16:07 ` Gábor Stefanik
2011-08-08 17:25 ` John W. Linville
@ 2011-08-08 21:02 ` Rafał Miłecki
1 sibling, 0 replies; 5+ messages in thread
From: Rafał Miłecki @ 2011-08-08 21:02 UTC (permalink / raw)
To: Gábor Stefanik
Cc: Geert Uytterhoeven, John W. Linville, Linux Kernel Mailing List,
linux-wireless
W dniu 8 sierpnia 2011 18:07 użytkownik Gábor Stefanik
<netrolller.3d@gmail.com> napisał:
> 2011/8/8 Rafał Miłecki <zajec5@gmail.com>:
>> W dniu 8 sierpnia 2011 13:57 użytkownik Geert Uytterhoeven
>> <geert@linux-m68k.org> napisał:
>>> On Sat, Jul 23, 2011 at 02:12, Linux Kernel Mailing List
>>> <linux-kernel@vger.kernel.org> wrote:
>>>> Gitweb: http://git.kernel.org/linus/1d738e64f3d957d56c1b51e64ebdef986a8760e3
>>>> Commit: 1d738e64f3d957d56c1b51e64ebdef986a8760e3
>>>> Parent: 0cd20a278e1ef9da9f6a987942794c9d65af8c4d
>>>> Author: Rafał Miłecki <zajec5@gmail.com>
>>>> AuthorDate: Thu Jul 7 15:25:27 2011 +0200
>>>> Committer: John W. Linville <linville@tuxdriver.com>
>>>> CommitDate: Fri Jul 8 11:11:25 2011 -0400
>>>
>>>> diff --git a/drivers/net/wireless/b43/phy_lcn.h b/drivers/net/wireless/b43/phy_lcn.h
>>>> new file mode 100644
>>>> index 0000000..c046c2a
>>>> --- /dev/null
>>>> +++ b/drivers/net/wireless/b43/phy_lcn.h
>>>
>>>> \ No newline at end of file
>>>
>>> Woops...
>>>
>>> gcc/cpp also complains:
>>>
>>> drivers/net/wireless/b43/phy_lcn.h:14:28: warning: no newline at end of file
>>
>> Sorry, I didn't know we want empty lines at the end. I also don't
>> think it's mentioned in kernel's CodingStyle.
>
> I'm pretty sure it is basic Unix knowledge that all text files SHOULD
> (RFC 2119) end with a newline character, unless otherwise noted
> explicitly. In fact, many Unix text editors automatically insert a
> newline at the end, and forbid you from deleting it.
OK, thanks, will avoid that in the future.
--
Rafał
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-08-08 21:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <201107230012.p6N0CZSM002466@hera.kernel.org>
2011-08-08 11:57 ` b43: LCN-PHY add place for new PHY support Geert Uytterhoeven
2011-08-08 12:26 ` Rafał Miłecki
2011-08-08 16:07 ` Gábor Stefanik
2011-08-08 17:25 ` John W. Linville
2011-08-08 21:02 ` Rafał Miłecki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).