linux-next: Tree for Aug 22

linux-next: Tree for Aug 22

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 15707 bytes --]

Hi all,

[The kernel.org mirroring is a bit low today]

The powerpc allyesconfig build still fails today.

Changes since 20110819:

The net tree gained a conflict against the 4xx tree.

The pm tree lost its build failure but gained a conflict against the s390
tree.

----------------------------------------------------------------------------

I have created today's linux-next tree at
git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
(patches at http://www.kernel.org/pub/linux/kernel/v2.6/next/ ).  If you
are tracking the linux-next tree using git, you should not use "git pull"
to do so as that will try to merge the new linux-next release with the
old one.  You should use "git fetch" as mentioned in the FAQ on the wiki
(see below).

You can see which trees have been included by looking in the Next/Trees
file in the source.  There are also quilt-import.log and merge.log files
in the Next directory.  Between each merge, the tree was built with
a ppc64_defconfig for powerpc and an allmodconfig for x86_64. After the
final fixups (if any), it is also built with powerpc allnoconfig (32 and
64 bit), ppc44x_defconfig and allyesconfig (minus
CONFIG_PROFILE_ALL_BRANCHES - this fails its final link) and i386, sparc
and sparc64 defconfig. These builds also have
CONFIG_ENABLE_WARN_DEPRECATED, CONFIG_ENABLE_MUST_CHECK and
CONFIG_DEBUG_INFO disabled when necessary.

Below is a summary of the state of the merge.

We are up to 199 trees (counting Linus' and 28 trees of patches pending
for Linus' tree), more are welcome (even if they are currently empty).
Thanks to those who have contributed, and to those who haven't, please do.

Status of my local build tests will be at
http://kisskb.ellerman.id.au/linux-next .  If maintainers want to give
advice about cross compilers/configs that work, we are always open to add
more builds.

Thanks to Randy Dunlap for doing many randconfig builds.

There is a wiki covering stuff to do with linux-next at
http://linux.f-seidel.de/linux-next/pmwiki/ .  Thanks to Frank Seidel.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

$ git checkout master
$ git reset --hard stable
Merging origin/master
Merging fixes/fixes
Merging kbuild-current/rc-fixes
Merging arm-current/master
Merging m68k-current/for-linus
Merging powerpc-merge/merge
Merging 52xx-and-virtex-current/powerpc/merge
Merging sparc-current/master
Merging scsi-rc-fixes/master
Merging net-current/master
Merging sound-current/for-linus
Merging pci-current/for-linus
Merging wireless-current/master
Merging driver-core.current/driver-core-linus
Merging tty.current/tty-linus
Merging usb.current/usb-linus
Merging staging.current/staging-linus
Merging cpufreq-current/fixes
Merging input-current/for-linus
Merging md-current/for-linus
Merging audit-current/for-linus
Merging crypto-current/master
Merging ide-curent/master
Merging dwmw2/master
Merging sh-current/sh-fixes-for-linus
Merging rmobile-current/rmobile-fixes-for-linus
Merging fbdev-current/fbdev-fixes-for-linus
Merging devicetree-current/devicetree/merge
Merging spi-current/spi/merge
Merging arm/for-next
Merging arm-lpae/for-next
CONFLICT (content): Merge conflict in arch/arm/include/asm/pgalloc.h
CONFLICT (content): Merge conflict in arch/arm/include/asm/pgtable.h
CONFLICT (content): Merge conflict in arch/arm/include/asm/tlb.h
Merging arm-soc/for-next
Merging at91/at91-next
Merging davinci/davinci-next
Merging i.MX/for-next
Merging linux-spec/for-next
Merging msm/for-next
CONFLICT (content): Merge conflict in arch/arm/mach-msm/io.c
Merging omap/for-next
Merging pxa/for-next
Merging samsung/next-samsung
Merging s5p/for-next
Merging tegra/for-next
Merging ux500-core/ux500-core
Merging xilinx/arm-next
Merging blackfin/for-linus
Merging cris/for-next
Merging ia64/test
Merging m68k/for-next
Merging m68knommu/for-next
Merging microblaze/next
Merging mips/mips-for-linux-next
Merging openrisc/for-upstream
Merging parisc/for-next
Merging powerpc/next
Merging 4xx/next
Merging 52xx-and-virtex/powerpc/next
Merging galak/next
Merging s390/features
Merging sh/sh-latest
Merging rmobile/rmobile-latest
Merging sparc/master
Merging tile/master
Merging unicore32/unicore32
Merging xtensa/master
Merging ceph/for-next
Merging cifs/master
Merging configfs/linux-next
Merging ecryptfs/next
Merging ext3/for_next
Merging ext4/dev
Merging fatfs/master
Merging fuse/for-next
Merging gfs2/master
Merging hfsplus/for-next
Merging jfs/next
Merging logfs/master
Merging nfs/linux-next
Merging nfsd/nfsd-next
Merging nilfs2/for-next
Merging ocfs2/linux-next
Merging omfs/for-next
Merging squashfs/master
Merging udf/for_next
Merging v9fs/for-next
Merging ubifs/linux-next
Merging xfs/master
Applying: xfs: fix tracing builds inside the source tree
Merging vfs/for-next
Merging vfs-scale/vfs-scale-working
Merging pci/linux-next
Merging hid/for-next
Merging quilt/i2c
Merging bjdooks-i2c/next-i2c
Merging quilt/jdelvare-hwmon
Merging hwmon-staging/hwmon-next
Merging quilt/kernel-doc
Merging docs/docs-move
Merging v4l-dvb/master
Merging kbuild/for-next
Merging kconfig/for-next
Merging ide/master
Merging libata/NEXT
Merging infiniband/for-next
Merging acpi/test
Merging idle-test/idle-test
Merging powertools/tools-test
Merging cpupowerutils/master
Merging ieee1394/for-next
Merging ubi/linux-next
Merging dlm/next
Merging swiotlb/master
Merging ibft/master
Merging scsi/master
Merging iscsi-target/for-next
Merging slave-dma/next
Merging async_tx/next
Merging net/master
CONFLICT (delete/modify): arch/powerpc/configs/40x/hcu4_defconfig deleted in HEAD and modified in net/master. Version net/master of arch/powerpc/configs/40x/hcu4_defconfig left in tree.
$ git rm -f arch/powerpc/configs/40x/hcu4_defconfig
Applying: powerpc: update ppc64_defconfig for net device movement
Merging wireless/master
CONFLICT (delete/modify): drivers/staging/ath6kl/miscdrv/ar3kps/ar3kpsparser.c deleted in wireless/master and modified in HEAD. Version HEAD of drivers/staging/ath6kl/miscdrv/ar3kps/ar3kpsparser.c left in tree.
CONFLICT (delete/modify): drivers/staging/ath6kl/os/linux/ar6000_drv.c deleted in wireless/master and modified in HEAD. Version HEAD of drivers/staging/ath6kl/os/linux/ar6000_drv.c left in tree.
$ git rm -f drivers/staging/ath6kl/miscdrv/ar3kps/ar3kpsparser.c
$ git rm -f drivers/staging/ath6kl/os/linux/ar6000_drv.c
Merging bluetooth/master
Merging mtd/master
Merging l2-mtd/master
CONFLICT (content): Merge conflict in drivers/mtd/maps/lantiq-flash.c
Merging crypto/master
Merging sound/for-next
Merging sound-asoc/for-next
Merging cpufreq/next
Merging quilt/rr
Merging input/next
Merging input-mt/next
Merging lsm/for-next
Merging block/for-next
Merging quilt/device-mapper
Merging embedded/master
Merging firmware/master
Merging pcmcia/master
Merging battery/master
Merging leds/for-mm
CONFLICT (content): Merge conflict in drivers/leds/Kconfig
Merging backlight/for-mm
Merging mmc/mmc-next
Merging kgdb/kgdb-next
Merging slab/for-next
Merging uclinux/for-next
Merging md/for-next
Merging mfd/for-next
Merging hdlc/hdlc-next
Merging drm/drm-next
Merging fbdev/master
Merging viafb/viafb-next
Merging omap_dss2/for-next
Merging voltage/for-next
Merging security/next
Merging selinux/master
Merging lblnet/master
Merging agp/agp-next
Merging watchdog/master
Merging bdev/master
Merging dwmw2-iommu/master
Merging cputime/cputime
Merging osd/linux-next
Merging jc_docs/docs-next
Merging nommu/master
Merging trivial/for-next
Merging audit/for-next
Merging pm/linux-next
CONFLICT (content): Merge conflict in arch/s390/include/asm/thread_info.h
Merging apm/for-next
Merging fsnotify/for-next
Merging irda/for-next
Merging i7core_edac/linux_next
Merging i7300_edac/linux_next
CONFLICT (content): Merge conflict in arch/x86/kernel/cpu/mcheck/mce.c
Merging devicetree/devicetree/next
CONFLICT (content): Merge conflict in drivers/of/base.c
Merging spi/spi/next
Merging gpio/gpio/next
Merging tip/auto-latest
CONFLICT (content): Merge conflict in arch/x86/mm/fault.c
Merging rcu/rcu/next
Merging kvm/linux-next
Merging oprofile/for-next
Merging ptrace/ptrace
Merging xen/upstream/xen
CONFLICT (content): Merge conflict in arch/x86/xen/Makefile
Merging xen-two/linux-next
Merging xen-pvhvm/linux-next
Merging edac-amd/for-next
Merging percpu/for-next
Merging workqueues/for-next
Merging sfi/sfi-test
Merging asm-generic/next
Merging drivers-x86/linux-next
Merging hwpoison/hwpoison
Merging sysctl/master
Merging namespace/master
Merging regmap/for-next
Merging driver-core/driver-core-next
Merging tty/tty-next
Merging usb/usb-next
Merging staging/staging-next
Merging bkl-config/config
Merging tmem/linux-next
Merging writeback/next
Merging arm-dt/devicetree/arm-next
Merging scsi-post-merge/merge-base:master
Merging moduleh/module.h-split
CONFLICT (content): Merge conflict in include/linux/dmaengine.h
Applying: dm: use export.h instead of module.h where possible
Applying: block: bsg-lib.c needs export.h not module.h
Applying: PM: EXPORT_SYMBOL needs export.h
$ git checkout akpm
Applying: Expand root=PARTUUID=UUID syntax to support selecting a root partition by
Applying: This patch makes two changes:
Applying: On thread exit shm_exit_ns() is called, it uses shm_ids(ns).rw_mutex.  It
Applying: Because of x86-implement-strict-user-copy-checks-for-x86_64.patch
Applying: When no floppy is found the module code can be released while a timer
Applying: The parameter's origin type is long.  On an i386 architecture, it can
Applying: Add support for Aspire 1410 BIOS v1.3314.  Fixes the following error:
Applying: This makes the iris driver use the platform API, so it is properly exposed
Applying: On x86_32 casting the unsigned int result of get_random_int() to long may
Applying: This new driver replaces the old PCEngines Alix 2/3 LED driver with a new
Applying: Cc: Ed Wildgoose <git@wildgooses.com>
Applying: Replace the bubble sort in sanitize_e820_map() with a call to the generic
Applying: The x86 timer interrupt handler is the only handler not traced in the
Applying: The current interrupt traces from irq_handler_entry and irq_handler_exit
Applying: Don't allow everybody to use a modem.
Applying: The address limit is already set in flush_old_exec() so this
Applying: A call to va_copy() should always be followed by a call to va_end() in the
Applying: Don't dereference em if it's NULL or an error pointer.
Applying: Some messing with error codes to return 0 on out id's and match
Applying: fb_set_suspend() must be called with the console semaphore held, which
Applying: hwmon was using an idr with a NULL pointer, so convert to an
Applying: A straightforward looking use of idr for a device id.
Applying: The address limit is already set in flush_old_exec() so this
Applying: The address limit is already set in flush_old_exec() so this
Applying: Add new check (assert_init) to make sure objects are initialized and
Applying: del_timer_sync() calls debug_object_assert_init() to assert that a timer
Applying: ext4_{set,clear}_bit() is defined as __test_and_{set,clear}_bit_le() for
Applying: The dqc_bitmap field of struct ocfs2_local_disk_chunk is 32-bit aligned,
Applying: The address limit is already set in flush_old_exec() so those calls to
Applying: When do pci remove/rescan on system that have more iommus, got
Applying: The current implementation of dmi_name_in_vendors() is an invitation to
Applying: For headers that get exported to userland and make use of u32 style
Applying: Fix sparse warnings of right shift bigger than source value size:
Applying: We leak in drivers/scsi/aacraid/commctrl.c::aac_send_raw_srb() :
Applying: Some mangling of errors was necessary to maintain current interface.
Applying: This does involve additional use of the spin lock in idr.c.  Is this an
Applying: Instead of open coding this function use kstrtoul_from_user() directly.
Applying: brd_make_request() always returns 0, which doesn't make much sense.
Applying: The address limit is already set in flush_old_exec() so this assignment of
Applying: The basic idea behind cross memory attach is to allow MPI programs doing
Applying: - Add x86_64 specific wire up
Applying: acct_isolated of compaction uses page_lru_base_type which returns only
Applying: Change ISOLATE_XXX macro with bitwise isolate_mode_t type.  Normally,
Applying: In async mode, compaction doesn't migrate dirty or writeback pages.  So,
Applying: In __zone_reclaim case, we don't want to shrink mapped page.  Nonetheless,
Applying: unmap_and_move() is one a big messy function.  Clean it up.
Applying: radix_tree_tag_get()'s BUG (when it sees a tag after saw_unset_tag) was
Applying: per-task block plug can reduce block queue lock contention and increase
Applying: The tracing ring-buffer used this function briefly, but not anymore.
Applying: After selecting a task to kill, the oom killer iterates all processes and
Applying: Remove PageSwapBacked (!page_is_file_cache) cases from
Applying: Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Applying: The current implementation of the /dev/hpet driver couples opening the
Applying: smp_call_function() only lets all other CPUs execute a specific function,
Applying: auto_demotion_disable is called only for online CPUs.  For hotplugged
Applying: Enabling DEBUG_STRICT_USER_COPY_CHECKS causes the following warning:
Applying: Strict user copy checks are only really supported on x86_32 even though
Applying: The help text for this config is duplicated across the x86, parisc, and
Applying: s/lib-/obj-/ for usercopy.o
Applying: After an "unexpected" reboot, I found this Oops in my logs:
Applying: In the move of the lis3 driver, the hp_accel.c file got dropped from the
Applying: Add axis correction for HP EliteBook 2730p.
Applying: Add axis correction for HP EliteBook 8540w.
Applying: Add axis correction for HP ProBook 6555b.
Applying: Adapt the help text for CONFIG_HP_ACCEL to the move of
Applying: Signed-off-by: Ilkka Koskinen <ilkka.koskinen@nokia.com>
Applying: Signed-off-by: Ilkka Koskinen <ilkka.koskinen@nokia.com>
Applying: Change exported functions to use the device given as parameter
Applying: Signed-off-by: Ilkka Koskinen <ilkka.koskinen@nokia.com>
Applying: Add V2 of the LED driver for a single timer channel for the TPU hardware
Applying: Add support for slice by 8 to existing crc32 algorithm.  Also modify
Applying: don't include asm/msr.h
Applying: This is the one use of an ida that doesn't retry on receiving -EAGAIN.
Applying: One can get this information from minix/inode.c, but adding the
Applying: Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Applying: Force this on for -next/mm testing purposes.
Applying: Add a proc_dointvec_bool() sysctl handler for cases where the input value
Applying: Use the new proc_do_intvec_bool() handler for various boolean inputs.
Applying: Add a proc_dointvec_unsigned() sysctl handler for positive value cases.
Applying: Cc: Alexey Dobriyan <adobriyan@gmail.com>
Applying: Use the new proc_do_intvec_unsigned() handler for various unsigned inputs.
Applying: A default echo function has been provided so it is no longer an error when
Applying: This client driver allows you to use a GPIO pin as a source for PPS
Applying: remove unneeded cast of void*
Applying: Straightforward.  As an aside, the ida_init calls are not needed as far as
Merging akpm
Applying: do_mounts: remove __init_data from root_wait

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: Tree for Aug 22 (drivers/power/pda_power.c)

[Randy Dunlap]

On Mon, 22 Aug 2011 14:53:04 +1000 Stephen Rothwell wrote:

> Hi all,
> 
> [The kernel.org mirroring is a bit low today]


When CONFIG_USB_OTG_UTILS is not enabled:

drivers/power/pda_power.c: In function 'pda_power_probe':
drivers/power/pda_power.c:322: error: 'otg_is_usb_online' undeclared (first use in this function)
drivers/power/pda_power.c:322: error: (Each undeclared identifier is reported only once
drivers/power/pda_power.c:322: error: for each function it appears in.)
drivers/power/pda_power.c:325: error: 'otg_is_ac_online' undeclared (first use in this function)
drivers/power/pda_power.c:371: error: 'otg_handle_notification' undeclared (first use in this function)

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

[PATCH -next] staging: fix comedi build when COMEDI_PCI is not enabled

[Randy Dunlap]

From: Randy Dunlap <rdunlap@xenotime.net>

Fix build when CONFIG_ISA_DMA_API is enabled but
CONFIG_COMEDI_PCI[_DRIVERS] is not enabled.
Fixes these build errors:

drivers/staging/comedi/drivers/ni_labpc.c: In function 'labpc_ai_cmd':
drivers/staging/comedi/drivers/ni_labpc.c:1351: error: implicit declaration of function 'labpc_suggest_transfer_size'
drivers/staging/comedi/drivers/ni_labpc.c: At top level:
drivers/staging/comedi/drivers/ni_labpc.c:1802: error: conflicting types for 'labpc_suggest_transfer_size'
drivers/staging/comedi/drivers/ni_labpc.c:1351: note: previous implicit declaration of 'labpc_suggest_transfer_size' was here

Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
---
 drivers/staging/comedi/drivers/ni_labpc.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

--- linux-next-20110822.orig/drivers/staging/comedi/drivers/ni_labpc.c
+++ linux-next-20110822/drivers/staging/comedi/drivers/ni_labpc.c
@@ -241,8 +241,10 @@ static int labpc_eeprom_write_insn(struc
 				   struct comedi_insn *insn,
 				   unsigned int *data);
 static void labpc_adc_timing(struct comedi_device *dev, struct comedi_cmd *cmd);
-#ifdef CONFIG_COMEDI_PCI
+#ifdef CONFIG_ISA_DMA_API
 static unsigned int labpc_suggest_transfer_size(struct comedi_cmd cmd);
+#endif
+#ifdef CONFIG_COMEDI_PCI
 static int labpc_find_device(struct comedi_device *dev, int bus, int slot);
 #endif
 static int labpc_dio_mem_callback(int dir, int port, int data,

[PATCH -next] power_supply: fix sysfs format warning

[Randy Dunlap]

From: Randy Dunlap <rdunlap@xenotime.net>

Fix format warning:

drivers/power/power_supply_sysfs.c:82: warning: format '%d' expects type 'int', but argument 4 has type 'ssize_t'

Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
---
 drivers/power/power_supply_sysfs.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20110822.orig/drivers/power/power_supply_sysfs.c
+++ linux-next-20110822/drivers/power/power_supply_sysfs.c
@@ -78,7 +78,7 @@ static ssize_t power_supply_show_propert
 			dev_dbg(dev, "driver has no data for `%s' property\n",
 				attr->attr.name);
 		else if (ret != -ENODEV)
-			dev_err(dev, "driver failed to report `%s' property: %d\n",
+			dev_err(dev, "driver failed to report `%s' property: %zd\n",
 				attr->attr.name, ret);
 		return ret;
 	}

Re: linux-next: Tree for Aug 22 (evm)

[Randy Dunlap]

On Mon, 22 Aug 2011 14:53:04 +1000 Stephen Rothwell wrote:

> Hi all,
> 
> [The kernel.org mirroring is a bit low today]

(on x86_64:)

When CONFIG_EVM=y, CONFIG_CRYPTO_HASH2=m, CONFIG_TRUSTED_KEYS=m,
CONFIG_ENCRYPTED_KEYS=m, the build fails with:

(.text+0x378aa): undefined reference to `key_type_encrypted'
evm_crypto.c:(.text+0x37992): undefined reference to `crypto_alloc_shash'
evm_crypto.c:(.text+0x37a24): undefined reference to `crypto_shash_setkey'
evm_crypto.c:(.text+0x37ad9): undefined reference to `crypto_shash_update'
evm_crypto.c:(.text+0x37aeb): undefined reference to `crypto_shash_final'
(.text+0x37b4b): undefined reference to `crypto_shash_update'
(.text+0x37c61): undefined reference to `crypto_shash_update'
(.text+0x37cb9): undefined reference to `crypto_shash_update'

even though EVM (Kconfig) selects ENCRYPTED_KEYS and TRUSTED_KEYS..
and even after I add "select CRYPTO_HASH2".

Is this because EVM is bool and kconfig is confused about 'select's
when a bool is selecting tristates?  Shouldn't the tristates become
'y' instead of 'm' if they are selected by a bool that is 'y'?


xconfig shows these symbol values:

Symbol: EVM [=y]
Type : boolean
Prompt: EVM support
Defined at security/integrity/evm/Kconfig:1
Depends on: SECURITY [=y] && KEYS [=y] && TCG_TPM [=m]
Location:
-> Security options
Selects: CRYPTO_HMAC [=m] && CRYPTO_MD5 [=m] && CRYPTO_SHA1 [=m] && CRYPTO_HASH2 [=m] && ENCRYPTED_KEYS [=m] && TRUSTED_KEYS [=m]


Hm, changing TCG_TPM to =y also changes TRUSTED_KEYS and ENCRYPTED_KEYS and
lots of CRYPTO_ symbols from =m to =y.  There must be some kind of min/max
symbol checking that is confused?

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

Re: linux-next: Tree for Aug 22 (evm)

[Arnaud Lacombe]

Hi,

On Mon, Aug 22, 2011 at 3:53 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
> On Mon, 22 Aug 2011 14:53:04 +1000 Stephen Rothwell wrote:
>
>> Hi all,
>>
>> [The kernel.org mirroring is a bit low today]
>
> (on x86_64:)
>
> When CONFIG_EVM=y, CONFIG_CRYPTO_HASH2=m, CONFIG_TRUSTED_KEYS=m,
> CONFIG_ENCRYPTED_KEYS=m, the build fails with:
>
> (.text+0x378aa): undefined reference to `key_type_encrypted'
> evm_crypto.c:(.text+0x37992): undefined reference to `crypto_alloc_shash'
> evm_crypto.c:(.text+0x37a24): undefined reference to `crypto_shash_setkey'
> evm_crypto.c:(.text+0x37ad9): undefined reference to `crypto_shash_update'
> evm_crypto.c:(.text+0x37aeb): undefined reference to `crypto_shash_final'
> (.text+0x37b4b): undefined reference to `crypto_shash_update'
> (.text+0x37c61): undefined reference to `crypto_shash_update'
> (.text+0x37cb9): undefined reference to `crypto_shash_update'
>
> even though EVM (Kconfig) selects ENCRYPTED_KEYS and TRUSTED_KEYS..
> and even after I add "select CRYPTO_HASH2".
>
> Is this because EVM is bool and kconfig is confused about 'select's
> when a bool is selecting tristates?  Shouldn't the tristates become
> 'y' instead of 'm' if they are selected by a bool that is 'y'?
>
hum, I'd say that it should:

% cat Kconfig
config MOD
        bool
        default y
        option modules

config B
        tristate "B"
        default m

config A
        tristate "A"
        default y
        select B

% make alldefconfig
scripts/kconfig/conf --alldefconfig Kconfig
#
# configuration written to .config
#

% cat .config
#
# Automatically generated file; DO NOT EDIT.
# Linux Kernel Configuration
#
CONFIG_MOD=y
CONFIG_B=y
CONFIG_A=y

now, if A defaults to 'm', we have:

% cat .config
#
# Automatically generated file; DO NOT EDIT.
# Linux Kernel Configuration
#
CONFIG_MOD=y
CONFIG_B=m
CONFIG_A=m

Could you please produce a reduced testcase showing the problem ?

Thanks,
 - Arnaud

>
> xconfig shows these symbol values:
>
> Symbol: EVM [=y]
> Type : boolean
> Prompt: EVM support
> Defined at security/integrity/evm/Kconfig:1
> Depends on: SECURITY [=y] && KEYS [=y] && TCG_TPM [=m]
> Location:
> -> Security options
> Selects: CRYPTO_HMAC [=m] && CRYPTO_MD5 [=m] && CRYPTO_SHA1 [=m] && CRYPTO_HASH2 [=m] && ENCRYPTED_KEYS [=m] && TRUSTED_KEYS [=m]
>
>
> Hm, changing TCG_TPM to =y also changes TRUSTED_KEYS and ENCRYPTED_KEYS and
> lots of CRYPTO_ symbols from =m to =y.  There must be some kind of min/max
> symbol checking that is confused?
>
> ---
> ~Randy
> *** Remember to use Documentation/SubmitChecklist when testing your code ***
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Re: linux-next: Tree for Aug 22 (evm)

[Arnaud Lacombe]

Hi,

On Mon, Aug 22, 2011 at 3:53 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
> On Mon, 22 Aug 2011 14:53:04 +1000 Stephen Rothwell wrote:
>
>> Hi all,
>>
>> [The kernel.org mirroring is a bit low today]
>
> (on x86_64:)
>
> When CONFIG_EVM=y, CONFIG_CRYPTO_HASH2=m, CONFIG_TRUSTED_KEYS=m,
> CONFIG_ENCRYPTED_KEYS=m, the build fails with:
>
You did not provide the value of CONFIG_TCG_TPM, I'll assume it was
'm'. That said, correct me if I'm wrong, but we currently have:

menuconfig TCG_TPM
        tristate "TPM Hardware Support"

[...]

config EVM
        boolean "EVM support"
        depends on SECURITY && KEYS && TCG_TPM

which seems terribly broken to me... How can you have a built-in
feature, which depends on another potentially-not-built-in feature ?

If you change EVM to 'tristate', you will see that you are not allowed
to make it built-in if TCG_TPM is not built-in.

 - Arnaud

> (.text+0x378aa): undefined reference to `key_type_encrypted'
> evm_crypto.c:(.text+0x37992): undefined reference to `crypto_alloc_shash'
> evm_crypto.c:(.text+0x37a24): undefined reference to `crypto_shash_setkey'
> evm_crypto.c:(.text+0x37ad9): undefined reference to `crypto_shash_update'
> evm_crypto.c:(.text+0x37aeb): undefined reference to `crypto_shash_final'
> (.text+0x37b4b): undefined reference to `crypto_shash_update'
> (.text+0x37c61): undefined reference to `crypto_shash_update'
> (.text+0x37cb9): undefined reference to `crypto_shash_update'
>
> even though EVM (Kconfig) selects ENCRYPTED_KEYS and TRUSTED_KEYS..
> and even after I add "select CRYPTO_HASH2".
>
> Is this because EVM is bool and kconfig is confused about 'select's
> when a bool is selecting tristates?  Shouldn't the tristates become
> 'y' instead of 'm' if they are selected by a bool that is 'y'?
>
>
> xconfig shows these symbol values:
>
> Symbol: EVM [=y]
> Type : boolean
> Prompt: EVM support
> Defined at security/integrity/evm/Kconfig:1
> Depends on: SECURITY [=y] && KEYS [=y] && TCG_TPM [=m]
> Location:
> -> Security options
> Selects: CRYPTO_HMAC [=m] && CRYPTO_MD5 [=m] && CRYPTO_SHA1 [=m] && CRYPTO_HASH2 [=m] && ENCRYPTED_KEYS [=m] && TRUSTED_KEYS [=m]
>
>
> Hm, changing TCG_TPM to =y also changes TRUSTED_KEYS and ENCRYPTED_KEYS and
> lots of CRYPTO_ symbols from =m to =y.  There must be some kind of min/max
> symbol checking that is confused?
>
there is definitively an underlying min/max, but I would not point
finger too fast.

> ---
> ~Randy
> *** Remember to use Documentation/SubmitChecklist when testing your code ***
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Re: linux-next: Tree for Aug 22 (evm)

[Randy Dunlap]

On Mon, 22 Aug 2011 20:47:00 -0400 Arnaud Lacombe wrote:

> Hi,
> 
> On Mon, Aug 22, 2011 at 3:53 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
> > On Mon, 22 Aug 2011 14:53:04 +1000 Stephen Rothwell wrote:
> >
> >> Hi all,
> >>
> >> [The kernel.org mirroring is a bit low today]
> >
> > (on x86_64:)
> >
> > When CONFIG_EVM=y, CONFIG_CRYPTO_HASH2=m, CONFIG_TRUSTED_KEYS=m,
> > CONFIG_ENCRYPTED_KEYS=m, the build fails with:
> >
> You did not provide the value of CONFIG_TCG_TPM, I'll assume it was
> 'm'. That said, correct me if I'm wrong, but we currently have:

Yes, it was 'm'.

> menuconfig TCG_TPM
>         tristate "TPM Hardware Support"
> 
> [...]
> 
> config EVM
>         boolean "EVM support"
>         depends on SECURITY && KEYS && TCG_TPM
> 
> which seems terribly broken to me... How can you have a built-in
> feature, which depends on another potentially-not-built-in feature ?

Yup.

> If you change EVM to 'tristate', you will see that you are not allowed
> to make it built-in if TCG_TPM is not built-in.

Right.

>  - Arnaud
> 
> > (.text+0x378aa): undefined reference to `key_type_encrypted'
> > evm_crypto.c:(.text+0x37992): undefined reference to `crypto_alloc_shash'
> > evm_crypto.c:(.text+0x37a24): undefined reference to `crypto_shash_setkey'
> > evm_crypto.c:(.text+0x37ad9): undefined reference to `crypto_shash_update'
> > evm_crypto.c:(.text+0x37aeb): undefined reference to `crypto_shash_final'
> > (.text+0x37b4b): undefined reference to `crypto_shash_update'
> > (.text+0x37c61): undefined reference to `crypto_shash_update'
> > (.text+0x37cb9): undefined reference to `crypto_shash_update'
> >
> > even though EVM (Kconfig) selects ENCRYPTED_KEYS and TRUSTED_KEYS..
> > and even after I add "select CRYPTO_HASH2".
> >
> > Is this because EVM is bool and kconfig is confused about 'select's
> > when a bool is selecting tristates?  Shouldn't the tristates become
> > 'y' instead of 'm' if they are selected by a bool that is 'y'?
> >
> >
> > xconfig shows these symbol values:
> >
> > Symbol: EVM [=y]
> > Type : boolean
> > Prompt: EVM support
> > Defined at security/integrity/evm/Kconfig:1
> > Depends on: SECURITY [=y] && KEYS [=y] && TCG_TPM [=m]
> > Location:
> > -> Security options
> > Selects: CRYPTO_HMAC [=m] && CRYPTO_MD5 [=m] && CRYPTO_SHA1 [=m] && CRYPTO_HASH2 [=m] && ENCRYPTED_KEYS [=m] && TRUSTED_KEYS [=m]
> >
> >
> > Hm, changing TCG_TPM to =y also changes TRUSTED_KEYS and ENCRYPTED_KEYS and
> > lots of CRYPTO_ symbols from =m to =y.  There must be some kind of min/max
> > symbol checking that is confused?
> >
> there is definitively an underlying min/max, but I would not point
> finger too fast.


Thanks for your help.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

Re: linux-next: Tree for Aug 22 (evm)

[Mimi Zohar]

On Mon, 2011-08-22 at 17:49 -0700, Randy Dunlap wrote:
> On Mon, 22 Aug 2011 20:47:00 -0400 Arnaud Lacombe wrote:
> 
> > Hi,
> > 
> > On Mon, Aug 22, 2011 at 3:53 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
> > > On Mon, 22 Aug 2011 14:53:04 +1000 Stephen Rothwell wrote:
> > >
> > >> Hi all,
> > >>
> > >> [The kernel.org mirroring is a bit low today]
> > >
> > > (on x86_64:)
> > >
> > > When CONFIG_EVM=y, CONFIG_CRYPTO_HASH2=m, CONFIG_TRUSTED_KEYS=m,
> > > CONFIG_ENCRYPTED_KEYS=m, the build fails with:
> > >
> > You did not provide the value of CONFIG_TCG_TPM, I'll assume it was
> > 'm'. That said, correct me if I'm wrong, but we currently have:
> 
> Yes, it was 'm'.
> 
> > menuconfig TCG_TPM
> >         tristate "TPM Hardware Support"
> > 
> > [...]
> > 
> > config EVM
> >         boolean "EVM support"
> >         depends on SECURITY && KEYS && TCG_TPM
> > 
> > which seems terribly broken to me... How can you have a built-in
> > feature, which depends on another potentially-not-built-in feature ?
> 
> Yup.

Easy, different use cases. The TPM has been around and used for a while,
not requiring it to be built-in.  EVM, a new use case, requires it to be
built-in.

> > If you change EVM to 'tristate', you will see that you are not allowed
> > to make it built-in if TCG_TPM is not built-in.
> 
> Right.

The TPM, crypto, trusted and encrypted keys are tristate.  Like the
LSMs, EVM is boolean, which when selected using 'make xconfig', converts
the tristates to built-in.  The tristate/boolean mismatches aren't
corrected, when .config is edited directly.

Mimi

> >  - Arnaud
> > 
> > > (.text+0x378aa): undefined reference to `key_type_encrypted'
> > > evm_crypto.c:(.text+0x37992): undefined reference to `crypto_alloc_shash'
> > > evm_crypto.c:(.text+0x37a24): undefined reference to `crypto_shash_setkey'
> > > evm_crypto.c:(.text+0x37ad9): undefined reference to `crypto_shash_update'
> > > evm_crypto.c:(.text+0x37aeb): undefined reference to `crypto_shash_final'
> > > (.text+0x37b4b): undefined reference to `crypto_shash_update'
> > > (.text+0x37c61): undefined reference to `crypto_shash_update'
> > > (.text+0x37cb9): undefined reference to `crypto_shash_update'
> > >
> > > even though EVM (Kconfig) selects ENCRYPTED_KEYS and TRUSTED_KEYS..
> > > and even after I add "select CRYPTO_HASH2".
> > >
> > > Is this because EVM is bool and kconfig is confused about 'select's
> > > when a bool is selecting tristates?  Shouldn't the tristates become
> > > 'y' instead of 'm' if they are selected by a bool that is 'y'?
> > >
> > >
> > > xconfig shows these symbol values:
> > >
> > > Symbol: EVM [=y]
> > > Type : boolean
> > > Prompt: EVM support
> > > Defined at security/integrity/evm/Kconfig:1
> > > Depends on: SECURITY [=y] && KEYS [=y] && TCG_TPM [=m]
> > > Location:
> > > -> Security options
> > > Selects: CRYPTO_HMAC [=m] && CRYPTO_MD5 [=m] && CRYPTO_SHA1 [=m] && CRYPTO_HASH2 [=m] && ENCRYPTED_KEYS [=m] && TRUSTED_KEYS [=m]
> > >
> > >
> > > Hm, changing TCG_TPM to =y also changes TRUSTED_KEYS and ENCRYPTED_KEYS and
> > > lots of CRYPTO_ symbols from =m to =y.  There must be some kind of min/max
> > > symbol checking that is confused?
> > >
> > there is definitively an underlying min/max, but I would not point
> > finger too fast.
> 
> 
> Thanks for your help.
> 
> ---
> ~Randy
> *** Remember to use Documentation/SubmitChecklist when testing your code ***

Re: linux-next: Tree for Aug 22 (evm)

[Arnaud Lacombe]

Hi,

On Mon, Aug 22, 2011 at 10:09 PM, Mimi Zohar <zohar@linux.vnet.ibm.com> wrote:
> On Mon, 2011-08-22 at 17:49 -0700, Randy Dunlap wrote:
>> On Mon, 22 Aug 2011 20:47:00 -0400 Arnaud Lacombe wrote:
>>
>> > Hi,
>> >
>> > On Mon, Aug 22, 2011 at 3:53 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
>> > > On Mon, 22 Aug 2011 14:53:04 +1000 Stephen Rothwell wrote:
>> > >
>> > >> Hi all,
>> > >>
>> > >> [The kernel.org mirroring is a bit low today]
>> > >
>> > > (on x86_64:)
>> > >
>> > > When CONFIG_EVM=y, CONFIG_CRYPTO_HASH2=m, CONFIG_TRUSTED_KEYS=m,
>> > > CONFIG_ENCRYPTED_KEYS=m, the build fails with:
>> > >
>> > You did not provide the value of CONFIG_TCG_TPM, I'll assume it was
>> > 'm'. That said, correct me if I'm wrong, but we currently have:
>>
>> Yes, it was 'm'.
>>
>> > menuconfig TCG_TPM
>> >         tristate "TPM Hardware Support"
>> >
>> > [...]
>> >
>> > config EVM
>> >         boolean "EVM support"
>> >         depends on SECURITY && KEYS && TCG_TPM
>> >
>> > which seems terribly broken to me... How can you have a built-in
>> > feature, which depends on another potentially-not-built-in feature ?
>>
>> Yup.
>
> Easy, different use cases. The TPM has been around and used for a while,
> not requiring it to be built-in.  EVM, a new use case, requires it to be
> built-in.
>
What behavior is expected when TPM is built as a module ? Would you
expect EVM to be accessible ?

>> > If you change EVM to 'tristate', you will see that you are not allowed
>> > to make it built-in if TCG_TPM is not built-in.
>>
>> Right.
>
> The TPM, crypto, trusted and encrypted keys are tristate.  Like the
> LSMs, EVM is boolean, which when selected using 'make xconfig', converts
> the tristates to built-in.  The tristate/boolean mismatches aren't
> corrected, when .config is edited directly.
>
well, ... no. 'xconfig' would seem to let you think they have been
changed to 'y', but they have not. I have been able to generate a bad
configuration (TPM module, EVM built-in) using only {menu,x}config.

btw, I never edit the configuration manually, there is a big fat "DO
NOT EDIT" header in the beginning.

Depending on what you expect, one way to fix that is to make EVM
depends on TCG_TPM = y, not just TCG_TPM.

 - Arnaud

> Mimi
>
>> >  - Arnaud
>> >
>> > > (.text+0x378aa): undefined reference to `key_type_encrypted'
>> > > evm_crypto.c:(.text+0x37992): undefined reference to `crypto_alloc_shash'
>> > > evm_crypto.c:(.text+0x37a24): undefined reference to `crypto_shash_setkey'
>> > > evm_crypto.c:(.text+0x37ad9): undefined reference to `crypto_shash_update'
>> > > evm_crypto.c:(.text+0x37aeb): undefined reference to `crypto_shash_final'
>> > > (.text+0x37b4b): undefined reference to `crypto_shash_update'
>> > > (.text+0x37c61): undefined reference to `crypto_shash_update'
>> > > (.text+0x37cb9): undefined reference to `crypto_shash_update'
>> > >
>> > > even though EVM (Kconfig) selects ENCRYPTED_KEYS and TRUSTED_KEYS..
>> > > and even after I add "select CRYPTO_HASH2".
>> > >
>> > > Is this because EVM is bool and kconfig is confused about 'select's
>> > > when a bool is selecting tristates?  Shouldn't the tristates become
>> > > 'y' instead of 'm' if they are selected by a bool that is 'y'?
>> > >
>> > >
>> > > xconfig shows these symbol values:
>> > >
>> > > Symbol: EVM [=y]
>> > > Type : boolean
>> > > Prompt: EVM support
>> > > Defined at security/integrity/evm/Kconfig:1
>> > > Depends on: SECURITY [=y] && KEYS [=y] && TCG_TPM [=m]
>> > > Location:
>> > > -> Security options
>> > > Selects: CRYPTO_HMAC [=m] && CRYPTO_MD5 [=m] && CRYPTO_SHA1 [=m] && CRYPTO_HASH2 [=m] && ENCRYPTED_KEYS [=m] && TRUSTED_KEYS [=m]
>> > >
>> > >
>> > > Hm, changing TCG_TPM to =y also changes TRUSTED_KEYS and ENCRYPTED_KEYS and
>> > > lots of CRYPTO_ symbols from =m to =y.  There must be some kind of min/max
>> > > symbol checking that is confused?
>> > >
>> > there is definitively an underlying min/max, but I would not point
>> > finger too fast.
>>
>>
>> Thanks for your help.
>>
>> ---
>> ~Randy
>> *** Remember to use Documentation/SubmitChecklist when testing your code ***
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Re: linux-next: Tree for Aug 22 (evm)

[Arnaud Lacombe]

Hi,

On Mon, Aug 22, 2011 at 10:09 PM, Mimi Zohar <zohar@linux.vnet.ibm.com> wrote:
> On Mon, 2011-08-22 at 17:49 -0700, Randy Dunlap wrote:
>> On Mon, 22 Aug 2011 20:47:00 -0400 Arnaud Lacombe wrote:
>>
>> > Hi,
>> >
>> > On Mon, Aug 22, 2011 at 3:53 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
>> > > On Mon, 22 Aug 2011 14:53:04 +1000 Stephen Rothwell wrote:
>> > >
>> > >> Hi all,
>> > >>
>> > >> [The kernel.org mirroring is a bit low today]
>> > >
>> > > (on x86_64:)
>> > >
>> > > When CONFIG_EVM=y, CONFIG_CRYPTO_HASH2=m, CONFIG_TRUSTED_KEYS=m,
>> > > CONFIG_ENCRYPTED_KEYS=m, the build fails with:
>> > >
>> > You did not provide the value of CONFIG_TCG_TPM, I'll assume it was
>> > 'm'. That said, correct me if I'm wrong, but we currently have:
>>
>> Yes, it was 'm'.
>>
>> > menuconfig TCG_TPM
>> >         tristate "TPM Hardware Support"
>> >
>> > [...]
>> >
>> > config EVM
>> >         boolean "EVM support"
>> >         depends on SECURITY && KEYS && TCG_TPM
>> >
>> > which seems terribly broken to me... How can you have a built-in
>> > feature, which depends on another potentially-not-built-in feature ?
>>
>> Yup.
>
> Easy, different use cases. The TPM has been around and used for a while,
> not requiring it to be built-in.  EVM, a new use case, requires it to be
> built-in.
>
sorry, I think I misunderstood that last sentence. I assumed the 'it'
was referring to EVM, while taken in context with the previous
sentence, it might as well refers to TPM, in which case you want EVM
to 'depends on TCG_TPM = y'.

 - Arnaud

>> > If you change EVM to 'tristate', you will see that you are not allowed
>> > to make it built-in if TCG_TPM is not built-in.
>>
>> Right.
>
> The TPM, crypto, trusted and encrypted keys are tristate.  Like the
> LSMs, EVM is boolean, which when selected using 'make xconfig', converts
> the tristates to built-in.  The tristate/boolean mismatches aren't
> corrected, when .config is edited directly.
>
> Mimi
>
>> >  - Arnaud
>> >
>> > > (.text+0x378aa): undefined reference to `key_type_encrypted'
>> > > evm_crypto.c:(.text+0x37992): undefined reference to `crypto_alloc_shash'
>> > > evm_crypto.c:(.text+0x37a24): undefined reference to `crypto_shash_setkey'
>> > > evm_crypto.c:(.text+0x37ad9): undefined reference to `crypto_shash_update'
>> > > evm_crypto.c:(.text+0x37aeb): undefined reference to `crypto_shash_final'
>> > > (.text+0x37b4b): undefined reference to `crypto_shash_update'
>> > > (.text+0x37c61): undefined reference to `crypto_shash_update'
>> > > (.text+0x37cb9): undefined reference to `crypto_shash_update'
>> > >
>> > > even though EVM (Kconfig) selects ENCRYPTED_KEYS and TRUSTED_KEYS..
>> > > and even after I add "select CRYPTO_HASH2".
>> > >
>> > > Is this because EVM is bool and kconfig is confused about 'select's
>> > > when a bool is selecting tristates?  Shouldn't the tristates become
>> > > 'y' instead of 'm' if they are selected by a bool that is 'y'?
>> > >
>> > >
>> > > xconfig shows these symbol values:
>> > >
>> > > Symbol: EVM [=y]
>> > > Type : boolean
>> > > Prompt: EVM support
>> > > Defined at security/integrity/evm/Kconfig:1
>> > > Depends on: SECURITY [=y] && KEYS [=y] && TCG_TPM [=m]
>> > > Location:
>> > > -> Security options
>> > > Selects: CRYPTO_HMAC [=m] && CRYPTO_MD5 [=m] && CRYPTO_SHA1 [=m] && CRYPTO_HASH2 [=m] && ENCRYPTED_KEYS [=m] && TRUSTED_KEYS [=m]
>> > >
>> > >
>> > > Hm, changing TCG_TPM to =y also changes TRUSTED_KEYS and ENCRYPTED_KEYS and
>> > > lots of CRYPTO_ symbols from =m to =y.  There must be some kind of min/max
>> > > symbol checking that is confused?
>> > >
>> > there is definitively an underlying min/max, but I would not point
>> > finger too fast.
>>
>>
>> Thanks for your help.
>>
>> ---
>> ~Randy
>> *** Remember to use Documentation/SubmitChecklist when testing your code ***
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Re: [PATCH -next] power_supply: fix sysfs format warning

[Anton Vorontsov]

On Mon, Aug 22, 2011 at 11:30:47AM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
> 
> Fix format warning:
> 
> drivers/power/power_supply_sysfs.c:82: warning: format '%d' expects type 'int', but argument 4 has type 'ssize_t'
> 
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> ---

Applied, thanks!

-- 
Anton Vorontsov
Email: cbouatmailru@gmail.com

Re: [PATCH -next] staging: fix comedi build when COMEDI_PCI is not enabled

[Greg KH]

On Mon, Aug 22, 2011 at 11:13:14AM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
> 
> Fix build when CONFIG_ISA_DMA_API is enabled but
> CONFIG_COMEDI_PCI[_DRIVERS] is not enabled.
> Fixes these build errors:
> 
> drivers/staging/comedi/drivers/ni_labpc.c: In function 'labpc_ai_cmd':
> drivers/staging/comedi/drivers/ni_labpc.c:1351: error: implicit declaration of function 'labpc_suggest_transfer_size'
> drivers/staging/comedi/drivers/ni_labpc.c: At top level:
> drivers/staging/comedi/drivers/ni_labpc.c:1802: error: conflicting types for 'labpc_suggest_transfer_size'
> drivers/staging/comedi/drivers/ni_labpc.c:1351: note: previous implicit declaration of 'labpc_suggest_transfer_size' was here
> 
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> ---
>  drivers/staging/comedi/drivers/ni_labpc.c |    4 +++-

I applied your older patch, which causes this one to not apply.  Is it
still needed as well?

thanks,

greg k-h

Re: [PATCH -next] staging: fix comedi build when COMEDI_PCI is not enabled

[Randy Dunlap]

On Tue, 23 Aug 2011 11:58:05 -0700 Greg KH wrote:

> On Mon, Aug 22, 2011 at 11:13:14AM -0700, Randy Dunlap wrote:
> > From: Randy Dunlap <rdunlap@xenotime.net>
> > 
> > Fix build when CONFIG_ISA_DMA_API is enabled but
> > CONFIG_COMEDI_PCI[_DRIVERS] is not enabled.
> > Fixes these build errors:
> > 
> > drivers/staging/comedi/drivers/ni_labpc.c: In function 'labpc_ai_cmd':
> > drivers/staging/comedi/drivers/ni_labpc.c:1351: error: implicit declaration of function 'labpc_suggest_transfer_size'
> > drivers/staging/comedi/drivers/ni_labpc.c: At top level:
> > drivers/staging/comedi/drivers/ni_labpc.c:1802: error: conflicting types for 'labpc_suggest_transfer_size'
> > drivers/staging/comedi/drivers/ni_labpc.c:1351: note: previous implicit declaration of 'labpc_suggest_transfer_size' was here
> > 
> > Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> > ---
> >  drivers/staging/comedi/drivers/ni_labpc.c |    4 +++-
> 
> I applied your older patch, which causes this one to not apply.  Is it
> still needed as well?

Nope, the second (more recent) one is not needed.  Thanks.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

Re: linux-next: Tree for Aug 22 (evm)

[Randy Dunlap]

On Mon, 22 Aug 2011 22:09:18 -0400 Mimi Zohar wrote:

> On Mon, 2011-08-22 at 17:49 -0700, Randy Dunlap wrote:
> > On Mon, 22 Aug 2011 20:47:00 -0400 Arnaud Lacombe wrote:
> > 
> > > Hi,
> > > 
> > > On Mon, Aug 22, 2011 at 3:53 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
> > > > On Mon, 22 Aug 2011 14:53:04 +1000 Stephen Rothwell wrote:
> > > >
> > > >> Hi all,
> > > >>
> > > >> [The kernel.org mirroring is a bit low today]
> > > >
> > > > (on x86_64:)
> > > >
> > > > When CONFIG_EVM=y, CONFIG_CRYPTO_HASH2=m, CONFIG_TRUSTED_KEYS=m,
> > > > CONFIG_ENCRYPTED_KEYS=m, the build fails with:
> > > >
> > > You did not provide the value of CONFIG_TCG_TPM, I'll assume it was
> > > 'm'. That said, correct me if I'm wrong, but we currently have:
> > 
> > Yes, it was 'm'.
> > 
> > > menuconfig TCG_TPM
> > >         tristate "TPM Hardware Support"
> > > 
> > > [...]
> > > 
> > > config EVM
> > >         boolean "EVM support"
> > >         depends on SECURITY && KEYS && TCG_TPM
> > > 
> > > which seems terribly broken to me... How can you have a built-in
> > > feature, which depends on another potentially-not-built-in feature ?
> > 
> > Yup.
> 
> Easy, different use cases. The TPM has been around and used for a while,
> not requiring it to be built-in.  EVM, a new use case, requires it to be
> built-in.
> 
> > > If you change EVM to 'tristate', you will see that you are not allowed
> > > to make it built-in if TCG_TPM is not built-in.
> > 
> > Right.
> 
> The TPM, crypto, trusted and encrypted keys are tristate.  Like the
> LSMs, EVM is boolean, which when selected using 'make xconfig', converts
> the tristates to built-in.  The tristate/boolean mismatches aren't
> corrected, when .config is edited directly.


> Mimi:

This isn't a problem about editing .config directly.  I haven't done that
here.  Also, if 'make xconfig' would convert tristates to built-in, then
so would 'make oldconfig', which is done automatically if configs have
changed (or maybe it's 'make silentoldconfig').

I think that you are going to need to do something like Arnaud suggested
and use "depends on TCG_TPM=y" instead of just "depends on TCG_TPM",
unless you can convince someone that this is a kconfig bug.


> > >  - Arnaud
> > > 
> > > > (.text+0x378aa): undefined reference to `key_type_encrypted'
> > > > evm_crypto.c:(.text+0x37992): undefined reference to `crypto_alloc_shash'
> > > > evm_crypto.c:(.text+0x37a24): undefined reference to `crypto_shash_setkey'
> > > > evm_crypto.c:(.text+0x37ad9): undefined reference to `crypto_shash_update'
> > > > evm_crypto.c:(.text+0x37aeb): undefined reference to `crypto_shash_final'
> > > > (.text+0x37b4b): undefined reference to `crypto_shash_update'
> > > > (.text+0x37c61): undefined reference to `crypto_shash_update'
> > > > (.text+0x37cb9): undefined reference to `crypto_shash_update'
> > > >
> > > > even though EVM (Kconfig) selects ENCRYPTED_KEYS and TRUSTED_KEYS..
> > > > and even after I add "select CRYPTO_HASH2".
> > > >
> > > > Is this because EVM is bool and kconfig is confused about 'select's
> > > > when a bool is selecting tristates?  Shouldn't the tristates become
> > > > 'y' instead of 'm' if they are selected by a bool that is 'y'?
> > > >
> > > >
> > > > xconfig shows these symbol values:
> > > >
> > > > Symbol: EVM [=y]
> > > > Type : boolean
> > > > Prompt: EVM support
> > > > Defined at security/integrity/evm/Kconfig:1
> > > > Depends on: SECURITY [=y] && KEYS [=y] && TCG_TPM [=m]
> > > > Location:
> > > > -> Security options
> > > > Selects: CRYPTO_HMAC [=m] && CRYPTO_MD5 [=m] && CRYPTO_SHA1 [=m] && CRYPTO_HASH2 [=m] && ENCRYPTED_KEYS [=m] && TRUSTED_KEYS [=m]
> > > >
> > > >
> > > > Hm, changing TCG_TPM to =y also changes TRUSTED_KEYS and ENCRYPTED_KEYS and
> > > > lots of CRYPTO_ symbols from =m to =y.  There must be some kind of min/max
> > > > symbol checking that is confused?
> > > >
> > > there is definitively an underlying min/max, but I would not point
> > > finger too fast.
> > 
> > 
> > Thanks for your help.


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

Re: linux-next: Tree for Aug 22 (evm)

[Mimi Zohar]

On Mon, 2011-08-22 at 22:24 -0400, Arnaud Lacombe wrote:
> Hi,
> 
> On Mon, Aug 22, 2011 at 10:09 PM, Mimi Zohar <zohar@linux.vnet.ibm.com> wrote:
> > On Mon, 2011-08-22 at 17:49 -0700, Randy Dunlap wrote:
> >> On Mon, 22 Aug 2011 20:47:00 -0400 Arnaud Lacombe wrote:
> >>
> >> > Hi,
> >> >
> >> > On Mon, Aug 22, 2011 at 3:53 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
> >> > > On Mon, 22 Aug 2011 14:53:04 +1000 Stephen Rothwell wrote:
> >> > >
> >> > >> Hi all,
> >> > >>
> >> > >> [The kernel.org mirroring is a bit low today]
> >> > >
> >> > > (on x86_64:)
> >> > >
> >> > > When CONFIG_EVM=y, CONFIG_CRYPTO_HASH2=m, CONFIG_TRUSTED_KEYS=m,
> >> > > CONFIG_ENCRYPTED_KEYS=m, the build fails with:
> >> > >
> >> > You did not provide the value of CONFIG_TCG_TPM, I'll assume it was
> >> > 'm'. That said, correct me if I'm wrong, but we currently have:
> >>
> >> Yes, it was 'm'.
> >>
> >> > menuconfig TCG_TPM
> >> >         tristate "TPM Hardware Support"
> >> >
> >> > [...]
> >> >
> >> > config EVM
> >> >         boolean "EVM support"
> >> >         depends on SECURITY && KEYS && TCG_TPM
> >> >
> >> > which seems terribly broken to me... How can you have a built-in
> >> > feature, which depends on another potentially-not-built-in feature ?
> >>
> >> Yup.
> >
> > Easy, different use cases. The TPM has been around and used for a while,
> > not requiring it to be built-in.  EVM, a new use case, requires it to be
> > built-in.
> >
> What behavior is expected when TPM is built as a module ? Would you
> expect EVM to be accessible ?
> 
> >> > If you change EVM to 'tristate', you will see that you are not allowed
> >> > to make it built-in if TCG_TPM is not built-in.
> >>
> >> Right.
> >
> > The TPM, crypto, trusted and encrypted keys are tristate.  Like the
> > LSMs, EVM is boolean, which when selected using 'make xconfig', converts
> > the tristates to built-in.  The tristate/boolean mismatches aren't
> > corrected, when .config is edited directly.
> >
> well, ... no. 'xconfig' would seem to let you think they have been
> changed to 'y', but they have not. I have been able to generate a bad
> configuration (TPM module, EVM built-in) using only {menu,x}config.
> 
> btw, I never edit the configuration manually, there is a big fat "DO
> NOT EDIT" header in the beginning.
> 
> Depending on what you expect, one way to fix that is to make EVM
> depends on TCG_TPM = y, not just TCG_TPM.
> 
>  - Arnaud

Thanks, that seems to work for now.  I'd really like to remove the
trusted-key and TCG_TPM dependencies from encrypted keys.  Thus removing
the TCG_TPM dependency from EVM.  But then, trusted keys could be
enabled differently than encrypted keys.  

Is there a way of allowing 'A' not to be dependent on 'B', but if 'B' is
defined, force 'B' to be built-in if 'A' is built-in, or as a module if
'A' is a module?

thanks,

Mimi

Re: linux-next: Tree for Aug 22 (evm)

[Arnaud Lacombe]

Hi,

On Tue, Aug 23, 2011 at 7:40 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
> I think that you are going to need to do something like Arnaud suggested
> and use "depends on TCG_TPM=y" instead of just "depends on TCG_TPM",
> unless you can convince someone that this is a kconfig bug.
>
dammit... I guess there is...

If you consider the following Kconfig:

config MOD
        bool
        default y
        option modules

config EXPERIMENTAL
        bool
        default y

menuconfig A
        tristate "A"
        depends on EXPERIMENTAL

config B
        bool "B"

config B0
        bool

config C
        tristate "C"
        depends on B

config C0
        tristate

config D
        boolean "D"
        depends on A && B
        select C
        select C0

config E
        tristate "E"

config F
        tristate "F"
        select E

B (KEYS) allows to set C (TRUSTED_KEYS). Also, B (KEYS) and A
(TCG_TPM) allows to set D (EVM), which will select (C). Now,
menuconfig highlight the problem very well. Proceeding as following
A=m, B=y, C=m, E=y, F=y, we ends up having:

 <M> A  --->
 [*] B
 {M} C
 [*] D
 -*- E
 <*> F

which translate in the following config:

CONFIG_MOD=y
CONFIG_EXPERIMENTAL=y
CONFIG_A=m
CONFIG_B=y
CONFIG_C=m
CONFIG_C0=m
CONFIG_D=y
CONFIG_E=y
CONFIG_F=y

I would have expected CONFIG_C and CONFIG_C0 to be 'y', just as 'E'.
If you remove D's dependency on 'A', everything works as expected. So
it would seem direct dependency state influence the state of reverse
dependencies...

Will have a look...

 - Arnaud

Re: linux-next: Tree for Aug 22 (evm)

[Mimi Zohar]

On Tue, 2011-08-23 at 22:10 -0400, Arnaud Lacombe wrote:
> Hi,
> 
> On Tue, Aug 23, 2011 at 7:40 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
> > I think that you are going to need to do something like Arnaud suggested
> > and use "depends on TCG_TPM=y" instead of just "depends on TCG_TPM",
> > unless you can convince someone that this is a kconfig bug.
> >
> dammit... I guess there is...
> 
> If you consider the following Kconfig:
> 
> config MOD
>         bool
>         default y
>         option modules
> 
> config EXPERIMENTAL
>         bool
>         default y
> 
> menuconfig A
>         tristate "A"
>         depends on EXPERIMENTAL
> 
> config B
>         bool "B"
> 
> config B0
>         bool
> 
> config C
>         tristate "C"
>         depends on B
> 
> config C0
>         tristate
> 
> config D
>         boolean "D"
>         depends on A && B
>         select C
>         select C0
> 
> config E
>         tristate "E"
> 
> config F
>         tristate "F"
>         select E
> 
> B (KEYS) allows to set C (TRUSTED_KEYS). Also, B (KEYS) and A
> (TCG_TPM) allows to set D (EVM), which will select (C). Now,
> menuconfig highlight the problem very well. Proceeding as following
> A=m, B=y, C=m, E=y, F=y, we ends up having:
> 
>  <M> A  --->
>  [*] B
>  {M} C
>  [*] D
>  -*- E
>  <*> F
> 
> which translate in the following config:
> 
> CONFIG_MOD=y
> CONFIG_EXPERIMENTAL=y
> CONFIG_A=m
> CONFIG_B=y
> CONFIG_C=m
> CONFIG_C0=m
> CONFIG_D=y
> CONFIG_E=y
> CONFIG_F=y
> 
> I would have expected CONFIG_C and CONFIG_C0 to be 'y', just as 'E'.
> If you remove D's dependency on 'A', everything works as expected. So
> it would seem direct dependency state influence the state of reverse
> dependencies...
> 
> Will have a look...
> 
>  - Arnaud

Thanks for looking into this!  Instead of changing 'TCG_TPM' to
'TCG_TPM=y', the dependency should be on 'TRUSTED_KEYS=y'.  Then when
I've refactored ENCRYPTED_KEYS, removing the ENCRYPTED_KEYS dependency
on TRUSTED_KEYS, the EVM dependency would be '(TRUSTED_KEYS=y ||
TRUSTED_KEYS=n)'.  Do you want a temporary fix for now?

thanks,

Mimi

Re: linux-next: Tree for Aug 22 (evm)

[Randy Dunlap]

On Fri, 26 Aug 2011 08:39:02 -0400 Mimi Zohar wrote:

> On Tue, 2011-08-23 at 22:10 -0400, Arnaud Lacombe wrote:
> > Hi,
> > 
> > On Tue, Aug 23, 2011 at 7:40 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
> > > I think that you are going to need to do something like Arnaud suggested
> > > and use "depends on TCG_TPM=y" instead of just "depends on TCG_TPM",
> > > unless you can convince someone that this is a kconfig bug.
> > >
> > dammit... I guess there is...
> > 
> > If you consider the following Kconfig:
> > 
> > config MOD
> >         bool
> >         default y
> >         option modules
> > 
> > config EXPERIMENTAL
> >         bool
> >         default y
> > 
> > menuconfig A
> >         tristate "A"
> >         depends on EXPERIMENTAL
> > 
> > config B
> >         bool "B"
> > 
> > config B0
> >         bool
> > 
> > config C
> >         tristate "C"
> >         depends on B
> > 
> > config C0
> >         tristate
> > 
> > config D
> >         boolean "D"
> >         depends on A && B
> >         select C
> >         select C0
> > 
> > config E
> >         tristate "E"
> > 
> > config F
> >         tristate "F"
> >         select E
> > 
> > B (KEYS) allows to set C (TRUSTED_KEYS). Also, B (KEYS) and A
> > (TCG_TPM) allows to set D (EVM), which will select (C). Now,
> > menuconfig highlight the problem very well. Proceeding as following
> > A=m, B=y, C=m, E=y, F=y, we ends up having:
> > 
> >  <M> A  --->
> >  [*] B
> >  {M} C
> >  [*] D
> >  -*- E
> >  <*> F
> > 
> > which translate in the following config:
> > 
> > CONFIG_MOD=y
> > CONFIG_EXPERIMENTAL=y
> > CONFIG_A=m
> > CONFIG_B=y
> > CONFIG_C=m
> > CONFIG_C0=m
> > CONFIG_D=y
> > CONFIG_E=y
> > CONFIG_F=y
> > 
> > I would have expected CONFIG_C and CONFIG_C0 to be 'y', just as 'E'.
> > If you remove D's dependency on 'A', everything works as expected. So
> > it would seem direct dependency state influence the state of reverse
> > dependencies...
> > 
> > Will have a look...
> > 
> >  - Arnaud
> 
> Thanks for looking into this!  Instead of changing 'TCG_TPM' to
> 'TCG_TPM=y', the dependency should be on 'TRUSTED_KEYS=y'.  Then when
> I've refactored ENCRYPTED_KEYS, removing the ENCRYPTED_KEYS dependency
> on TRUSTED_KEYS, the EVM dependency would be '(TRUSTED_KEYS=y ||
> TRUSTED_KEYS=n)'.  Do you want a temporary fix for now?

Yes, linux-next (randconfig) builds are still failing, so we need something
to prevent that.

thanks,
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

Re: linux-next: Tree for Aug 22 (evm)

[Arnaud Lacombe]

Hi,

On Fri, Aug 26, 2011 at 1:00 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
> On Fri, 26 Aug 2011 08:39:02 -0400 Mimi Zohar wrote:
>
>> On Tue, 2011-08-23 at 22:10 -0400, Arnaud Lacombe wrote:
>> > Hi,
>> >
>> > On Tue, Aug 23, 2011 at 7:40 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
>> > > I think that you are going to need to do something like Arnaud suggested
>> > > and use "depends on TCG_TPM=y" instead of just "depends on TCG_TPM",
>> > > unless you can convince someone that this is a kconfig bug.
>> > >
>> > dammit... I guess there is...
>> >
>> > If you consider the following Kconfig:
>> >
>> > config MOD
>> >         bool
>> >         default y
>> >         option modules
>> >
>> > config EXPERIMENTAL
>> >         bool
>> >         default y
>> >
>> > menuconfig A
>> >         tristate "A"
>> >         depends on EXPERIMENTAL
>> >
>> > config B
>> >         bool "B"
>> >
>> > config B0
>> >         bool
>> >
>> > config C
>> >         tristate "C"
>> >         depends on B
>> >
>> > config C0
>> >         tristate
>> >
>> > config D
>> >         boolean "D"
>> >         depends on A && B
>> >         select C
>> >         select C0
>> >
>> > config E
>> >         tristate "E"
>> >
>> > config F
>> >         tristate "F"
>> >         select E
>> >
>> > B (KEYS) allows to set C (TRUSTED_KEYS). Also, B (KEYS) and A
>> > (TCG_TPM) allows to set D (EVM), which will select (C). Now,
>> > menuconfig highlight the problem very well. Proceeding as following
>> > A=m, B=y, C=m, E=y, F=y, we ends up having:
>> >
>> >  <M> A  --->
>> >  [*] B
>> >  {M} C
>> >  [*] D
>> >  -*- E
>> >  <*> F
>> >
>> > which translate in the following config:
>> >
>> > CONFIG_MOD=y
>> > CONFIG_EXPERIMENTAL=y
>> > CONFIG_A=m
>> > CONFIG_B=y
>> > CONFIG_C=m
>> > CONFIG_C0=m
>> > CONFIG_D=y
>> > CONFIG_E=y
>> > CONFIG_F=y
>> >
>> > I would have expected CONFIG_C and CONFIG_C0 to be 'y', just as 'E'.
>> > If you remove D's dependency on 'A', everything works as expected. So
>> > it would seem direct dependency state influence the state of reverse
>> > dependencies...
>> >
>> > Will have a look...
>> >
>> >  - Arnaud
>>
>> Thanks for looking into this!  Instead of changing 'TCG_TPM' to
>> 'TCG_TPM=y', the dependency should be on 'TRUSTED_KEYS=y'.  Then when
>> I've refactored ENCRYPTED_KEYS, removing the ENCRYPTED_KEYS dependency
>> on TRUSTED_KEYS, the EVM dependency would be '(TRUSTED_KEYS=y ||
>> TRUSTED_KEYS=n)'.  Do you want a temporary fix for now?
>
> Yes, linux-next (randconfig) builds are still failing, so we need something
> to prevent that.
>
you may want to try:

git://github.com/lacombar/linux-2.6.git master/kconfig/expr-woes

only the last commit is relevant to the problem, but depend on one
another to get <assert.h>. The rest aims at tidying the expr stuff.
I'm looking for regression it may have introduced.

Thanks,
 - Arnaud

ps: I'll most likely be AFK until sunday evening (to be conservative).

> thanks,
> ---
> ~Randy
> *** Remember to use Documentation/SubmitChecklist when testing your code ***
>

Re: linux-next: Tree for Aug 22 (evm)

[Arnaud Lacombe]

Hi,

On Sat, Aug 27, 2011 at 2:06 AM, Arnaud Lacombe <lacombar@gmail.com> wrote:
> Hi,
>
> On Fri, Aug 26, 2011 at 1:00 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
>> On Fri, 26 Aug 2011 08:39:02 -0400 Mimi Zohar wrote:
>>
>>> On Tue, 2011-08-23 at 22:10 -0400, Arnaud Lacombe wrote:
>>> > Hi,
>>> >
>>> > On Tue, Aug 23, 2011 at 7:40 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
>>> > > I think that you are going to need to do something like Arnaud suggested
>>> > > and use "depends on TCG_TPM=y" instead of just "depends on TCG_TPM",
>>> > > unless you can convince someone that this is a kconfig bug.
>>> > >
>>> > dammit... I guess there is...
>>> >
>>> > If you consider the following Kconfig:
>>> >
>>> > config MOD
>>> >         bool
>>> >         default y
>>> >         option modules
>>> >
>>> > config EXPERIMENTAL
>>> >         bool
>>> >         default y
>>> >
>>> > menuconfig A
>>> >         tristate "A"
>>> >         depends on EXPERIMENTAL
>>> >
>>> > config B
>>> >         bool "B"
>>> >
>>> > config B0
>>> >         bool
>>> >
>>> > config C
>>> >         tristate "C"
>>> >         depends on B
>>> >
>>> > config C0
>>> >         tristate
>>> >
>>> > config D
>>> >         boolean "D"
>>> >         depends on A && B
>>> >         select C
>>> >         select C0
>>> >
>>> > config E
>>> >         tristate "E"
>>> >
>>> > config F
>>> >         tristate "F"
>>> >         select E
>>> >
>>> > B (KEYS) allows to set C (TRUSTED_KEYS). Also, B (KEYS) and A
>>> > (TCG_TPM) allows to set D (EVM), which will select (C). Now,
>>> > menuconfig highlight the problem very well. Proceeding as following
>>> > A=m, B=y, C=m, E=y, F=y, we ends up having:
>>> >
>>> >  <M> A  --->
>>> >  [*] B
>>> >  {M} C
>>> >  [*] D
>>> >  -*- E
>>> >  <*> F
>>> >
>>> > which translate in the following config:
>>> >
>>> > CONFIG_MOD=y
>>> > CONFIG_EXPERIMENTAL=y
>>> > CONFIG_A=m
>>> > CONFIG_B=y
>>> > CONFIG_C=m
>>> > CONFIG_C0=m
>>> > CONFIG_D=y
>>> > CONFIG_E=y
>>> > CONFIG_F=y
>>> >
>>> > I would have expected CONFIG_C and CONFIG_C0 to be 'y', just as 'E'.
>>> > If you remove D's dependency on 'A', everything works as expected. So
>>> > it would seem direct dependency state influence the state of reverse
>>> > dependencies...
>>> >
>>> > Will have a look...
>>> >
>>> >  - Arnaud
>>>
>>> Thanks for looking into this!  Instead of changing 'TCG_TPM' to
>>> 'TCG_TPM=y', the dependency should be on 'TRUSTED_KEYS=y'.  Then when
>>> I've refactored ENCRYPTED_KEYS, removing the ENCRYPTED_KEYS dependency
>>> on TRUSTED_KEYS, the EVM dependency would be '(TRUSTED_KEYS=y ||
>>> TRUSTED_KEYS=n)'.  Do you want a temporary fix for now?
>>
>> Yes, linux-next (randconfig) builds are still failing, so we need something
>> to prevent that.
>>
> you may want to try:
>
> git://github.com/lacombar/linux-2.6.git master/kconfig/expr-woes
>
ping ?

 - Arnaud

> only the last commit is relevant to the problem, but depend on one
> another to get <assert.h>. The rest aims at tidying the expr stuff.
> I'm looking for regression it may have introduced.
>
> Thanks,
>  - Arnaud
>
> ps: I'll most likely be AFK until sunday evening (to be conservative).
>
>> thanks,
>> ---
>> ~Randy
>> *** Remember to use Documentation/SubmitChecklist when testing your code ***
>>
>

Re: linux-next: Tree for Aug 22 (evm)

[Mimi Zohar]

On Thu, 2011-09-01 at 20:32 -0400, Arnaud Lacombe wrote:
> Hi,
> 
> On Sat, Aug 27, 2011 at 2:06 AM, Arnaud Lacombe <lacombar@gmail.com> wrote:
> > Hi,
> >
> > On Fri, Aug 26, 2011 at 1:00 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
> >> On Fri, 26 Aug 2011 08:39:02 -0400 Mimi Zohar wrote:
> >>
> >>> On Tue, 2011-08-23 at 22:10 -0400, Arnaud Lacombe wrote:
> >>> > Hi,
> >>> >
> >>> > On Tue, Aug 23, 2011 at 7:40 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
> >>> > > I think that you are going to need to do something like Arnaud suggested
> >>> > > and use "depends on TCG_TPM=y" instead of just "depends on TCG_TPM",
> >>> > > unless you can convince someone that this is a kconfig bug.
> >>> > >
> >>> > dammit... I guess there is...
> >>> >
> >>> > If you consider the following Kconfig:
> >>> >
> >>> > config MOD
> >>> >         bool
> >>> >         default y
> >>> >         option modules
> >>> >
> >>> > config EXPERIMENTAL
> >>> >         bool
> >>> >         default y
> >>> >
> >>> > menuconfig A
> >>> >         tristate "A"
> >>> >         depends on EXPERIMENTAL
> >>> >
> >>> > config B
> >>> >         bool "B"
> >>> >
> >>> > config B0
> >>> >         bool
> >>> >
> >>> > config C
> >>> >         tristate "C"
> >>> >         depends on B
> >>> >
> >>> > config C0
> >>> >         tristate
> >>> >
> >>> > config D
> >>> >         boolean "D"
> >>> >         depends on A && B
> >>> >         select C
> >>> >         select C0
> >>> >
> >>> > config E
> >>> >         tristate "E"
> >>> >
> >>> > config F
> >>> >         tristate "F"
> >>> >         select E
> >>> >
> >>> > B (KEYS) allows to set C (TRUSTED_KEYS). Also, B (KEYS) and A
> >>> > (TCG_TPM) allows to set D (EVM), which will select (C). Now,
> >>> > menuconfig highlight the problem very well. Proceeding as following
> >>> > A=m, B=y, C=m, E=y, F=y, we ends up having:
> >>> >
> >>> >  <M> A  --->
> >>> >  [*] B
> >>> >  {M} C
> >>> >  [*] D
> >>> >  -*- E
> >>> >  <*> F
> >>> >
> >>> > which translate in the following config:
> >>> >
> >>> > CONFIG_MOD=y
> >>> > CONFIG_EXPERIMENTAL=y
> >>> > CONFIG_A=m
> >>> > CONFIG_B=y
> >>> > CONFIG_C=m
> >>> > CONFIG_C0=m
> >>> > CONFIG_D=y
> >>> > CONFIG_E=y
> >>> > CONFIG_F=y
> >>> >
> >>> > I would have expected CONFIG_C and CONFIG_C0 to be 'y', just as 'E'.
> >>> > If you remove D's dependency on 'A', everything works as expected. So
> >>> > it would seem direct dependency state influence the state of reverse
> >>> > dependencies...
> >>> >
> >>> > Will have a look...
> >>> >
> >>> >  - Arnaud
> >>>
> >>> Thanks for looking into this!  Instead of changing 'TCG_TPM' to
> >>> 'TCG_TPM=y', the dependency should be on 'TRUSTED_KEYS=y'.  Then when
> >>> I've refactored ENCRYPTED_KEYS, removing the ENCRYPTED_KEYS dependency
> >>> on TRUSTED_KEYS, the EVM dependency would be '(TRUSTED_KEYS=y ||
> >>> TRUSTED_KEYS=n)'.  Do you want a temporary fix for now?
> >>
> >> Yes, linux-next (randconfig) builds are still failing, so we need something
> >> to prevent that.
> >>
> > you may want to try:
> >
> > git://github.com/lacombar/linux-2.6.git master/kconfig/expr-woes
> >
> ping ?
> 
>  - Arnaud

I assume you want me to test using expr-woes, but I'm not how.  Could
you help me here a bit.

(Over the weekend I removed encrypted keys dependency on TCG_TPM.)

thanks,

Mimi

> > only the last commit is relevant to the problem, but depend on one
> > another to get <assert.h>. The rest aims at tidying the expr stuff.
> > I'm looking for regression it may have introduced.
> >
> > Thanks,
> >  - Arnaud
> >
> > ps: I'll most likely be AFK until sunday evening (to be conservative).
> >
> >> thanks,
> >> ---
> >> ~Randy
> >> *** Remember to use Documentation/SubmitChecklist when testing your code ***
> >>
> >
> 

Re: linux-next: Tree for Aug 22 (evm)

[Arnaud Lacombe]

Hi,

On Thu, Sep 1, 2011 at 9:40 PM, Mimi Zohar <zohar@linux.vnet.ibm.com> wrote:
> On Thu, 2011-09-01 at 20:32 -0400, Arnaud Lacombe wrote:
>> Hi,
>>
>> On Sat, Aug 27, 2011 at 2:06 AM, Arnaud Lacombe <lacombar@gmail.com> wrote:
>> > Hi,
>> >
>> > On Fri, Aug 26, 2011 at 1:00 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
>> >> On Fri, 26 Aug 2011 08:39:02 -0400 Mimi Zohar wrote:
>> >>
>> >>> On Tue, 2011-08-23 at 22:10 -0400, Arnaud Lacombe wrote:
>> >>> > Hi,
>> >>> >
>> >>> > On Tue, Aug 23, 2011 at 7:40 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
>> >>> > > I think that you are going to need to do something like Arnaud suggested
>> >>> > > and use "depends on TCG_TPM=y" instead of just "depends on TCG_TPM",
>> >>> > > unless you can convince someone that this is a kconfig bug.
>> >>> > >
>> >>> > dammit... I guess there is...
>> >>> >
>> >>> > If you consider the following Kconfig:
>> >>> >
>> >>> > config MOD
>> >>> >         bool
>> >>> >         default y
>> >>> >         option modules
>> >>> >
>> >>> > config EXPERIMENTAL
>> >>> >         bool
>> >>> >         default y
>> >>> >
>> >>> > menuconfig A
>> >>> >         tristate "A"
>> >>> >         depends on EXPERIMENTAL
>> >>> >
>> >>> > config B
>> >>> >         bool "B"
>> >>> >
>> >>> > config B0
>> >>> >         bool
>> >>> >
>> >>> > config C
>> >>> >         tristate "C"
>> >>> >         depends on B
>> >>> >
>> >>> > config C0
>> >>> >         tristate
>> >>> >
>> >>> > config D
>> >>> >         boolean "D"
>> >>> >         depends on A && B
>> >>> >         select C
>> >>> >         select C0
>> >>> >
>> >>> > config E
>> >>> >         tristate "E"
>> >>> >
>> >>> > config F
>> >>> >         tristate "F"
>> >>> >         select E
>> >>> >
>> >>> > B (KEYS) allows to set C (TRUSTED_KEYS). Also, B (KEYS) and A
>> >>> > (TCG_TPM) allows to set D (EVM), which will select (C). Now,
>> >>> > menuconfig highlight the problem very well. Proceeding as following
>> >>> > A=m, B=y, C=m, E=y, F=y, we ends up having:
>> >>> >
>> >>> >  <M> A  --->
>> >>> >  [*] B
>> >>> >  {M} C
>> >>> >  [*] D
>> >>> >  -*- E
>> >>> >  <*> F
>> >>> >
>> >>> > which translate in the following config:
>> >>> >
>> >>> > CONFIG_MOD=y
>> >>> > CONFIG_EXPERIMENTAL=y
>> >>> > CONFIG_A=m
>> >>> > CONFIG_B=y
>> >>> > CONFIG_C=m
>> >>> > CONFIG_C0=m
>> >>> > CONFIG_D=y
>> >>> > CONFIG_E=y
>> >>> > CONFIG_F=y
>> >>> >
>> >>> > I would have expected CONFIG_C and CONFIG_C0 to be 'y', just as 'E'.
>> >>> > If you remove D's dependency on 'A', everything works as expected. So
>> >>> > it would seem direct dependency state influence the state of reverse
>> >>> > dependencies...
>> >>> >
>> >>> > Will have a look...
>> >>> >
>> >>> >  - Arnaud
>> >>>
>> >>> Thanks for looking into this!  Instead of changing 'TCG_TPM' to
>> >>> 'TCG_TPM=y', the dependency should be on 'TRUSTED_KEYS=y'.  Then when
>> >>> I've refactored ENCRYPTED_KEYS, removing the ENCRYPTED_KEYS dependency
>> >>> on TRUSTED_KEYS, the EVM dependency would be '(TRUSTED_KEYS=y ||
>> >>> TRUSTED_KEYS=n)'.  Do you want a temporary fix for now?
>> >>
>> >> Yes, linux-next (randconfig) builds are still failing, so we need something
>> >> to prevent that.
>> >>
>> > you may want to try:
>> >
>> > git://github.com/lacombar/linux-2.6.git master/kconfig/expr-woes
>> >
>> ping ?
>>
>>  - Arnaud
>
> I assume you want me to test using expr-woes, but I'm not how.  Could
> you help me here a bit.
>
> (Over the weekend I removed encrypted keys dependency on TCG_TPM.)
>
Well, at this point, this is not really related to the particular
issue, but to kconfig more generally. I guess I'll just post the
patches on LKML and see if they triggers non-wanted regression.

Thanks,
 - Arnaud

> thanks,
>
> Mimi
>
>> > only the last commit is relevant to the problem, but depend on one
>> > another to get <assert.h>. The rest aims at tidying the expr stuff.
>> > I'm looking for regression it may have introduced.
>> >
>> > Thanks,
>> >  - Arnaud
>> >
>> > ps: I'll most likely be AFK until sunday evening (to be conservative).
>> >
>> >> thanks,
>> >> ---
>> >> ~Randy
>> >> *** Remember to use Documentation/SubmitChecklist when testing your code ***
>> >>
>> >
>>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Re: linux-next: Tree for Aug 22 (evm)

[Randy Dunlap]

On Thu, 1 Sep 2011 22:21:16 -0400 Arnaud Lacombe wrote:

> Hi,
> 
> On Thu, Sep 1, 2011 at 9:40 PM, Mimi Zohar <zohar@linux.vnet.ibm.com> wrote:
> > On Thu, 2011-09-01 at 20:32 -0400, Arnaud Lacombe wrote:
> >> Hi,
> >>
> >> On Sat, Aug 27, 2011 at 2:06 AM, Arnaud Lacombe <lacombar@gmail.com> wrote:
> >> > Hi,
> >> >
> >> > On Fri, Aug 26, 2011 at 1:00 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
> >> >> On Fri, 26 Aug 2011 08:39:02 -0400 Mimi Zohar wrote:
> >> >>
> >> >>> On Tue, 2011-08-23 at 22:10 -0400, Arnaud Lacombe wrote:
> >> >>> > Hi,
> >> >>> >
> >> >>> > On Tue, Aug 23, 2011 at 7:40 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
> >> >>> > > I think that you are going to need to do something like Arnaud suggested
> >> >>> > > and use "depends on TCG_TPM=y" instead of just "depends on TCG_TPM",
> >> >>> > > unless you can convince someone that this is a kconfig bug.
> >> >>> > >
> >> >>> > dammit... I guess there is...
> >> >>> >
> >> >>> > If you consider the following Kconfig:

[snip]

> >> >>> > I would have expected CONFIG_C and CONFIG_C0 to be 'y', just as 'E'.
> >> >>> > If you remove D's dependency on 'A', everything works as expected. So
> >> >>> > it would seem direct dependency state influence the state of reverse
> >> >>> > dependencies...
> >> >>> >
> >> >>> > Will have a look...
> >> >>> >
> >> >>> >  - Arnaud
> >> >>>
> >> >>> Thanks for looking into this!  Instead of changing 'TCG_TPM' to
> >> >>> 'TCG_TPM=y', the dependency should be on 'TRUSTED_KEYS=y'.  Then when
> >> >>> I've refactored ENCRYPTED_KEYS, removing the ENCRYPTED_KEYS dependency
> >> >>> on TRUSTED_KEYS, the EVM dependency would be '(TRUSTED_KEYS=y ||
> >> >>> TRUSTED_KEYS=n)'.  Do you want a temporary fix for now?
> >> >>
> >> >> Yes, linux-next (randconfig) builds are still failing, so we need something
> >> >> to prevent that.
> >> >>
> >> > you may want to try:
> >> >
> >> > git://github.com/lacombar/linux-2.6.git master/kconfig/expr-woes
> >> >
> >> ping ?
> >>
> >>  - Arnaud
> >
> > I assume you want me to test using expr-woes, but I'm not how.  Could
> > you help me here a bit.
> >
> > (Over the weekend I removed encrypted keys dependency on TCG_TPM.)
> >
> Well, at this point, this is not really related to the particular
> issue, but to kconfig more generally. I guess I'll just post the
> patches on LKML and see if they triggers non-wanted regression.

Yes, please do that.

> Thanks,
>  - Arnaud
> 
> > thanks,
> >
> > Mimi
> >
> >> > only the last commit is relevant to the problem, but depend on one
> >> > another to get <assert.h>. The rest aims at tidying the expr stuff.
> >> > I'm looking for regression it may have introduced.
> >> >
> >> > Thanks,
> >> >  - Arnaud
> >> >
> >> > ps: I'll most likely be AFK until sunday evening (to be conservative).


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***