From: Emil Velikov <emil.l.velikov@gmail.com>
To: Vinay Simha BN <simhavcs@gmail.com>
Cc: open list <linux-kernel@vger.kernel.org>,
"open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
Archit Taneja <archit.taneja@gmail.com>
Subject: Re: [PATCH v2 3/4] drm/dsi: Implement dcs set/get display brightness
Date: Thu, 14 Jul 2016 22:20:48 +0100 [thread overview]
Message-ID: <CACvgo52ijPMDT=jNpyGTtzzEH4DksNdMC4mzENZZ1NhG0f=Spg@mail.gmail.com> (raw)
In-Reply-To: <1468428258-5601-3-git-send-email-simhavcs@gmail.com>
On 13 July 2016 at 17:44, Vinay Simha BN <simhavcs@gmail.com> wrote:
> +int mipi_dsi_dcs_get_display_brightness(struct mipi_dsi_device *dsi,
> + u16 *brightness)
> +{
> + ssize_t err;
> +
> + err = mipi_dsi_dcs_read(dsi, MIPI_DCS_GET_DISPLAY_BRIGHTNESS,
> + brightness, sizeof(*brightness));
> + if (err < 0) {
> + if (err == 0)
Something looks fishy here. This can never be true, can it ?
-Emil
next prev parent reply other threads:[~2016-07-14 21:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-13 16:44 [PATCH 1/4] dt-bindings: Add Japan Display Inc vendor id Vinay Simha BN
2016-07-13 16:44 ` [PATCH v2 2/4] dt-bindings: Add jdi lt070me05000 panel bindings Vinay Simha BN
2016-07-13 16:44 ` [PATCH v2 3/4] drm/dsi: Implement dcs set/get display brightness Vinay Simha BN
2016-07-14 21:20 ` Emil Velikov [this message]
2016-07-13 16:44 ` [PATCH v8 4/4] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel Vinay Simha BN
2016-07-13 18:58 ` John Stultz
2016-07-14 21:18 ` Emil Velikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACvgo52ijPMDT=jNpyGTtzzEH4DksNdMC4mzENZZ1NhG0f=Spg@mail.gmail.com' \
--to=emil.l.velikov@gmail.com \
--cc=archit.taneja@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=simhavcs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).