* [PATCH v2] selftests: nci: replace unsigned int with int
@ 2021-09-16 11:52 Xiang wangx
2021-09-16 12:07 ` Bongsu Jeon
0 siblings, 1 reply; 2+ messages in thread
From: Xiang wangx @ 2021-09-16 11:52 UTC (permalink / raw)
To: bongsu.jeon; +Cc: shuah, netdev, linux-kselftest, linux-kernel, Xiang wangx
Should not use comparison of unsigned expressions < 0
Signed-off-by: Xiang wangx <wangxiang@cdjrlc.com>
---
tools/testing/selftests/nci/nci_dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/nci/nci_dev.c b/tools/testing/selftests/nci/nci_dev.c
index e1bf55dabdf6..162c41e9bcae 100644
--- a/tools/testing/selftests/nci/nci_dev.c
+++ b/tools/testing/selftests/nci/nci_dev.c
@@ -746,7 +746,7 @@ int read_write_nci_cmd(int nfc_sock, int virtual_fd, const __u8 *cmd, __u32 cmd_
const __u8 *rsp, __u32 rsp_len)
{
char buf[256];
- unsigned int len;
+ int len;
send(nfc_sock, &cmd[3], cmd_len - 3, 0);
len = read(virtual_fd, buf, cmd_len);
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] selftests: nci: replace unsigned int with int
2021-09-16 11:52 [PATCH v2] selftests: nci: replace unsigned int with int Xiang wangx
@ 2021-09-16 12:07 ` Bongsu Jeon
0 siblings, 0 replies; 2+ messages in thread
From: Bongsu Jeon @ 2021-09-16 12:07 UTC (permalink / raw)
To: Xiang wangx; +Cc: Bongsu Jeon, shuah, netdev, linux-kselftest, linux-kernel
I asked you two things.
Please check them below.
On Thu, Sep 16, 2021 at 8:54 PM Xiang wangx <wangxiang@cdjrlc.com> wrote:
>
> Should not use comparison of unsigned expressions < 0
Please put '.' at the end of the log and add the changelog.
For example
=> Should not use comparison of unsigned expressions < 0.
>
> Signed-off-by: Xiang wangx <wangxiang@cdjrlc.com>
> ---
Please add the change log here.
For example =>
Changes since v1
* Change commit log
> tools/testing/selftests/nci/nci_dev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/nci/nci_dev.c b/tools/testing/selftests/nci/nci_dev.c
> index e1bf55dabdf6..162c41e9bcae 100644
> --- a/tools/testing/selftests/nci/nci_dev.c
> +++ b/tools/testing/selftests/nci/nci_dev.c
> @@ -746,7 +746,7 @@ int read_write_nci_cmd(int nfc_sock, int virtual_fd, const __u8 *cmd, __u32 cmd_
> const __u8 *rsp, __u32 rsp_len)
> {
> char buf[256];
> - unsigned int len;
> + int len;
>
> send(nfc_sock, &cmd[3], cmd_len - 3, 0);
> len = read(virtual_fd, buf, cmd_len);
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-16 12:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-16 11:52 [PATCH v2] selftests: nci: replace unsigned int with int Xiang wangx
2021-09-16 12:07 ` Bongsu Jeon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).