From: Grant Likely <grant.likely@secretlab.ca>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Jiri Kosina <jikos@kernel.org>,
benjamin.tissoires@redhat.com,
Jonathan Cameron <jic23@kernel.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
linux-iio@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
chaya.golan@intel.com, daniel.drubin@intel.com,
Darren Hart <darren@dvhart.com>
Subject: Re: [RFC 0/4] Intel Integrated Sensor Hub Support (ISH)
Date: Thu, 9 Jun 2016 22:45:13 +0100 [thread overview]
Message-ID: <CACxGe6udQ9H5_OBg+h8BB4Bru5Air0LYxtGQkUvr91ebtUE+SA@mail.gmail.com> (raw)
In-Reply-To: <1464668878-17113-1-git-send-email-srinivas.pandruvada@linux.intel.com>
On Tue, May 31, 2016 at 5:27 AM, Srinivas Pandruvada
<srinivas.pandruvada@linux.intel.com> wrote:
> Starting from Cherrytrail, multiple generation of Intel processors offers
> on package sensor hub. Several recent tablets, 2-in-1 convertible laptops
> are using ISH instead of external sensor hubs. This resulted in lack of
> support of sensor function like device rotation and auto backlight
> adjustment. In addition, depending on the OEM implementation, support of ISH
> is required to support low power sleep states.
>
> The support of ISH on Linux platforms is not new. Android platforms with
> Intel SoCs had this support for a while submitted by Daniel Drubin.
> This patcheset is reusing most of those changes with clean up and
> removing Android platform specific changes.
Hi Srinivas,
Thanks for this patch series. I've got an HP Spectre x360 G2
(skylake), and I've built a 4.6.0 kernel with this driver patched in.
It detects the sensors hub, and creates IIO devices under
/sys/bus/iio/devices:
$ ls /sys/bus/iio/devices/
iio:device0 iio:device1 iio:device2 iio:device3 iio:device4
iio:device5 iio:device6 iio:device7 iio:device8 iio:device9
trigger0 trigger1 trigger2 trigger3 trigger4 trigger5 trigger6
trigger7 trigger8 trigger9
However, I haven't figured out how to test it yet. (This is the first
time I'm working with IIO). Do you have any test code or test
procedures to show if it is working?
Thanks,
g.
>
> This series is tested on:
> - Lenovo Yoga 260 with Skylake processor
> - HP Pavilion x2 detachable with Cherrytrail
>
> The user mode ABI is still same as external sensor hubs using Linux
> IIO. So existing user mode software should still work without change.
> This series primarily brings in new HID transport used in ISH.
>
> This series submitted as a RFC to try on several devices. We have
> received request from Linux users who wanted this support. So I hope all
> those users try and give feedback.
>
> Daniel Drubin (3):
> hid: intel_ish-hid: ISH Transport layer
> hid: intel-ish-hid: ipc layer
> hid: intel-ish-hid: ISH HID client driver
>
> Srinivas Pandruvada (1):
> Documentation: hid: Intel ISH HID document
>
> Documentation/hid/intel-ish-hid.txt | 375 +++++++++
> drivers/hid/Kconfig | 2 +
> drivers/hid/Makefile | 2 +
> drivers/hid/intel-ish-hid/Kconfig | 27 +
> drivers/hid/intel-ish-hid/Makefile | 20 +
> drivers/hid/intel-ish-hid/ipc/hw-ish-regs.h | 220 +++++
> drivers/hid/intel-ish-hid/ipc/hw-ish.h | 71 ++
> drivers/hid/intel-ish-hid/ipc/ipc.c | 710 ++++++++++++++++
> drivers/hid/intel-ish-hid/ipc/pci-ish.c | 238 ++++++
> drivers/hid/intel-ish-hid/ipc/utils.h | 65 ++
> drivers/hid/intel-ish-hid/ishtp-hid-client.c | 672 +++++++++++++++
> drivers/hid/intel-ish-hid/ishtp-hid.c | 201 +++++
> drivers/hid/intel-ish-hid/ishtp-hid.h | 157 ++++
> drivers/hid/intel-ish-hid/ishtp/bus.c | 670 +++++++++++++++
> drivers/hid/intel-ish-hid/ishtp/bus.h | 99 +++
> drivers/hid/intel-ish-hid/ishtp/client.c | 1131 ++++++++++++++++++++++++++
> drivers/hid/intel-ish-hid/ishtp/client.h | 196 +++++
> drivers/hid/intel-ish-hid/ishtp/dma-if.c | 175 ++++
> drivers/hid/intel-ish-hid/ishtp/hbm.c | 911 +++++++++++++++++++++
> drivers/hid/intel-ish-hid/ishtp/hbm.h | 319 ++++++++
> drivers/hid/intel-ish-hid/ishtp/init.c | 94 +++
> drivers/hid/intel-ish-hid/ishtp/ishtp-dev.h | 276 +++++++
> include/trace/events/intel_ish.h | 30 +
> 23 files changed, 6661 insertions(+)
> create mode 100644 Documentation/hid/intel-ish-hid.txt
> create mode 100644 drivers/hid/intel-ish-hid/Kconfig
> create mode 100644 drivers/hid/intel-ish-hid/Makefile
> create mode 100644 drivers/hid/intel-ish-hid/ipc/hw-ish-regs.h
> create mode 100644 drivers/hid/intel-ish-hid/ipc/hw-ish.h
> create mode 100644 drivers/hid/intel-ish-hid/ipc/ipc.c
> create mode 100644 drivers/hid/intel-ish-hid/ipc/pci-ish.c
> create mode 100644 drivers/hid/intel-ish-hid/ipc/utils.h
> create mode 100644 drivers/hid/intel-ish-hid/ishtp-hid-client.c
> create mode 100644 drivers/hid/intel-ish-hid/ishtp-hid.c
> create mode 100644 drivers/hid/intel-ish-hid/ishtp-hid.h
> create mode 100644 drivers/hid/intel-ish-hid/ishtp/bus.c
> create mode 100644 drivers/hid/intel-ish-hid/ishtp/bus.h
> create mode 100644 drivers/hid/intel-ish-hid/ishtp/client.c
> create mode 100644 drivers/hid/intel-ish-hid/ishtp/client.h
> create mode 100644 drivers/hid/intel-ish-hid/ishtp/dma-if.c
> create mode 100644 drivers/hid/intel-ish-hid/ishtp/hbm.c
> create mode 100644 drivers/hid/intel-ish-hid/ishtp/hbm.h
> create mode 100644 drivers/hid/intel-ish-hid/ishtp/init.c
> create mode 100644 drivers/hid/intel-ish-hid/ishtp/ishtp-dev.h
> create mode 100644 include/trace/events/intel_ish.h
>
> --
> 1.9.1
>
next prev parent reply other threads:[~2016-06-09 21:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 4:27 [RFC 0/4] Intel Integrated Sensor Hub Support (ISH) Srinivas Pandruvada
2016-05-31 4:27 ` [RFC 1/4] Documentation: hid: Intel ISH HID document Srinivas Pandruvada
2016-05-31 4:27 ` [RFC 2/4] hid: intel_ish-hid: ISH Transport layer Srinivas Pandruvada
2016-05-31 4:27 ` [RFC 3/4] hid: intel-ish-hid: ipc layer Srinivas Pandruvada
2016-05-31 4:27 ` [RFC 4/4] hid: intel-ish-hid: ISH HID client driver Srinivas Pandruvada
2016-06-01 13:36 ` [RFC 0/4] Intel Integrated Sensor Hub Support (ISH) Atri Bhattacharya
2016-06-09 21:45 ` Grant Likely [this message]
2016-06-09 21:54 ` Srinivas Pandruvada
2016-06-10 9:44 ` Grant Likely
2016-06-10 13:55 ` Srinivas Pandruvada
2016-06-10 14:26 ` Bastien Nocera
2016-06-10 14:45 ` Srinivas Pandruvada
2016-06-10 15:04 ` Bastien Nocera
2016-06-10 15:23 ` Srinivas Pandruvada
2016-06-10 15:27 ` Bastien Nocera
2016-06-14 13:44 ` Grant Likely
2016-06-14 15:12 ` Bastien Nocera
2016-06-14 16:08 ` Grant Likely
2016-06-14 17:01 ` Bastien Nocera
2016-06-14 21:33 ` Grant Likely
2016-06-10 14:02 ` Grant Likely
2016-06-02 14:35 me
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACxGe6udQ9H5_OBg+h8BB4Bru5Air0LYxtGQkUvr91ebtUE+SA@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=benjamin.tissoires@redhat.com \
--cc=chaya.golan@intel.com \
--cc=daniel.drubin@intel.com \
--cc=darren@dvhart.com \
--cc=jic23@kernel.org \
--cc=jikos@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).