[PATCH] arch/arm/mm/proc-arm925.S: remove dead #ifdef block

[PATCH] arch/arm/mm/proc-arm925.S: remove dead #ifdef block

[Valentin Rothberg]

The block could never be compiled;  CPU_ICACHE_STREAMING_DISABLE has not
been defined in Kconfig since the very first Git commit.  Hence, we can
safely remove the entire block.

Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com>
---
There is a similar looking option 'CPU_ICACHE_DISABLE'.  However, I
decided to remove the entire block since it could not be compiled for
such a long time.

I detected this issue with scripts/checkkconfigsymbols.py
---
 arch/arm/mm/proc-arm925.S | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/arm/mm/proc-arm925.S b/arch/arm/mm/proc-arm925.S
index ede8c54ab4aa..32a47cc19076 100644
--- a/arch/arm/mm/proc-arm925.S
+++ b/arch/arm/mm/proc-arm925.S
@@ -441,9 +441,6 @@ ENTRY(cpu_arm925_set_pte_ext)
 	.type	__arm925_setup, #function
 __arm925_setup:
 	mov	r0, #0
-#if defined(CONFIG_CPU_ICACHE_STREAMING_DISABLE)
-        orr     r0,r0,#1 << 7
-#endif
 
 	/* Transparent on, D-cache clean & flush mode. See  NOTE2 above */
         orr     r0,r0,#1 << 1			@ transparent mode on
-- 
2.1.4

Re: [PATCH] arch/arm/mm/proc-arm925.S: remove dead #ifdef block

[Paul Bolle]

On Tue, 2015-04-28 at 18:45 +0200, Valentin Rothberg wrote:
> The block could never be compiled;  CPU_ICACHE_STREAMING_DISABLE has not
> been defined in Kconfig since the very first Git commit.

Actually, this goes back to a patch titled "1759/1: Add ARM925 support,
updated" that landed in v2.6.4.

When cleaning up ancient cruft like this it's fun, at least I think it
is, and possibly even informative, to have a Linux history repository at
hand. Feel free to prod me for details how to create such a repository.


Paul Bolle

Re: [PATCH] arch/arm/mm/proc-arm925.S: remove dead #ifdef block

[Valentin Rothberg]

On Tue, Apr 28, 2015 at 9:24 PM, Paul Bolle <pebolle@tiscali.nl> wrote:
> On Tue, 2015-04-28 at 18:45 +0200, Valentin Rothberg wrote:
>> The block could never be compiled;  CPU_ICACHE_STREAMING_DISABLE has not
>> been defined in Kconfig since the very first Git commit.
>
> Actually, this goes back to a patch titled "1759/1: Add ARM925 support,
> updated" that landed in v2.6.4.
>
> When cleaning up ancient cruft like this it's fun, at least I think it
> is, and possibly even informative, to have a Linux history repository at
> hand. Feel free to prod me for details how to create such a repository.

Thanks!  I just wanted to point out that this code hasn't been touched
since I was at high school : )  Do you link the repositories or do you
have a separate history repo?

Thanks,
 Valentin

> Paul Bolle
>

Re: [PATCH] arch/arm/mm/proc-arm925.S: remove dead #ifdef block

[Paul Bolle]

On Tue, 2015-04-28 at 21:36 +0200, Valentin Rothberg wrote:
> Thanks!  I just wanted to point out that this code hasn't been touched
> since I was at high school : )

(Yes, fine, do rub it in.)

Sure, for all practical purposes, v2.6.12-rc2 means: very, very long
ago. But I would be applaud if someone managed to outdo my reference to
v1.3.82 in commit e5a7286b5f1b ("x86, boot: Remove ancient,
unconditionally #ifdef'd out dead code").

> Do you link the repositories or do you have a separate history repo?

I started with https://archive.org/details/git-history-of-linux . Its
main drawback is that you have to the add tags for ancient releases
yourself. And that turned out to be quite time consuming.

Thanks,


Paul Bolle

Fwd: [PATCH] arch/arm/mm/proc-arm925.S: remove dead #ifdef block

[Valentin Rothberg]

Hi Russell,

I saw the patch below has made its way into today's linux-next tree.
Last week I sent a few patches fixing similar issues in arm, but I was
not sure if you are interested in such things to get fixed.  Are you
interested?  Another question: Do you have means to notify the sender
when you apply a patch?  Besides having fun doing such things, I also
have some research interest in it and I archive Kconfig related
emails; a notification mail would make it easier.

Kind regards,
 Valentin

---------- Forwarded message ----------
From: Valentin Rothberg <valentinrothberg@gmail.com>
Date: Tue, Apr 28, 2015 at 6:45 PM
Subject: [PATCH] arch/arm/mm/proc-arm925.S: remove dead #ifdef block
To: linux@arm.linux.org.uk, ard.biesheuvel@linaro.org,
nico@linaro.org, nsekhar@ti.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: Valentin Rothberg <valentinrothberg@gmail.com>


The block could never be compiled;  CPU_ICACHE_STREAMING_DISABLE has not
been defined in Kconfig since the very first Git commit.  Hence, we can
safely remove the entire block.

Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com>
---
There is a similar looking option 'CPU_ICACHE_DISABLE'.  However, I
decided to remove the entire block since it could not be compiled for
such a long time.

I detected this issue with scripts/checkkconfigsymbols.py
---
 arch/arm/mm/proc-arm925.S | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/arm/mm/proc-arm925.S b/arch/arm/mm/proc-arm925.S
index ede8c54ab4aa..32a47cc19076 100644
--- a/arch/arm/mm/proc-arm925.S
+++ b/arch/arm/mm/proc-arm925.S
@@ -441,9 +441,6 @@ ENTRY(cpu_arm925_set_pte_ext)
        .type   __arm925_setup, #function
 __arm925_setup:
        mov     r0, #0
-#if defined(CONFIG_CPU_ICACHE_STREAMING_DISABLE)
-        orr     r0,r0,#1 << 7
-#endif

        /* Transparent on, D-cache clean & flush mode. See  NOTE2 above */
         orr     r0,r0,#1 << 1                  @ transparent mode on
--
2.1.4

Re: Fwd: [PATCH] arch/arm/mm/proc-arm925.S: remove dead #ifdef block

[Russell King - ARM Linux]

On Mon, May 04, 2015 at 08:49:13AM +0200, Valentin Rothberg wrote:
> Hi Russell,
> 
> I saw the patch below has made its way into today's linux-next tree.
> Last week I sent a few patches fixing similar issues in arm, but I was
> not sure if you are interested in such things to get fixed.  Are you
> interested?

If they're worth having ;)

> Another question: Do you have means to notify the sender
> when you apply a patch?

Yes, but only if your patch is put into my patch system, where you'll
get an automatic email when it's applied.  It also helps them not to
get lost.  http://www.arm.linux.org.uk/developer/patches/

Thanks.

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.