From: Tim Kryger <tim.kryger@gmail.com>
To: Bjorn Andersson <bjorn@kryo.se>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Alexandre Courbot <acourbot@nvidia.com>,
Sachin Kamat <spk.linux@gmail.com>,
linux-mmc <linux-mmc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Alexandre Courbot <gnurou@gmail.com>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>
Subject: Re: Possible regression with commit 52221610d
Date: Tue, 13 Jan 2015 07:59:33 -0800 [thread overview]
Message-ID: <CAD7vxxKYAkAN3aQenEg+6=h2KTEgXxi3h1CAWR7Na7NAZiuM=A@mail.gmail.com> (raw)
In-Reply-To: <CAJAp7Oi0AyLxy1KFpZ-Cz1-ts9Lh2UaxP3+e6n3EyQjVaEfoXg@mail.gmail.com>
On Mon, Jan 5, 2015 at 11:52 AM, Bjorn Andersson <bjorn@kryo.se> wrote:
> On Sun, Dec 21, 2014 at 7:01 PM, Tim Kryger <tim.kryger@gmail.com> wrote:
>> On Wed, Dec 17, 2014 at 11:57 AM, Bjorn Andersson <bjorn@kryo.se> wrote:
> [..]
>>> Non-the-less, feel free to propose a patch and I will give it a test.
>>
>> Lets start with the simplest change first. Please give this a try and
>> let me know what you think.
>>
>> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
>> index ada1a3e..59a328a 100644
>> --- a/drivers/mmc/host/sdhci.c
>> +++ b/drivers/mmc/host/sdhci.c
>> @@ -1239,6 +1239,12 @@ static void sdhci_set_power(struct sdhci_host
>> *host, unsigned char mode,
>> spin_unlock_irq(&host->lock);
>> mmc_regulator_set_ocr(mmc, mmc->supply.vmmc, vdd);
>> spin_lock_irq(&host->lock);
>> +
>> + if (mode != MMC_POWER_OFF)
>> + sdhci_writeb(host, SDHCI_POWER_ON, SDHCI_POWER_CONTROL);
>> + else
>> + sdhci_writeb(host, 0, SDHCI_POWER_CONTROL);
>> +
>> return;
>> }
>>
>>
>> Thanks again for your help in getting to the bottom of this.
>
> Sorry for the delay, but
>
> Tested-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
>
> Regards,
> Bjorn
Thanks. I really appreciate your help.
-Tim
next prev parent reply other threads:[~2015-01-13 15:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 3:05 Possible regression with commit 52221610d Alexandre Courbot
2014-11-04 5:28 ` Tim Kryger
2014-11-04 9:00 ` Alexandre Courbot
2014-11-04 15:31 ` Tim Kryger
2014-11-05 8:10 ` Alexandre Courbot
2014-11-05 15:27 ` Tim Kryger
2014-11-06 2:15 ` Alexandre Courbot
2014-12-14 7:22 ` Bjorn Andersson
2014-12-15 4:48 ` Tim Kryger
2014-12-16 6:27 ` Bjorn Andersson
2014-12-16 18:18 ` Bjorn Andersson
2014-12-17 6:20 ` Tim Kryger
2014-12-17 19:57 ` Bjorn Andersson
2014-12-22 3:01 ` Tim Kryger
2015-01-05 19:52 ` Bjorn Andersson
2015-01-12 10:31 ` Ulf Hansson
2015-01-13 16:00 ` Tim Kryger
2015-01-13 15:59 ` Tim Kryger [this message]
2015-01-14 5:00 ` Tim Kryger
2014-12-16 18:46 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD7vxxKYAkAN3aQenEg+6=h2KTEgXxi3h1CAWR7Na7NAZiuM=A@mail.gmail.com' \
--to=tim.kryger@gmail.com \
--cc=acourbot@nvidia.com \
--cc=bjorn@kryo.se \
--cc=gnurou@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=spk.linux@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).