From: Doug Anderson <dianders@chromium.org>
To: Raju P L S S S N <rplsssn@codeaurora.org>
Cc: Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
linux-arm-msm@vger.kernel.org,
"open list:ARM/QUALCOMM SUPPORT" <linux-soc@vger.kernel.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
Stephen Boyd <sboyd@kernel.org>,
Evan Green <evgreen@chromium.org>,
Matthias Kaehlcke <mka@chromium.org>,
Lina Iyer <ilina@codeaurora.org>
Subject: Re: [PATCH v10 04/10] drivers: qcom: rpmh: add RPMH helper functions
Date: Wed, 13 Jun 2018 14:09:16 -0700 [thread overview]
Message-ID: <CAD=FV=ULcTE14gNYFA4hWpViDd6srXztvjbVTO7vBOKKMuEdSA@mail.gmail.com> (raw)
In-Reply-To: <1528737949-17495-5-git-send-email-rplsssn@codeaurora.org>
Hi,
On Mon, Jun 11, 2018 at 10:25 AM, Raju P L S S S N
<rplsssn@codeaurora.org> wrote:
> +void rpmh_tx_done(const struct tcs_request *msg, int r)
> +{
> + struct rpmh_request *rpm_msg = container_of(msg, struct rpmh_request,
> + msg);
> + struct completion *compl = rpm_msg->completion;
> +
> + rpm_msg->err = r;
> +
> + if (r)
> + dev_err(rpm_msg->dev, "RPMH TX fail in msg addr=%#x, err=%d\n",
> + rpm_msg->msg.cmds[0].addr, r);
> +
> + /* Signal the blocking thread we are done */
> + if (compl)
> + complete(compl);
> +}
> +EXPORT_SYMBOL(rpmh_tx_done);
You're back to too many EXPORT_SYMBOL's again. Just use this rule of thumb:
* If it's static, no EXPORT_SYMBOL.
* If the prototype is in "rpmh-internal.h", no EXPORT_SYMBOL.
* If the prototype is in "rpmh.h", then yes EXPORT_SYMBOL.
In the case of rpmh_tx_done: the protype is in rpmh-internal.h
To fix, squash in crosreview.com/1099841
-Doug
next prev parent reply other threads:[~2018-06-13 21:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 17:25 [PATCH v10 00/10] drivers/qcom: add RPMH communication support Raju P L S S S N
2018-06-11 17:25 ` [PATCH v10 01/10] drivers: qcom: rpmh-rsc: add RPMH controller for QCOM SoCs Raju P L S S S N
2018-06-11 17:25 ` [PATCH v10 02/10] dt-bindings: introduce RPMH RSC bindings for Qualcomm SoCs Raju P L S S S N
2018-06-11 17:25 ` [PATCH v10 03/10] drivers: qcom: rpmh-rsc: log RPMH requests in FTRACE Raju P L S S S N
2018-06-11 17:25 ` [PATCH v10 04/10] drivers: qcom: rpmh: add RPMH helper functions Raju P L S S S N
2018-06-13 21:09 ` Doug Anderson [this message]
2018-06-15 6:23 ` Raju P L S S S N
2018-06-11 17:25 ` [PATCH v10 05/10] drivers: qcom: rpmh-rsc: write sleep/wake requests to TCS Raju P L S S S N
2018-06-11 17:25 ` [PATCH v10 06/10] drivers: qcom: rpmh-rsc: allow invalidation of sleep/wake TCS Raju P L S S S N
2018-06-11 17:25 ` [PATCH v10 07/10] drivers: qcom: rpmh: cache sleep/wake state requests Raju P L S S S N
2018-06-11 17:25 ` [PATCH v10 08/10] drivers: qcom: rpmh: allow requests to be sent asynchronously Raju P L S S S N
2018-06-11 17:25 ` [PATCH v10 09/10] drivers: qcom: rpmh: add support for batch RPMH request Raju P L S S S N
2018-06-11 17:25 ` [PATCH v10 10/10] drivers: qcom: rpmh-rsc: allow active requests from wake TCS Raju P L S S S N
2018-06-13 21:09 ` Doug Anderson
2018-06-14 17:18 ` Lina Iyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=ULcTE14gNYFA4hWpViDd6srXztvjbVTO7vBOKKMuEdSA@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=evgreen@chromium.org \
--cc=ilina@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mka@chromium.org \
--cc=rnayak@codeaurora.org \
--cc=rplsssn@codeaurora.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).