From: Doug Anderson <dianders@chromium.org>
To: Raju P L S S S N <rplsssn@codeaurora.org>
Cc: Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
linux-arm-msm@vger.kernel.org,
"open list:ARM/QUALCOMM SUPPORT" <linux-soc@vger.kernel.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
Stephen Boyd <sboyd@kernel.org>,
Evan Green <evgreen@chromium.org>,
Matthias Kaehlcke <mka@chromium.org>,
Lina Iyer <ilina@codeaurora.org>
Subject: Re: [PATCH v10 10/10] drivers: qcom: rpmh-rsc: allow active requests from wake TCS
Date: Wed, 13 Jun 2018 14:09:52 -0700 [thread overview]
Message-ID: <CAD=FV=Vc_wtLTxM8A9T-RZ8h5XpkSLLUVJzmCQSytXFwOPRkOw@mail.gmail.com> (raw)
In-Reply-To: <1528737949-17495-11-git-send-email-rplsssn@codeaurora.org>
Hi,
On Mon, Jun 11, 2018 at 10:25 AM, Raju P L S S S N
<rplsssn@codeaurora.org> wrote:
> @@ -148,7 +148,8 @@ int rpmh_rsc_invalidate(struct rsc_drv *drv)
> static struct tcs_group *get_tcs_for_msg(struct rsc_drv *drv,
> const struct tcs_request *msg)
> {
> - int type;
> + int type, ret;
> + struct tcs_group *tcs;
>
> switch (msg->state) {
> case RPMH_ACTIVE_ONLY_STATE:
> @@ -164,7 +165,25 @@ static struct tcs_group *get_tcs_for_msg(struct rsc_drv *drv,
> return ERR_PTR(-EINVAL);
> }
>
> - return get_tcs_of_type(drv, type);
> + /*
> + * If we are making an active request on a RSC that does not have a
> + * dedicated TCS for active state use, then re-purpose a wake TCS to
> + * send active votes.
> + * NOTE: The driver must be aware that this RSC does not have a
> + * dedicated AMC, and therefore would invalidate the sleep and wake
> + * TCSes before making an active state request.
> + */
> + tcs = get_tcs_of_type(drv, type);
> + if (msg->state == RPMH_ACTIVE_ONLY_STATE && IS_ERR(tcs)) {
> + tcs = get_tcs_of_type(drv, WAKE_TCS);
> + if (!IS_ERR(tcs)) {
> + ret = rpmh_rsc_invalidate(drv);
> + if (ret)
> + return ERR_PTR(ret);
In v9 you looped as long as the "ret" was -EAGAIN. Now you're not.
Are all the callers setup to handle -EAGAIN or should you keep the
loop in for -EAGAIN? I don't think callers handle this well.
...or is there some reason that EAGAIN can't happen in this call to
rpmh_rsc_invalidate()?
-Doug
next prev parent reply other threads:[~2018-06-13 21:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 17:25 [PATCH v10 00/10] drivers/qcom: add RPMH communication support Raju P L S S S N
2018-06-11 17:25 ` [PATCH v10 01/10] drivers: qcom: rpmh-rsc: add RPMH controller for QCOM SoCs Raju P L S S S N
2018-06-11 17:25 ` [PATCH v10 02/10] dt-bindings: introduce RPMH RSC bindings for Qualcomm SoCs Raju P L S S S N
2018-06-11 17:25 ` [PATCH v10 03/10] drivers: qcom: rpmh-rsc: log RPMH requests in FTRACE Raju P L S S S N
2018-06-11 17:25 ` [PATCH v10 04/10] drivers: qcom: rpmh: add RPMH helper functions Raju P L S S S N
2018-06-13 21:09 ` Doug Anderson
2018-06-15 6:23 ` Raju P L S S S N
2018-06-11 17:25 ` [PATCH v10 05/10] drivers: qcom: rpmh-rsc: write sleep/wake requests to TCS Raju P L S S S N
2018-06-11 17:25 ` [PATCH v10 06/10] drivers: qcom: rpmh-rsc: allow invalidation of sleep/wake TCS Raju P L S S S N
2018-06-11 17:25 ` [PATCH v10 07/10] drivers: qcom: rpmh: cache sleep/wake state requests Raju P L S S S N
2018-06-11 17:25 ` [PATCH v10 08/10] drivers: qcom: rpmh: allow requests to be sent asynchronously Raju P L S S S N
2018-06-11 17:25 ` [PATCH v10 09/10] drivers: qcom: rpmh: add support for batch RPMH request Raju P L S S S N
2018-06-11 17:25 ` [PATCH v10 10/10] drivers: qcom: rpmh-rsc: allow active requests from wake TCS Raju P L S S S N
2018-06-13 21:09 ` Doug Anderson [this message]
2018-06-14 17:18 ` Lina Iyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=Vc_wtLTxM8A9T-RZ8h5XpkSLLUVJzmCQSytXFwOPRkOw@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=evgreen@chromium.org \
--cc=ilina@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mka@chromium.org \
--cc=rnayak@codeaurora.org \
--cc=rplsssn@codeaurora.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).